Received: by 10.213.65.68 with SMTP id h4csp649938imn; Fri, 23 Mar 2018 12:31:24 -0700 (PDT) X-Google-Smtp-Source: AG47ELvmBJQac8jLR4YadDJTO6cnYAcVeVUJ62bWs0yXC0oY8S8gBXqUJkLuImEOKf7zMUyBK0+T X-Received: by 10.99.63.205 with SMTP id m196mr4450256pga.82.1521833484867; Fri, 23 Mar 2018 12:31:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521833484; cv=none; d=google.com; s=arc-20160816; b=pM+hl1oFP+OBH++T0JfRBvu+QSoI3OWxLPbh/50XyxnBWeRjRtrHZBfi47zsjkyWpG N8LrfHBIlzgFXr8KcolwILgPLQl3BsWNdyrrGkbZMzSzR1W8K3jeG4f0ekEqWpVxrkXA yc+9j5Kf5cNfzjiRG+rHaPiGUAxaKyoSvQy3x/I/TE1vLzJ4gCqJv2GK99qUGyGf6I4Q u3KyQNClDrawuIOI4q9y7nYF7RfwQJB8FeiSrGw21/4gRUAQQSJAuKnEOTdwsJ292UE0 +tf4aJ05f0u1tMpgojqCOsgK1ZbTGWnPPnAhLFa5iRMt0D1PzxGF5xW0EzdlyaJE9bTf 5eoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:cc:references:to:subject:arc-authentication-results; bh=ewk03RMlpiCvmW/mq6rXUdKPhWDQYLBTaAOuh/zrMA0=; b=UlULvD5q+KJGHWroX4Qm/BYKbl6m1E2cOl8Hf3VHnG3t6U8LKmTEKSKqCU3v15myW4 n3EUriPIuGqM+sa1mOCN4Sr22OdvlYnIVysJvw8jOJs6+U3LWUsItHcML/p+R01Q0I2X vGv/1oXJc3D1a3tSjMNs0piyvjx+cDBXxOGeqCNcC3+61dYuDmId9fjF9EYpzrYpg/br FejOoGifwvXeomolToho3NubKDsxdYRds8k91E7Jnb7YFHYkdfBynK+2bN6aIsAlXxuC WWxXFJxT77SPFTa39CvZC4XkSSHdzn9D0J/CRwjUdT+o8N9wk/aQNUTiNoD+otALM71g YY2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v187si7250567pfv.25.2018.03.23.12.31.10; Fri, 23 Mar 2018 12:31:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbeCWTaS (ORCPT + 99 others); Fri, 23 Mar 2018 15:30:18 -0400 Received: from mga12.intel.com ([192.55.52.136]:2533 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbeCWTaB (ORCPT ); Fri, 23 Mar 2018 15:30:01 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Mar 2018 12:30:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,351,1517904000"; d="scan'208";a="185455589" Received: from ray.jf.intel.com (HELO [10.7.201.126]) ([10.7.201.126]) by orsmga004.jf.intel.com with ESMTP; 23 Mar 2018 12:30:00 -0700 Subject: Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC To: Shakeel Butt References: <20180323180903.33B17168@viggo.jf.intel.com> <20180323180911.E43ACAB8@viggo.jf.intel.com> Cc: Dave Hansen , LKML , Linux MM , linuxram@us.ibm.com, Thomas Gleixner , mpe@ellerman.id.au, Ingo Molnar , Andrew Morton , shuah@kernel.org From: Dave Hansen Message-ID: <9ef40243-3dc2-9bba-16b6-a94cffb57a24@intel.com> Date: Fri, 23 Mar 2018 12:29:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/2018 12:27 PM, Shakeel Butt wrote: > On Fri, Mar 23, 2018 at 12:23 PM, Dave Hansen wrote: >> On 03/23/2018 12:15 PM, Shakeel Butt wrote: >>>> We had a check for PROT_READ/WRITE, but it did not work >>>> for PROT_NONE. This entirely removes the PROT_* checks, >>>> which ensures that PROT_NONE now works. >>>> >>>> Reported-by: Shakeel Butt >>>> Signed-off-by: Dave Hansen >>> Should there be a 'Fixes' tag? Also should this patch go to stable? >> There could be, but I'm to lazy to dig up the original commit. Does it >> matter? >> > I think for stable 'Fixes' is usually preferable. This one is a no-brainer. If pkeys.c is there, it's necesary.