Received: by 10.213.65.68 with SMTP id h4csp659518imn; Fri, 23 Mar 2018 12:47:11 -0700 (PDT) X-Google-Smtp-Source: AG47ELs3ZEeUd+SvfpJIGJkVXsoyOL1XdLOVmLnSycADDgR1mavC2ZPe/yaJuh72lHfaV5XDOdM3 X-Received: by 10.98.93.20 with SMTP id r20mr1116310pfb.53.1521834431894; Fri, 23 Mar 2018 12:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521834431; cv=none; d=google.com; s=arc-20160816; b=ZEb0BO9zYT+1+f0AwrtnClXftqZMcogl6iIq8BtMGm0uzssx+fUtNDvEvJLvRVdVwd IuNn0sT2Hima/6psulVC+r4Y+B0g3B9ghoFn6dEH3dBJYNm1IBOLyLD/qQRI92CFbLoP d+b2ELXthjC8bKAqQwidJzrXnGkRBmY7ZtXjeBNu0X4aM8dSllHhP84msqK8byVM/yzM MsyqdTTpxgSYvkbWe2QqIyRMIYlcelFAEmmV7jEjFChiBnJLmdVIspMRq5n1JJDoWgdK 1BBk2n+2VpryNITvb0xgCYr09mN1IsQMDOVtV6ePjnw7KJujAR3UBcq6XZ3K+aNdx996 K5gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=sxlnugzTtLzDhBuVKFSz+p13F5bpmuemygfFmb1FZX8=; b=c6Xt0WxCN4yQ8E1RbNT3HxhqzgVSdgMOqOHwWwcA1jT1r01LNyPc1mOCRBNv1e7gnL Dahuk4BgEtMFTZmFBR8Z0kW1JcSEJHGfMmccH6qaHS4RP7u2kWNfaNNUYipsxyhIhHu7 BsB2IMsiMNOqClayIof1xcikJmcEbNkpfShcD6HLR9kbt573gu73bNBr7WjdUmjwoiOm msPKNBijg2rFq8bnCB/QFX7TYdXrRK2GOhGZHjAwYhT8bLvI8wxM/NBFNAEQZtL5OLL2 2a1s/bNW9DCmTqyc7Y87Uh6DZ/xkGLZY95qUP2lIl7WUZbb4KC0aoeYOOC3UQ3yyJ/D+ LEPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si2079033pgp.684.2018.03.23.12.46.56; Fri, 23 Mar 2018 12:47:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbeCWTqF (ORCPT + 99 others); Fri, 23 Mar 2018 15:46:05 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42226 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbeCWTqE (ORCPT ); Fri, 23 Mar 2018 15:46:04 -0400 Received: from p4fea5f09.dip0.t-ipconnect.de ([79.234.95.9] helo=nanos.glx-home) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ezSdU-0001zg-6p; Fri, 23 Mar 2018 20:46:00 +0100 Date: Fri, 23 Mar 2018 20:45:59 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: Shakeel Butt , Dave Hansen , LKML , Linux MM , linuxram@us.ibm.com, mpe@ellerman.id.au, Ingo Molnar , Andrew Morton , shuah@kernel.org Subject: Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC In-Reply-To: Message-ID: References: <20180323180903.33B17168@viggo.jf.intel.com> <20180323180911.E43ACAB8@viggo.jf.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Mar 2018, Thomas Gleixner wrote: > On Fri, 23 Mar 2018, Dave Hansen wrote: > > > On 03/23/2018 12:15 PM, Shakeel Butt wrote: > > >> We had a check for PROT_READ/WRITE, but it did not work > > >> for PROT_NONE. This entirely removes the PROT_* checks, > > >> which ensures that PROT_NONE now works. > > >> > > >> Reported-by: Shakeel Butt > > >> Signed-off-by: Dave Hansen > > > Should there be a 'Fixes' tag? Also should this patch go to stable? > > > > There could be, but I'm to lazy to dig up the original commit. Does it > > matter? > > > > And, yes, I think it probably makes sense for -stable. I'll add that if > > I resend this series. > > The fixes tag makes sense in general even if the patch is not tagged for > stable. It gives you immediate context and I use it a lot to look why this > went unnoticed or what the context of that change was. That said, I'm even lazier than you and prefer you to dig up the original commit :) Thanks, tglx