Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S271272AbTHMAR2 (ORCPT ); Tue, 12 Aug 2003 20:17:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S271276AbTHMAR2 (ORCPT ); Tue, 12 Aug 2003 20:17:28 -0400 Received: from fw.osdl.org ([65.172.181.6]:18644 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S271272AbTHMAR0 (ORCPT ); Tue, 12 Aug 2003 20:17:26 -0400 Date: Tue, 12 Aug 2003 17:14:07 -0700 From: "Randy.Dunlap" To: Jeff Garzik Cc: greg@kroah.com, willy@debian.org, davem@redhat.com, linux-kernel@vger.kernel.org, kernel-janitor-discuss@lists.sourceforge.net Subject: Re: C99 Initialisers Message-Id: <20030812171407.09f31455.rddunlap@osdl.org> In-Reply-To: <3F397FFB.9090601@pobox.com> References: <20030812020226.GA4688@zip.com.au> <1060654733.684.267.camel@localhost> <20030812023936.GE3169@parcelfarce.linux.theplanet.co.uk> <20030812053826.GA1488@kroah.com> <20030812112729.GF3169@parcelfarce.linux.theplanet.co.uk> <20030812180158.GA1416@kroah.com> <3F397FFB.9090601@pobox.com> Organization: OSDL X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) X-Face: +5V?h'hZQPB9kW Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1200 Lines: 28 On Tue, 12 Aug 2003 20:02:03 -0400 Jeff Garzik wrote: | Greg KH wrote: | > In the end, it's up to the maintainer of the driver what they want to ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | > do. So, Jeff and David, here's a patch against the latest 2.6.0-test3 | > tg3.c that converts the pci_device_id table to C99 initializers. If you | > want to, please apply it. I strongly agree with Greg's comment above. | | it expands a few lines to a bazillion :( I would rather leave it as | is... you'll find several PCI ethernet drivers with pci_device_id | entries that fit entirely on one line, and I think that compactness has | value at least to me. However, I would change for readability. Maybe not my readability, but for all others who read and try to help maintain all of Linux source code. -- ~Randy For Linux-2.6, see: http://www.kernel.org/pub/linux/kernel/people/davej/misc/post-halloween-2.5.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/