Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stuyoder@gmail.com" <stuyoder@gmail.com>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        Razvan Stefanescu <razvan.stefanescu@nxp.com>,
        Roy Pledge <roy.pledge@nxp.com>
Subject: RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
Thread-Topic: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support
Thread-Index: AQHTwr0rRbeSymdCeEiXdPiYqeyzd6Pd9tsAgAABPBCAAAU0gIAAQptA
Date:   Fri, 23 Mar 2018 20:13:47 +0000
Message-ID: <HE1PR04MB3212D27A5E02EE73FCB378DAE0A80@HE1PR04MB3212.eurprd04.prod.outlook.com>
References: <cover.1521818402.git.ioana.ciornei@nxp.com>
 <d8c243a9ead2fe1375dee242aec26d1276129409.1521818402.git.ioana.ciornei@nxp.com>
 <20180323154654.GA382@kroah.com>
 <HE1PR04MB32123F0FF506534B11A1CE5BE0A80@HE1PR04MB3212.eurprd04.prod.outlook.com>
 <20180323160957.GA3113@kroah.com>
In-Reply-To: <20180323160957.GA3113@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8eb48af4-63c4-471d-e8be-08d590fa9620
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2018 20:13:47.5881
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1353
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >
> > >
> > > On Fri, Mar 23, 2018 at 10:38:56AM -0500, Ioana Ciornei wrote:
> > > > +#include "fsl-mc-private.h"
> > > > +
> > > > +#define FSL_MC_BUS_MAX_MINORS	1
> > >
> > > As you only need/want one character device here, why not just use
> > > the misc device api?  It's much simpler, and handles all of the
> > > housekeeping for you correctly.  It also means I don't have to audit
> > > all of your chardev code to verify it is correct :)
> >
> > I have considered the misc device api but the fsl-mc bus, since it is
> > a platform driver, is probing before the misc char driver.
>=20
> How?  The misc code is just "core code" there's nothing to "probe" here.
> Is this an init-call ordering issue somehow?  A platform driver probe sho=
uld be
> after the misc core is initialized.  And if not, you can always defer you=
r probe.

Sorry for the previous improper wording. I have tested again using the misc=
 device api and indeed the devices on the fsl-mc bus are probing before the=
 misc core is initialized but I am able to complete the misc registration d=
eferring the probe the first time.

I will update the patch set and send a new version.

Ioana C


>=20
> thanks,
>=20
> greg k-h