Message-ID: <3F3986ED.1050206@pobox.com>
Date: Tue, 12 Aug 2003 20:31:41 -0400
From: Jeff Garzik <jgarzik@pobox.com>
Organization: none
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk
MIME-Version: 1.0
To: "Randy.Dunlap" <rddunlap@osdl.org>
CC: greg@kroah.com, willy@debian.org, davem@redhat.com,
       linux-kernel@vger.kernel.org,
       kernel-janitor-discuss@lists.sourceforge.net
Subject: Re: C99 Initialisers
References: <20030812020226.GA4688@zip.com.au>	<1060654733.684.267.camel@localhost>	<20030812023936.GE3169@parcelfarce.linux.theplanet.co.uk>	<20030812053826.GA1488@kroah.com>	<20030812112729.GF3169@parcelfarce.linux.theplanet.co.uk>	<20030812180158.GA1416@kroah.com>	<3F397FFB.9090601@pobox.com> <20030812171407.09f31455.rddunlap@osdl.org>
In-Reply-To: <20030812171407.09f31455.rddunlap@osdl.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1708
Lines: 42

Randy.Dunlap wrote:
> On Tue, 12 Aug 2003 20:02:03 -0400 Jeff Garzik <jgarzik@pobox.com> wrote:
> 
> | Greg KH wrote:
> | > In the end, it's up to the maintainer of the driver what they want to
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> | > do.  So, Jeff and David, here's a patch against the latest 2.6.0-test3
> | > tg3.c that converts the pci_device_id table to C99 initializers.  If you
> | > want to, please apply it.
> 
> I strongly agree with Greg's comment above.
> | 
> | it expands a few lines to a bazillion :(   I would rather leave it as 
> | is...  you'll find several PCI ethernet drivers with pci_device_id 
> | entries that fit entirely on one line, and I think that compactness has 
> | value at least to me.
> 
> However, I would change for readability.  Maybe not my readability,
> but for all others who read and try to help maintain all of Linux
> source code.


I find the compact form quite readable, and comfortable on the eyes. 
Users don't seem to complain, either.  I get compact-form pci_device_id 
patches from Joe Sixpack quite often :)

Expanding this device id struct to use C99 initializers isn't terribly 
scalable:  once you get past just a few ids, you bloat up the source 
code considerably.  I would much rather move the PCI ids out of the 
drivers altogether, into some metadata file(s) in the kernel source 
tree, than bloat up tg3, tulip, e100, and the other PCI id-heavy 
drivers' source code.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/