Received: by 10.213.65.68 with SMTP id h4csp916054imn; Fri, 23 Mar 2018 21:04:03 -0700 (PDT) X-Google-Smtp-Source: AG47ELsUJ/GXIOTqKegqH1c4j7Jz0UCoblVqvZZsOexWFhbxn67qJ8mFVQYxV06OMFzWcPniq4PC X-Received: by 2002:a17:902:70c4:: with SMTP id l4-v6mr17198982plt.344.1521864243392; Fri, 23 Mar 2018 21:04:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521864243; cv=none; d=google.com; s=arc-20160816; b=OFftrZGH/kEhZ1jsh6bzFhQjxeqROFWehbvc1UZizcGuaoRVf8AFZRiA1rOWMBzgVz ZYGRWLFCvBX9z7v4PdETfIeHEZjkuvy6941/8OcIBXv56j/fUpBVox5Dkx5PHM8gYKdh 0TqlR3QGAyxvGVM+ay/amxbWIJZTzjN+N+/BUg2VBLQM7Aull5M2p8dznGBW0D9beMVj 7lO7pKQlBAmTNcOaH26xoWprg8JUBjHY+8UkLxdJUnxqEDA6/VeFOe3DKBPEJIBhaIqC qmMCGDLON2eiEQxAjFYSCuYnCacqU5tkTBKAt3DSb86vWer60KJRO9SaMRd/5Wp0frX8 mgrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=2NI8XiOCf8fX2VIBNl0/D3nNccyOkseEGOJBH6aJ26M=; b=yBlL1w1kt2pLrMs5pQhVdgb/pFfavDWkJ1SfOlZVk++VZ36M6cnkVcWfxgkUbRGJ0+ 2m5kxc7ygKs9LJv7NctAOybVuyW5AltEk5dSW9VBy+4ALeHzG8wzLMWQxPlul45VxfDX +pRRzlLr0b0g/LTJtcuBcwWuBGhglMAvWv9zeAvi6bwroE6kC1ITktxbdPtJOUFNU6CG GanVDxEHLgdyncuARc8BP4f/eaSFaWo1WOJtWvBd+BeR98l4BCaw1ATpD/ZNlP5znYcK rjCGo5PFBY6xhnJdBP76OBC61FQiTB2QiYByPAwjW5Fc+/8OSsNg042Skh4LTVpNREkk 2Gqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=na+N4i2f; dkim=pass header.i=@codeaurora.org header.s=default header.b=TtzhyjKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a188si7607731pfb.248.2018.03.23.21.03.46; Fri, 23 Mar 2018 21:04:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=na+N4i2f; dkim=pass header.i=@codeaurora.org header.s=default header.b=TtzhyjKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750837AbeCXEC3 (ORCPT + 99 others); Sat, 24 Mar 2018 00:02:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33704 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750723AbeCXEC1 (ORCPT ); Sat, 24 Mar 2018 00:02:27 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3E5CB6070A; Sat, 24 Mar 2018 04:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521864147; bh=x/xQHHsbjqoR2fZpvDJHBMFzJdMV7mPJAzD8QbrAdZU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=na+N4i2flYXNCVlqmsTo/xtIIkNWKgY5HTxhIWLCoy9xrWkFoohoEStYHV5H98RXh KYyXHvgNbFB9N7DmG4BU1x0M2MctGFzsHvL/tm7mHppPiHvGjj3Kt2bB6rshLWvj2D xJwTGM1tPObr5C3rXzksVr7bZSMtUFhit4rpOcBU= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.0.105] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D69146055D; Sat, 24 Mar 2018 04:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521864146; bh=x/xQHHsbjqoR2fZpvDJHBMFzJdMV7mPJAzD8QbrAdZU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TtzhyjKd+E2tK5J8Jltw0A9qoUinPFqLQOVackyx2nHtamqhqdvtTIlcFCkOo6Zir HoDMgGlcmVJt+WH3zxJHAOKuYEP65ghdwsJdh0NOqBsWPOPC/H6B/B9+shZBzq2VmJ VYxChlSsShcEKHB270JRI9K0sK8XwOj6rWR+YJes= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D69146055D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH v6 6/6] bnxt_en: Eliminate duplicate barriers on weakly-ordered archs To: Michael Chan Cc: Netdev , timur@codeaurora.org, sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, open list References: <1521843791-21201-1-git-send-email-okaya@codeaurora.org> <1521843791-21201-7-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: <9a5f49c8-ce50-a153-44e1-6f21f8d1f44b@codeaurora.org> Date: Sat, 24 Mar 2018 00:02:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/2018 6:36 PM, Michael Chan wrote: >> + mmiowb(); > Sorry for the late review. mmiowb() is not required here because we > are in NAPI context, so only one CPU will be updating this doorbell. > > Other than that, it looks good. > OK, I'll fix this on the next version. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.