Received: by 10.213.65.68 with SMTP id h4csp1057886imn; Sat, 24 Mar 2018 02:10:11 -0700 (PDT) X-Google-Smtp-Source: AG47ELt6dI7B1R3//4DB8ipk02wPtHyMf3u5FQ4VusWXbks/1U0A98iDoRSZs4YBXYjzSlIoPays X-Received: by 2002:a17:902:b101:: with SMTP id q1-v6mr32839708plr.287.1521882611163; Sat, 24 Mar 2018 02:10:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521882611; cv=none; d=google.com; s=arc-20160816; b=AHx5Z8w8tLQRlGdcO37SLwnTyz6+NzcXY8XJjbiQKM2riz1xCHVXmoK2Aw6EXX2VD6 VCD29lSyAtf7rhg54oER6Dg8tH0Qy6yxzkIT+TcirCM974iSfVuFgA0gbyy6xiSKE0mz m+fDJSyRTzn88xZeCN+bHHhY/qwpDLK9HZeDiR2oKcwzZUc1E/fGfCaIyqpJn8a27DOt 6BB532lUTNXAwEUa9uCHqY1qlcyXNQh+Uk2c7x+a6XCHTmSdrx/GmiwAvFrmxmRA0OZ/ 0awTj+jzNkUAIsWkMMzE6xeVBCpicbKi5C2QbKUKmQUMLpviq1PtuHqYSf5zJK/3uyDq 75gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=xCzBhfx9pKE2vOje5jChCWcPZA5s1L6wwwcRGKSo2iM=; b=mMJrn4SQTjDubOg+/Rk3lxBkubXziLt7dx7EV8YHBYR3WAM+1CsMjbdGahuAxvNfkS vaJuewuPYlSOF+7PF4X3NYBJWyF0go40+xWgbbBEh8RdGbwOnTKPKBBZL16D+p/vISVr x2c6T6nKUqHtlMnpY7lhCIEUrkm3GbWJvuPCHoB0rzuAMVuwxwCT+HctwQlhKopxoVUf SxlTtYCY16xDyU4UFpvFoLxUt4fAVOBro3hLDKccJhMpDZ371Hbf8eZU+oBjtr3uIGRm JzOc8jvQZhrrfM3eGwumI6WtndKWJPxojHorOSRVl/8jrFzs5f2R3a0KzEceUS3ra4+r EZKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4-v6si10066452plv.166.2018.03.24.02.09.56; Sat, 24 Mar 2018 02:10:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbeCXJJD (ORCPT + 99 others); Sat, 24 Mar 2018 05:09:03 -0400 Received: from mout.web.de ([217.72.192.78]:35011 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbeCXJJA (ORCPT ); Sat, 24 Mar 2018 05:09:00 -0400 Received: from [192.168.1.2] ([78.49.44.104]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MI5ze-1f0Df61VZW-003tJP; Sat, 24 Mar 2018 10:08:38 +0100 Subject: Re: iio/gyro/bmg160_core: Improve unlocking of a mutex in five functions To: Jonathan Cameron , linux-iio@vger.kernel.org Cc: Greg Kroah-Hartman , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Pravin Shedge , Quentin Schulz , LKML , kernel-janitors@vger.kernel.org References: <16623de4-351d-135b-f3ff-701a465c5d92@users.sourceforge.net> <20180317195422.037a8b57@archlinux> <73f0a187-57d1-c877-ba9f-3b15f6a61640@users.sourceforge.net> <20180318101506.460f3967@archlinux> From: SF Markus Elfring Message-ID: <7faecfbc-0fea-b262-a81e-578615358081@users.sourceforge.net> Date: Sat, 24 Mar 2018 10:08:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180318101506.460f3967@archlinux> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:27tg7BZeTS/ti/HCmUkE2GmcGUY1F6VmEAORDfrKyXM/IG2d1gZ Wa5MQY23Hs0Uxm9n/+CUkRIQv51aZFDmuPUfH/eGgsTVxodNUNBuDzXqznRnQ71rAowine+ wkdLAUFSbte96f6R9fLwu5JS+v/UiRrXhyQqhQtFZTJgoE7zgw9yxd2prMIXIkUnVmICiRl rt0F5xJVoBogOl060eJYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:WJZ7peOpdcE=:i0j5S0KogZSyzwojO9MvEL DUoAm3geilSKWUhnMxXc1MiuwpCPOIh7R2vkwFrN1qTrJr48C92CyprF1dNRb1a3o89AOoRJm zmaMETnDMCY2qmyEwWLl63uZIQqXcwE+E4QWcmivZBMr0UwF1EUj+ST16B56zX5EAV7vfHQ9s r7mRp2AhBHkNIM7hL8YZ/hN/2HItcceUPQ7kTdagsrE0HIzMDUg+2TGmJyhkovX+ca1HchJRw jCsZUqptTRjlFyYj8ywPEfIH3jEOgCMAxp1lpb9iNY5rTqoE8/L6Dd3tuXGpdTgKmzD0vz6Co M83B3msBdMGHi2Jbs8HDkQVrFHcrSnPXDVvvHqT+OJLzrmnWYqM2WhzT2rAQBM5l4S7COnBEl T8f0CBp9Dea3v+xD0K5WzDZ1NOxpdYFLm4H7EjWXr/jeZyp7j40oDizLdbXpKPYRxG5OBxkmH KC+lyCeH3m3wL7innCxq/qZMYxOl2ERN0vpLaFlRrQu2ebUqdkE5Ax8vYn5oujrMAH/YBzRz9 RHAfJ1Q1MWS5hgslECTCdfcC29IZQ7dw+Fu6NbL2MIRZnN9fxM1THrUuXCJ1mrnV5QD2qkwek ppKUnoDEPU518uorg4bBOhG0jPCCPxinDcSJEshRJAfALK2v9lzU7EEEBgXD3jCGHM4C8E9f7 Wlp6I7dD7qv2XPNZ1xsVPj1a2cxpvV7cPYEZ7oN92K7meoaFHGiap6Pqxq+k92TtPYVTSbAnu WYojEM3XsET73FXMSeeOw6uKoI51nyAO9uGNSU1biS6VcOzkbTvwiNY2ehSzxZx6DBPKy4zjG k72UK3mt3W9PEqh4Rb+GhC0t8jsvaAi4BhOZUnQDdseE6Rkkuo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The mutex was (and is still only) locked within case branches, isn't it? >> > You are correct, this does however reflect the issue with the resulting > lack of balance here. Do you find changes for the other function implementations easier to integrate? Regards, Markus