Received: by 10.213.65.68 with SMTP id h4csp1249555imn; Sat, 24 Mar 2018 07:26:37 -0700 (PDT) X-Google-Smtp-Source: AG47ELvIqxSv0aLxrPDPhn+e5mr/Ta60pM6oUzhhiwcsHCZDP5bmasKKBtyZIt/g68/OO4c1qqFk X-Received: by 10.99.185.7 with SMTP id z7mr24432610pge.123.1521901597157; Sat, 24 Mar 2018 07:26:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1521901597; cv=none; d=google.com; s=arc-20160816; b=zA0M1QzIw/kYqRI35v7aZ3mYPXoV2RIMPhhKkxj33O1aMY0o0XtR4HU8+8ITCkkDVc nxcZitkdua1dEDO0DEX/fiQijivsjCF/2e1+yOPVooIu2OERI11PobkDHjFXYmguVUxa uP7hZDBg3LggyYjJPgkK1m4FaMO+KXoFavpeLQ3kizhOdUzrmbmMhkBZaz/M6q7Y+d5h gcADqAsFD/JUBNH4um6OyUjTyS9LC2sxSmTGDj6uCeAuPsXvGisOQiISGcJuLmOcFFM6 gSIi0rLZ15RgViLy05a+/byX+qZlmgceIcEbBlLtjMLlFvC8Lj+xil1Lc3vb9qdb8Jdn jrKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=gwNWf8b4B+KqRrv31Rz2dfbBSQk6Au8/4IGgo1DRp9A=; b=zGaT6qppNs8fu7hfVjjuAVEeD+vEG1Lb9Dh3+8ERmgniRTSybkIyeBU9TWfSEEBIvf qmpRn8b79WH35j8TjW9dsIvIiMNhXVnPiDhkVu4P8iO7HeyRm6aXegwpF/LPUINiXR3k 4skfvk4ugGk31ZTaoQAp8ep7G4IER7+ERJ5Wf2+D+ieSqSlOeZf3aEG8h+tIyjYJXgUp uOTgxhx7db1V01oFwCfro5CzUPXzBPNmpn60WhfwyHrBx4qe4hjEwuNxld+ukQoPT/O5 r46YXxbATXsWK09VMxvubQ7+gCLtOwwUG9V/RNh+pePc2o9kzTi50/b/2PH6S+8wGbIE NYIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j23-v6si7178798pll.150.2018.03.24.07.26.22; Sat, 24 Mar 2018 07:26:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbeCXOZ2 (ORCPT + 99 others); Sat, 24 Mar 2018 10:25:28 -0400 Received: from muru.com ([72.249.23.125]:33532 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbeCXOZ0 (ORCPT ); Sat, 24 Mar 2018 10:25:26 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 38F5D80AE; Sat, 24 Mar 2018 14:26:38 +0000 (UTC) Date: Sat, 24 Mar 2018 07:25:17 -0700 From: Tony Lindgren To: Dan Williams Cc: Pavel Machek , Sebastian Reichel , Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring Subject: Re: [PATCHv4] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Message-ID: <20180324142517.GA94954@atomide.com> References: <20180309023750.108942-1-tony@atomide.com> <20180322135553.GA27648@amd> <20180322164633.GF5799@atomide.com> <20180322192843.GA17189@amd> <20180323105455.GB21644@amd> <20180323113521.45va72bhzis6ym6m@earth.universe> <20180323201343.GC23658@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Williams [180324 14:00]: > On Fri, 2018-03-23 at 21:13 +0100, Pavel Machek wrote: > > Does ofonod work for you? I could not get that one to work... > > Because it's looking for a Gobi modem but the MDM6600 isn't one and > doesn't expose that layout (and doesn't really need to anyway). I > don't think ofono has a generic QMI driver, so you'd either need to for > ce it to use the telitqmi or quectelqmi drivers, or write your own > generic QMI one. We also get five USB uarts if we add the device id with something like the patch below. I don't quite get why we get five UARTS? Also not sure if we should be using drivers/usb/serial/qcaux.c instead of qcserial.c? And from what I recall trying it out, adding the USB UARTs somehow confused ModemManager I think, that needs to be retested though :) And the USB UARTs added do not offer the same set of AT commands as the n_gsm serial mux. Regards, Tony 8< ------------------ diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -181,6 +181,9 @@ static const struct usb_device_id id_table[] = { /* Huawei devices */ {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G Modem (Huawei me906e) */ + /* Motorola devices */ + {DEVICE_HWI(0x22b8, 0x2a70)}, /* Droid 4 mdm6600 */ + { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, id_table); -- 2.16.2