Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
To:     Haiyang Zhang <haiyangz@microsoft.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     KY Srinivasan <kys@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path
Thread-Topic: [PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path
Thread-Index: AQHTwhHxH07LHDYeH0ychb4hJXWI5qPfmCSg
Date:   Sat, 24 Mar 2018 16:48:07 +0000
Message-ID: <DM5PR2101MB103003AA72955A6C6AD44D0CDCAF0@DM5PR2101MB1030.namprd21.prod.outlook.com>
References: <20180322190114.25596-1-haiyangz@linuxonhyperv.com>
 <20180322190114.25596-2-haiyangz@linuxonhyperv.com>
In-Reply-To: <20180322190114.25596-2-haiyangz@linuxonhyperv.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=mikelley@ntdev.microsoft.com;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-03-24T16:48:04.3236663Z;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure
 Information Protection;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic;
 Sensitivity=General
x-originating-ip: [24.22.167.197]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR2101MB1030;7:wpwtes6u7VoLa+A1dTdW9HoNPD7UwpICwyeneoJSzaFRVexVGXNqRCd8vljWrBF+1aLGvn1sIEYct0xoHL4y4yprLV70Cv1tNXSyjq0IaJe3oObi7mB/hX1TTMKrCqG8Nxr2voe7oFdqL8TVMxXiylvil34hVkfOV7EXU94lXjr9TaAlrISQAVpr3dQbK9M4GStRAujQQ5VOTGLK0c+4Ati6k+t+zlmrYkTJGI/oy+nUuannnt/I6LiRI5+zcMUs;20:K100CYKd01mUBlf1omGwXOKBcnrG0nNAL8sm/eyIt2bmGfGq3kWtS68ntdkES2mWvBR/l/UIn5rrt+xpyeDE5wd7Yd5ii7X/dY8syBgj+bVA0by8KI+D1mEG+Z4QNYatRfybVwZGey0Nx/pNyewiOsXUmX94/dMj8D798mhk86A=
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 6fbbfc3a-c8dc-462d-494a-08d591a70580
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603328)(7193020);SRVR:DM5PR2101MB1030;
x-ms-traffictypediagnostic: DM5PR2101MB1030:
x-microsoft-antispam-prvs: <DM5PR2101MB1030C0B192664324A9A05B75DCAF0@DM5PR2101MB1030.namprd21.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(28532068793085)(20558992708506)(89211679590171)(9452136761055);
x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:DM5PR2101MB1030;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB1030;
x-forefront-prvs: 0621E7E436
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39380400002)(366004)(39860400002)(346002)(376002)(396003)(189003)(199004)(13464003)(22452003)(305945005)(74316002)(7736002)(478600001)(33656002)(5660300001)(14454004)(446003)(11346002)(316002)(8676002)(81156014)(110136005)(54906003)(8936002)(105586002)(229853002)(6116002)(3846002)(3280700002)(2906002)(72206003)(10290500003)(81166006)(86612001)(6346003)(76176011)(8990500004)(102836004)(26005)(59450400001)(25786009)(2900100001)(10090500001)(4326008)(5250100002)(7696005)(6506007)(53546011)(2501003)(66066001)(99286004)(6246003)(106356001)(1511001)(6436002)(55016002)(68736007)(53936002)(9686003)(97736004)(3660700001)(2201001)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB1030;H:DM5PR2101MB1030.namprd21.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Michael.H.Kelley@microsoft.com; 
x-microsoft-antispam-message-info: sVZa18mJmbN25uGI6syqxqfn8rDBQkx7oghM/zyAiWuwFeASkDC6FpBDuUDUPSNB6pG4MD8nLr/E4DVdmu0e/1n7mQy+cnMX4JGGai2nGrbQzt1ca3qr0Q8PaMmVW0bYv3gGjVlx30IC+hwIvALRHFE5byA67+0by5dn8jrTyAk1WsrWqD9pIZFhFM4bi8qCt822nccKGtm/Cw7qwkVsy3J+tRKkQjmWxMfg3AhpmyB69PeFeSLAbT1VXIDexwo5vU2MSFNQradG1M8BThB1B4JcJFQo1cCIshI5cnFfrUSqMoFBS1dtzyI4BNJrV0X9m77LtaaJ0a5HlFRfi+f5OA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fbbfc3a-c8dc-462d-494a-08d591a70580
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2018 16:48:07.9211
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1030
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org <linux-kernel-owner@vger.kernel.=
org> On Behalf
> Of Haiyang Zhang
> Sent: Thursday, March 22, 2018 12:01 PM
> To: davem@davemloft.net; netdev@vger.kernel.org
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; KY Srinivasan <kys@microsoft.=
com>; Stephen
> Hemminger <sthemmin@microsoft.com>; olaf@aepfle.de; vkuznets@redhat.com;
> devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
> Subject: [PATCH net-next,1/2] hv_netvsc: Fix the return status in RX path
>=20
> From: Haiyang Zhang <haiyangz@microsoft.com>
>=20
> As defined in hyperv_net.h, the NVSP_STAT_SUCCESS is one not zero.
> Some functions returns 0 when it actually means NVSP_STAT_SUCCESS.
> This patch fixes them.
>=20
> In netvsc_receive(), it puts the last RNDIS packet's receive status
> for all packets in a vmxferpage which may contain multiple RNDIS
> packets.
> This patch puts NVSP_STAT_FAIL in the receive completion if one of
> the packets in a vmxferpage fails.

This patch changes the status field that is being reported back to
the Hyper-V host in the receive completion message in
enq_receive_complete().   The current code reports 0 on success,
and with the patch, it will report 1 on success.  So does this change
affect anything on the Hyper-V side?  Or is Hyper-V just ignoring
the value?   If this change doesn't have any impact on the
interactions with Hyper-V, perhaps it would be good to explain
why in the commit message.

Michael

>=20
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
>  drivers/net/hyperv/netvsc.c       | 8 ++++++--
>  drivers/net/hyperv/netvsc_drv.c   | 2 +-
>  drivers/net/hyperv/rndis_filter.c | 4 ++--
>  3 files changed, 9 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index aa95e81af6e5..1ddb2c39b6e4 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -1098,12 +1098,16 @@ static int netvsc_receive(struct net_device *ndev=
,
>  		void *data =3D recv_buf
>  			+ vmxferpage_packet->ranges[i].byte_offset;
>  		u32 buflen =3D vmxferpage_packet->ranges[i].byte_count;
> +		int ret;
>=20
>  		trace_rndis_recv(ndev, q_idx, data);
>=20
>  		/* Pass it to the upper layer */
> -		status =3D rndis_filter_receive(ndev, net_device,
> -					      channel, data, buflen);
> +		ret =3D rndis_filter_receive(ndev, net_device,
> +					   channel, data, buflen);
> +
> +		if (unlikely(ret !=3D NVSP_STAT_SUCCESS))
> +			status =3D NVSP_STAT_FAIL;
>  	}
>=20
>  	enq_receive_complete(ndev, net_device, q_idx,
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_=
drv.c
> index cdb78eefab67..33607995be62 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -818,7 +818,7 @@ int netvsc_recv_callback(struct net_device *net,
>  	u64_stats_update_end(&rx_stats->syncp);
>=20
>  	napi_gro_receive(&nvchan->napi, skb);
> -	return 0;
> +	return NVSP_STAT_SUCCESS;
>  }
>=20
>  static void netvsc_get_drvinfo(struct net_device *net,
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis=
_filter.c
> index 2dc00f714482..591fb8080f11 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -443,10 +443,10 @@ int rndis_filter_receive(struct net_device *ndev,
>  			"unhandled rndis message (type %u len %u)\n",
>  			   rndis_msg->ndis_msg_type,
>  			   rndis_msg->msg_len);
> -		break;
> +		return NVSP_STAT_FAIL;
>  	}
>=20
> -	return 0;
> +	return NVSP_STAT_SUCCESS;
>  }
>=20
>  static int rndis_filter_query_device(struct rndis_device *dev,
> --
> 2.15.1