Received: by 10.213.65.68 with SMTP id h4csp753205imn; Sun, 25 Mar 2018 12:26:46 -0700 (PDT) X-Google-Smtp-Source: AG47ELsJk1TNP3czxzxHZm5bnvQOPbSeJtV1QFjrc/vx8wfkbHMhf8SYJTphOafb4BbSgmC5rXtx X-Received: by 10.98.87.151 with SMTP id i23mr12858911pfj.175.1522006005939; Sun, 25 Mar 2018 12:26:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522006005; cv=none; d=google.com; s=arc-20160816; b=cuip9qfih5QMc0CE87m5Z6cePG9+zn721NK7ikz4WHk2XtBSn0R8NtiyhHLFqFDP44 lb2zW8E5pGcfqxxpyl8ydNq8TzCckrtM5ZxW1ivJaTJd3wLiSvYVKJidNV/1avhzLqXJ hs/gqyXHMBjMYf41hEMubjQ5D4H9gSoUmG1yN7rtAAxdq8fV8MWrYWrttQU11u2ryIPy tAEJ8Mw+yTBg7kWnPthlJThbstSJBj0G5HB/dV4XGgE8zdjhymWrtVWL5GZjJip4jj4I ufTynobhkhVI7VQXsNXKnQqV/ZV+bY//lLNPjbe7NGFOgG3Go8+gJEToHPDZeAYO3dl7 hmuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=NpMYwfhTFIh46lWkI66FEfuMcBLW54FWO4l/ALvdzgU=; b=j492orszybPw0OxYPHT3sckuulPc6jZVTZVCJLqWW3zi4YqLkfEGGsMrMCapxb7SVt LIu+PUvyjCLSwd4xlRNdss56TbgKBpkLHX2AYR+olhSDQ/QXw3y8xTpUVck0jywq6D5a 7YOMmwEbpI0KLdMktRRskiSJvA2Rn9O+tmSYYT2ja3/GqUjT1m1HcisfD9C732NG+zeS 3uNPMYQepoay0BuWpMf81a2Vf/j2msD+rjGlFxhbPnrwFlQhGyfFLot8tWCELyQdW0Ng mhMcUubq8P3aYolWIj1fbsMnlJX36xn6R+hvfCcuNhBxBKVV6iAuJZ0/XvwdyjiF5Ygs AIMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f14si764557pfe.191.2018.03.25.12.26.31; Sun, 25 Mar 2018 12:26:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbeCYTYA (ORCPT + 99 others); Sun, 25 Mar 2018 15:24:00 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:32894 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbeCYTXY (ORCPT ); Sun, 25 Mar 2018 15:23:24 -0400 Received: from linux-n805.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Sun, 25 Mar 2018 13:23:17 -0600 From: Davidlohr Bueso To: peterz@infradead.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso , Wolfram Sang , linux-i2c@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 1/3] i2c: update i2c_trace_msg static key to modern api Date: Sun, 25 Mar 2018 12:10:54 -0700 Message-Id: <20180325191056.24598-2-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180325191056.24598-1-dave@stgolabs.net> References: <20180325191056.24598-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to i2c_trace_msg, for better self documentation. Cc: Wolfram Sang Cc: linux-i2c@vger.kernel.org Signed-off-by: Davidlohr Bueso --- drivers/i2c/i2c-core-base.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 16a3b73375a6..c8461fb26c0d 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -69,18 +69,18 @@ static DEFINE_IDR(i2c_adapter_idr); static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver); -static struct static_key i2c_trace_msg = STATIC_KEY_INIT_FALSE; +DEFINE_STATIC_KEY_FALSE(i2c_trace_msg_key); static bool is_registered; int i2c_transfer_trace_reg(void) { - static_key_slow_inc(&i2c_trace_msg); + static_branch_inc(&i2c_trace_msg_key); return 0; } void i2c_transfer_trace_unreg(void) { - static_key_slow_dec(&i2c_trace_msg); + static_branch_dec(&i2c_trace_msg_key); } const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id, @@ -1848,11 +1848,11 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) if (adap->quirks && i2c_check_for_quirks(adap, msgs, num)) return -EOPNOTSUPP; - /* i2c_trace_msg gets enabled when tracepoint i2c_transfer gets + /* i2c_trace_msg_key gets enabled when tracepoint i2c_transfer gets * enabled. This is an efficient way of keeping the for-loop from * being executed when not needed. */ - if (static_key_false(&i2c_trace_msg)) { + if (static_branch_unlikely(&i2c_trace_msg_key)) { int i; for (i = 0; i < num; i++) if (msgs[i].flags & I2C_M_RD) @@ -1871,7 +1871,7 @@ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) break; } - if (static_key_false(&i2c_trace_msg)) { + if (static_branch_unlikely(&i2c_trace_msg_key)) { int i; for (i = 0; i < ret; i++) if (msgs[i].flags & I2C_M_RD) -- 2.13.6