Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Mario.Limonciello@dell.com>
To:     <Alexander.Levin@microsoft.com>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
CC:     <robert.moore@intel.com>, <erik.schmauss@intel.com>,
        <rafael.j.wysocki@intel.com>
Subject: RE: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10
 version 1607 and 1703 OSI strings
Thread-Topic: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10
 version 1607 and 1703 OSI strings
Thread-Index: AQHTv5xaTVO5Yc6WFEyJ+eHwrZ3EpqPiKMtA
Date:   Mon, 26 Mar 2018 07:30:24 +0000
Message-ID: <bc4e6f52fc2d45b5b7672c22aaa4dc55@ausx13mpc120.AMER.DELL.COM>
References: <20180319160513.16384-1-alexander.levin@microsoft.com>
 <20180319160513.16384-93-alexander.levin@microsoft.com>
In-Reply-To: <20180319160513.16384-93-alexander.levin@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: Sasha Levin [mailto:Alexander.Levin@microsoft.com]
> Sent: Monday, March 19, 2018 11:07 AM
> To: linux-kernel@vger.kernel.org; stable@vger.kernel.org
> Cc: Limonciello, Mario <Mario_Limonciello@Dell.com>; Bob Moore
> <robert.moore@intel.com>; Erik Schmauss <erik.schmauss@intel.com>; Rafael=
 J .
> Wysocki <rafael.j.wysocki@intel.com>; Sasha Levin
> <Alexander.Levin@microsoft.com>
> Subject: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10
> version 1607 and 1703 OSI strings
>=20
> From: Mario Limonciello <mario.limonciello@dell.com>
>=20
> [ Upstream commit bc4d413a819f9d0764a80a55875a5d7e1f4efed4 ]
>=20
> ACPICA commit 35a4a3ea723b3066f575e63e5f0116f7ce65e713
>=20
> The public Microsoft document listing recognized OSI strings [1]
> shows that these two strings were introduced.
> version 1607 / Anniversary Update / "Redstone 1"
> version 1703 / Creators Update / "Redstone 2"
>=20
> [1] http://download.microsoft.com/download/7/e/7/7e7662cf-cbea-470b-a97e-
> ce7ce0d98dc2/winacpi_osi.docx
>=20
> Link: https://github.com/acpica/acpica/commit/35a4a3ea
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> Signed-off-by: Bob Moore <robert.moore@intel.com>
> Signed-off-by: Erik Schmauss <erik.schmauss@intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
> ---
>  drivers/acpi/acpica/utosi.c | 2 ++
>  include/acpi/actypes.h      | 2 ++
>  2 files changed, 4 insertions(+)
>=20
> diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c
> index 8f3d203aed79..51d9011b5b33 100644
> --- a/drivers/acpi/acpica/utosi.c
> +++ b/drivers/acpi/acpica/utosi.c
> @@ -101,6 +101,8 @@ static struct acpi_interface_info
> acpi_default_supported_interfaces[] =3D {
>  	{"Windows 2012", NULL, 0, ACPI_OSI_WIN_8},	/* Windows 8 and Server
> 2012 - Added 08/2012 */
>  	{"Windows 2013", NULL, 0, ACPI_OSI_WIN_8},	/* Windows 8.1 and Server
> 2012 R2 - Added 01/2014 */
>  	{"Windows 2015", NULL, 0, ACPI_OSI_WIN_10},	/* Windows 10 - Added
> 03/2015 */
> +	{"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1},	/* Windows 10
> version 1607 - Added 12/2017 */
> +	{"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2},	/* Windows 10
> version 1703 - Added 12/2017 */
>=20
>  	/* Feature Group Strings */
>=20
> diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> index f914958c4adb..d27bc051f47f 100644
> --- a/include/acpi/actypes.h
> +++ b/include/acpi/actypes.h
> @@ -1284,6 +1284,8 @@ typedef enum {
>  #define ACPI_OSI_WIN_7                  0x0B
>  #define ACPI_OSI_WIN_8                  0x0C
>  #define ACPI_OSI_WIN_10                 0x0D
> +#define ACPI_OSI_WIN_10_RS1             0x0E
> +#define ACPI_OSI_WIN_10_RS2             0x0F
>=20
>  /* Definitions of file IO */
>=20
> --
> 2.14.1

I don't believe that it would be a good idea to bring back this patch to ke=
rnels older
than 4.15.  These strings do activate some extra features in Windows and so=
me BIOS
ASL has been written to only activate them when the newer Windows versions =
are
detected. I have no concerns bringing them to 4.15 though.

Bringing them back to stable may introduce other problems that requires bac=
kporting
additional driver changes too.