Received: by 10.213.65.68 with SMTP id h4csp1154487imn; Mon, 26 Mar 2018 01:40:18 -0700 (PDT) X-Google-Smtp-Source: AG47ELsTIqYtD1YsSkd69gelypE9AsTJLN1e1WTa7VjQ4JWQH34GdKS0yprf4aylCU0mQF1fHabE X-Received: by 2002:a17:902:1e3:: with SMTP id b90-v6mr18311039plb.155.1522053618053; Mon, 26 Mar 2018 01:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522053618; cv=none; d=google.com; s=arc-20160816; b=l6IHTUizTgHd/kzrkP3nxSfmnNQMbqsL2DBAcbEGnh2LJyaUhtxG1qqrqvnwvECOjs mGbDMO4VeZF1SH8KWf9vOIdmDVRRJS0ec6RW8MasnwTvTJ9CZvdVE/sqcaprOG3MS39Z LZGCsmBLVZoFHMK7aegHqI0yafYd7zh+qyh198bhzq93NyLD0vVK0BtCria3JlYId8qn W9/CUjkhmmMZJBb16lyf7TfcAhmMovOj60xG3WS5IFsRDC+g7gt571TeAnnxEUFVOTRo gQG1228MNlKYlbbGYxK0chRMaI1m1u2k823KBmuOTfslWC2hgcaGjUFrX5pMbDvppq4X rh4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=jFb2GGbEsPaeBaWB8XMEsYco05tRS0uLPTFQmIs/1uY=; b=G2qypYDgywOprEkm8BPPsxkq4dsofZ8JkBxUyfYtV9KuO0ZdA2kf7P4mGy39u5bmnr bQAKApgcExu87CKowZb9h/qOnx0SowTRS57zgiti47woBnJJyTk+j0hjC/vf2haHtIWp FdFpOD4y/fitk6Muj/PtLVRDnCmWVjZCYbptyy2UhqHi0gYZ05Ztb0Wi6waOA6FfI2Ch T/+HFyerA/o46re6vtDNeI0eKfqH7oGO2hM71c6KdarzWNaDE1VFasbmfvwjld2mz0AE B6jMGzhz4PD1+EJTuqFstXZ1QqnWkAUwTuBzy16MdzM4Y1+bQjtx7Ar/CXJrr/7DewVc F1kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=hrNjJrB8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b17si9607173pgu.407.2018.03.26.01.40.02; Mon, 26 Mar 2018 01:40:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=hrNjJrB8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751873AbeCZIiA (ORCPT + 99 others); Mon, 26 Mar 2018 04:38:00 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:56307 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbeCZIh7 (ORCPT ); Mon, 26 Mar 2018 04:37:59 -0400 Received: by mail-wm0-f67.google.com with SMTP id t7so13730954wmh.5 for ; Mon, 26 Mar 2018 01:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jFb2GGbEsPaeBaWB8XMEsYco05tRS0uLPTFQmIs/1uY=; b=hrNjJrB8OqHHcKrrNku/N4FRabkEqiZIg9KDE6ERgh0XZpY+ZNQl9F/Abs1FB57iS1 6UMNA7JBAZiHVzsTUFbj0KxTlKcF0Cjs7z54UBSPLYZUQeyVGKIcIeuukWiRUKf5mmqh GnoTcns03+ev4i9GiCnfBlQA/jW9IsvRmmai0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=jFb2GGbEsPaeBaWB8XMEsYco05tRS0uLPTFQmIs/1uY=; b=A1TBSgTSNm5tU+0J9U9y0OV22YISm6pNDiVyXIzhUyNVES6KHuIXD2OaRKQ+G+keiL DuJXaEVyymzrVh+5SOlBz2Y9TRPro3gkg/jH94C6bjhql5jIDQH0BrqFtBpbECPWsLBx /kcm8EmwHmDKXTbLBxe3ua76KIBtZgPYLy/jUL9htexE3ZfbFfDsfxEWlF6F1YuQvRr2 Kh8iEA1A1PEd7PZrU347QD9xZxuacc+TYvorLeHtqv3iBa+HCEcMSAhLV8uJtmTtBci6 Hb9smamwn/RsMnyS8SJxXJK9ciT4sA063tHeUFObfM19yoBUGkGn+Yrx7mhx2LZuYkbY vlIw== X-Gm-Message-State: AElRT7HRjCjP1khimjx5bV5yMuYEhdJpmc+jUBCVX5i49fkYj3qJoiXD 1IewmJ/xAKaTW5B3Hc5wvfhSDgN+ X-Received: by 10.80.148.229 with SMTP id t34mr39786869eda.146.1522053478476; Mon, 26 Mar 2018 01:37:58 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id d89sm9677545edc.75.2018.03.26.01.37.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Mar 2018 01:37:57 -0700 (PDT) Date: Mon, 26 Mar 2018 10:37:55 +0200 From: Daniel Vetter To: Arushi Singhal Cc: linux-kernel@vger.kernel.org, airlied@linux.ie, gustavo@padovan.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, bskeggs@redhat.com, nouveau@lists.freedesktop.org, daniel.vetter@intel.com Subject: Re: [Nouveau] [PATCH v2 1/2] gpu: drm/lease:: Use list_{next/prev}_entry instead of list_entry Message-ID: <20180326083755.GT14155@phenom.ffwll.local> Mail-Followup-To: Arushi Singhal , linux-kernel@vger.kernel.org, airlied@linux.ie, gustavo@padovan.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, bskeggs@redhat.com, nouveau@lists.freedesktop.org, daniel.vetter@intel.com References: <1522000893-5331-1-git-send-email-arushisinghal19971997@gmail.com> <1522000893-5331-2-git-send-email-arushisinghal19971997@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522000893-5331-2-git-send-email-arushisinghal19971997@gmail.com> X-Operating-System: Linux phenom 4.15.0-1-amd64 User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 25, 2018 at 11:31:32PM +0530, Arushi Singhal wrote: > It's better to use list_entry instead of list_{next/prev}_entry > as it makes the code more clear to read. > This patch replace list_entry with list_{next/prev}_entry. > > Signed-off-by: Arushi Singhal Applied to drm-misc-next, thanks for your patch. I'll leave the other one to nouveau folks. -Daniel > --- > drivers/gpu/drm/drm_lease.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c > index 1402c0e..4dcfb5f 100644 > --- a/drivers/gpu/drm/drm_lease.c > +++ b/drivers/gpu/drm/drm_lease.c > @@ -340,7 +340,7 @@ static void _drm_lease_revoke(struct drm_master *top) > break; > > /* Over */ > - master = list_entry(master->lessee_list.next, struct drm_master, lessee_list); > + master = list_next_entry(master, lessee_list); > } > } > } > -- > 2.7.4 > > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch