Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 26 Mar 2018 06:43:53 -0300
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Nasser Afshin <afshin.nasser@gmail.com>
Cc:     p.zabel@pengutronix.de, sakari.ailus@linux.intel.com,
        hans.verkuil@cisco.com, bparrot@ti.com, garsilva@embeddedor.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability
 on some hardware
Message-ID: <20180326064353.187f752c@vento.lan>
In-Reply-To: <20180325225633.5899-1-Afshin.Nasser@gmail.com>
References: <20180325225633.5899-1-Afshin.Nasser@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Nasser,

Em Mon, 26 Mar 2018 03:26:33 +0430
Nasser Afshin <afshin.nasser@gmail.com> escreveu:

> According to the datasheet, INTREQ/GPCL/VBLK should have a pull-up/down
> resistor if it's been disabled. On hardware that does not have such
> resistor, we should use the default output enable value.
> This prevents the color burst lock instability problem.

If this is hardware-dependent, you should instead store it at
OF (for SoC) or pass via platform_data (for PCI/USB devices).

> 
> Signed-off-by: Nasser Afshin <Afshin.Nasser@gmail.com>
> ---
>  drivers/media/i2c/tvp5150.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> index 2476d812f669..0e9713814816 100644
> --- a/drivers/media/i2c/tvp5150.c
> +++ b/drivers/media/i2c/tvp5150.c
> @@ -328,7 +328,7 @@ static const struct i2c_reg_value tvp5150_init_default[] = {
>  		TVP5150_OP_MODE_CTL,0x00
>  	},
>  	{ /* 0x03 */
> -		TVP5150_MISC_CTL,0x01
> +		TVP5150_MISC_CTL,0x21
>  	},
>  	{ /* 0x06 */
>  		TVP5150_COLOR_KIL_THSH_CTL,0x10
> @@ -1072,7 +1072,8 @@ static int tvp5150_s_stream(struct v4l2_subdev *sd, int enable)
>  		 * Enable the YCbCr and clock outputs. In discrete sync mode
>  		 * (non-BT.656) additionally enable the the sync outputs.
>  		 */
> -		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE;
> +		val |= TVP5150_MISC_CTL_YCBCR_OE | TVP5150_MISC_CTL_CLOCK_OE |
> +			TVP5150_MISC_CTL_INTREQ_OE;
>  		if (decoder->mbus_type == V4L2_MBUS_PARALLEL)
>  			val |= TVP5150_MISC_CTL_SYNC_OE;
>  	}


Thanks,
Mauro