Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Ben Skeggs <bskeggs@redhat.com>,
        "Arushi Singhal" <arushisinghal19971997@gmail.com>
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <CABDvA=nFq6nPMyhB3C87XxVkxXwy23NQVES2Na_TVB6VreKrrQ@mail.gmail.com>
Cc:     "David Airlie" <airlied@linux.ie>, linux-kernel@vger.kernel.org,
        "dri-devel" <dri-devel@lists.freedesktop.org>,
        "nouveau" <nouveau@lists.freedesktop.org>, daniel.vetter@intel.com
References: <1522000893-5331-1-git-send-email-arushisinghal19971997@gmail.com>
 <1522000893-5331-3-git-send-email-arushisinghal19971997@gmail.com>
 <CABDvA=nFq6nPMyhB3C87XxVkxXwy23NQVES2Na_TVB6VreKrrQ@mail.gmail.com>
Message-ID: <152206821005.4115.12768359647232399397@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [PATCH v2 2/2] gpu: drm: nouveau: Use list_{next/prev}_entry instead of
 list_entry
Date:   Mon, 26 Mar 2018 13:43:30 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Ben Skeggs (2018-03-26 13:34:54)
> On Mon, Mar 26, 2018 at 4:01 AM, Arushi Singhal
> <arushisinghal19971997@gmail.com> wrote:
> > It's better to use list_entry instead of list_{next/prev}_entry
> > as it makes the code more clear to read.
> > This patch replace list_entry with list_{next/prev}_entry.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> Acked-by: Ben Skeggs <bskeggs@redhat.com>
> 
> > ---
> >  drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c
> > index e4c8d31..81c3567 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c
> > @@ -134,7 +134,7 @@ nvkm_cstate_find_best(struct nvkm_clk *clk, struct nvkm_pstate *pstate,
> >                                nvkm_volt_map(volt, volt->max2_id, clk->temp));
> >
> >         for (cstate = start; &cstate->head != &pstate->list;
> > -            cstate = list_entry(cstate->head.prev, typeof(*cstate), head)) {
> > +            cstate = list_prev_entry(cstate, head)) {

This loop could be written as:

	cstate = start; /* cstate looks redundant here, just use start? */
	list_for_each_entry_from_reverse(cstate, &pstate->list, head)

> >                 if (nvkm_cstate_valid(clk, cstate, max_volt, clk->temp))
> >                         break;
> >         }
> > --
> > 2.7.4