Received: by 10.213.65.68 with SMTP id h4csp1443758imn; Mon, 26 Mar 2018 07:39:06 -0700 (PDT) X-Google-Smtp-Source: AG47ELvWtRHKw7Bkyn1W2sg5vCCJsKeRmwzTeLus+p3MwJIqNUWgFPQOyqb/Z6ZY3f2gIEJN0alo X-Received: by 10.101.102.69 with SMTP id z5mr10073823pgv.438.1522075146381; Mon, 26 Mar 2018 07:39:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522075146; cv=none; d=google.com; s=arc-20160816; b=K2fGTjN334zQt+uNyqeLiSXhOxv6QqYnuwTM2qX/odsoa+6KyMxJcAbcV72egIJaU/ rLnh9wjegbQVxEXO2qCDqrvQBXPAuqpmBCV3W+cHBlyvXXDSma5lwX9KDl6CzQ+9tmRY u9fdObfNdBztUWQrT3npwjSwn0p6HPExkCqdGd5czMw/UY7Yjl7KJsyo6yzO+sIpgU3V DfF+W1CWIUVyWsQxhFJYbUC4OoVG8RTGcrsl968EHUMp67/Qjm6QPu2eIIe/PewHione pN0xJwlY3v/OHIZmY4bY4ogygov7QZk0Qj57YUgUacTbjHxm82bebyBXfhyOICOLEI3i C+ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:arc-authentication-results; bh=MeKaufNEO/BlWSiqekSdvC2x9XEQbkisZuoq1RYdPNs=; b=Cp2juhh9KPE1vI6SfpvmjE4SoGT1VgBSJBb904U83WGlH/6OAIEOR6GZEBNjJjVmPb 9R7rrV+V7lA9tR9FgLk3cqMZWHDCIqvzBK9TtgsO4UoV7rKVut+LIuZvmfmXvqUyUYMM TD5226mqq/SGY/tKlo2Cw1kD1d5PAukM/dLB2rmveskqMOf2n4sJktStNG097D7Sc3xc n9p3wjC+6eSH5+fbjkrSzekATw0CbflPSxBiFWqCX2YjfH2WKQO1Ux/bjPM0rp/1I83W V1jDx9TV7hQOc+nrX6l4Akd+np+UUBS41z2G7SB/0KMRljZlMShW50m+Agh7lC4NnIDA 6kBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1-v6si14869632ple.654.2018.03.26.07.38.51; Mon, 26 Mar 2018 07:39:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbeCZOht (ORCPT + 99 others); Mon, 26 Mar 2018 10:37:49 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:6704 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbeCZOhs (ORCPT ); Mon, 26 Mar 2018 10:37:48 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8329FA065DA17; Mon, 26 Mar 2018 22:37:31 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.361.1; Mon, 26 Mar 2018 22:37:26 +0800 From: Wei Yongjun To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Rob Herring , Markus Elfring , "Tyrel Datwyler" CC: Wei Yongjun , , , Subject: [PATCH -next] powerpc: Fix error return code in ppc4xx_msi_probe() Date: Mon, 26 Mar 2018 14:43:09 +0000 Message-ID: <1522075389-23511-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- arch/powerpc/platforms/4xx/msi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/4xx/msi.c b/arch/powerpc/platforms/4xx/msi.c index 4b859c8..0b71c52 100644 --- a/arch/powerpc/platforms/4xx/msi.c +++ b/arch/powerpc/platforms/4xx/msi.c @@ -241,7 +241,8 @@ static int ppc4xx_msi_probe(struct platform_device *dev) if (!msi_irqs) return -ENODEV; - if (ppc4xx_setup_pcieh_hw(dev, res, msi)) + err = ppc4xx_setup_pcieh_hw(dev, res, msi) + if (err) goto error_out; err = ppc4xx_msi_init_allocator(dev, msi);