Received: by 10.213.65.68 with SMTP id h4csp1495451imn; Mon, 26 Mar 2018 08:36:58 -0700 (PDT) X-Google-Smtp-Source: AG47ELsBsVxyjgk+6XJtGg7RCF0V/yDn0q41xLSv8cS/g1TnJfj/vqGOWQY6UoqsY7IajZnfwH1z X-Received: by 10.99.120.198 with SMTP id t189mr29565087pgc.0.1522078618858; Mon, 26 Mar 2018 08:36:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522078618; cv=none; d=google.com; s=arc-20160816; b=seZ034mjXaXoapdPxlnm1Fj/u5DEFjg8+O1oS380LzZ5S57tUkf+vr9lYHLRq3Jspm YzN2F3Et9EglDov3wElEGwHWAA97988G21TGuwcdvV7v3NwThAS6afSFBmvUDNzR8+Oh 9oSyOet2JvSlIzHsG9QBqTuJBUHk4p7oly7djQqD8mJmYMRd5YDD4hmKXKmXSd1phw9k WV0sHZL/H7faTPM9IXGt9rB3GxLw2Smon4Kzug1b6qyB1k/h2HjnPoe5TybYkNZ9rn36 OGNXksXorJL4igR7eZJu3O96mVSxUigQFLg2uah9bBqASQ0VmYXQPIDrM5GMgCAfttxK Cgiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=pOkwGLHvaZRr7wY4gc/vZj5eIOzqhfpVoEPLLlozlgc=; b=PHSqb5zLclJpNt2ji57RCbUyQupp3iDHmtPlgaRzw20sn3wXsQiYBJOgaeK42ZyowK SGel7KzUbzI3v0J8N+mepLTmo7PPc395uyVfGKBOq9yAzX13z1yCKPi2H2SsdirU3ryV qhrUFwQUO3yLIoqEYyMDwRk7hVkb/cL5EBinZWUmD4iwy2m8Zh8A3K+spVy4gAgHn5cl QyPGo1wXWAdUjszoPgFxCwNtw5jwhZ3gpEUSq2H+cdsL26mBXhREElDsUqAVSQPzs8QJ TTk7Fo8rEdogSyqS7RqMXeWWIvf6CFRLO1rMzckEMBDKqPDwT7nSOQZPgREjyVWyjAFA qmaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6YB2ADS; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6YB2ADS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si5595304pgv.150.2018.03.26.08.36.42; Mon, 26 Mar 2018 08:36:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6YB2ADS; dkim=pass header.i=@codeaurora.org header.s=default header.b=e6YB2ADS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbeCZPfZ (ORCPT + 99 others); Mon, 26 Mar 2018 11:35:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52622 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbeCZPfW (ORCPT ); Mon, 26 Mar 2018 11:35:22 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 66FC560590; Mon, 26 Mar 2018 15:35:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522078521; bh=TrqfS1n0/slCOQz3quv63Hycmb6D493HJpWNoH9qWUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e6YB2ADSkDXVTO2OvfoHtTRbr6HiYNoIbNJ+7r4pSTE7xeU/mrSOQVoD/5j3yJ9VU xJs3DX+BZbqVjNiJQQOjOlv2sDA1Zt9/pWrtvYn2WAxMxpTLpKQtT8kmdQMXEUE14s /40n6MErZMfa/ee5S0IPFjoDU030ylzwJ2x7ojHA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C080460131; Mon, 26 Mar 2018 15:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522078521; bh=TrqfS1n0/slCOQz3quv63Hycmb6D493HJpWNoH9qWUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e6YB2ADSkDXVTO2OvfoHtTRbr6HiYNoIbNJ+7r4pSTE7xeU/mrSOQVoD/5j3yJ9VU xJs3DX+BZbqVjNiJQQOjOlv2sDA1Zt9/pWrtvYn2WAxMxpTLpKQtT8kmdQMXEUE14s /40n6MErZMfa/ee5S0IPFjoDU030ylzwJ2x7ojHA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C080460131 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Mon, 26 Mar 2018 09:35:20 -0600 From: Lina Iyer To: David Collins Cc: Stephen Boyd , broonie@kernel.org, lgirdwood@gmail.com, mark.rutland@arm.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rnayak@codeaurora.org Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180326153520.GC22084@codeaurora.org> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <152165924074.91116.13025068669916027026@swboyd.mtv.corp.google.com> <493c1f5d-df99-ca68-0f90-a7937a696f5d@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <493c1f5d-df99-ca68-0f90-a7937a696f5d@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 22 2018 at 19:30 -0600, David Collins wrote: >Hello Stephen, > >Thank you for the very detailed review feedback. > >On 03/21/2018 12:07 PM, Stephen Boyd wrote: >> Quoting David Collins (2018-03-16 18:09:10) >>> +static int rpmh_regulator_remove(struct platform_device *pdev) >>> +{ >>> + struct rpmh_pmic *pmic = platform_get_drvdata(pdev); >>> + >>> + rpmh_release(pmic->rpmh_client); >> >> I'm still lost on what rpmh_client is giving us besides more code we >> don't need. I'll ping the rpmh thread again. > >Let's see if Lina is willing to add some devm_* calls so that no cleanup >is required. > I will look into this. -- Lina