Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] Ktest: use dodie for critical falures
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     linux-kernel@vger.kernel.org, dhaval.giani@oracle.com
References: <1513380011-15274-1-git-send-email-tianyang.chen@oracle.com>
 <1513380011-15274-3-git-send-email-tianyang.chen@oracle.com>
 <20180321111608.31c712a2@gandalf.local.home>
From:   Tim Tianyang Chen <tianyang.chen@oracle.com>
Organization: Oracle Corporation
Message-ID: <e8b6101e-1358-21b4-8cf1-87d7908bc952@oracle.com>
Date:   Mon, 26 Mar 2018 11:48:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180321111608.31c712a2@gandalf.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the review Steve! One quick comment inline:

On 03/21/2018 08:16 AM, Steven Rostedt wrote:
> On Fri, 15 Dec 2017 15:20:10 -0800
> Tim Tianyang Chen <tianyang.chen@oracle.com> wrote:
>
>> Users should get emails when the script dies because of a critical failure. Critical
>> failures are defined as any errors that could abnormally terminate the script.
>>
>> In order to add email support, this patch converts all die() to dodie() except:
>>   * when '-v' is used as an option to get the version of the script.
>>   * in Sig-Int handeler because it's not a fatal error to cancel the script.
>>   * errors happen during parsing config
> I would say you don't need it for parsing the config either. It doesn't
> make sense, as you wouldn't have the mailto defined yet.
>
Maybe it's the way I worded it. This patch coverts all die() to dodie() 
_except_ these situations. So it doesn't send emails on config errors, 
which is what you said here.
>> @@ -4132,7 +4132,7 @@ if ($#ARGV == 0) {
>>   if (! -f $ktest_config) {
>>       $newconfig = 1;
>>       get_test_case;
>> -    open(OUT, ">$ktest_config") or die "Can not create $ktest_config";
>> +    open(OUT, ">$ktest_config") or dodie "Can not create $ktest_config";
> Here, no config was specified, and so no configs either.
>
>
>>       print OUT << "EOF"
>>   # Generated by ktest.pl
>>   #
>> @@ -4167,7 +4167,7 @@ if (defined($opt{"LOG_FILE"})) {
>>   my @new_configs = keys %entered_configs;
>>   if ($#new_configs >= 0) {
>>       print "\nAppending entered in configs to $ktest_config\n";
>> -    open(OUT, ">>$ktest_config") or die "Can not append to $ktest_config";
>> +    open(OUT, ">>$ktest_config") or dodie "Can not append to $ktest_config";
> Here too.
Right, I missed these two. I will send out v3 shortly.

Tim