Received: by 10.213.65.68 with SMTP id h4csp1687934imn; Mon, 26 Mar 2018 12:33:34 -0700 (PDT) X-Google-Smtp-Source: AG47ELttAPzDJ6lLvEJY3//fSvZ4XWTWVycibEJzSx94Xj8O/j0vKTYBx66PZn3eK70WSIIqSsAy X-Received: by 10.99.60.79 with SMTP id i15mr28829501pgn.399.1522092814632; Mon, 26 Mar 2018 12:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522092814; cv=none; d=google.com; s=arc-20160816; b=ZbVSVEhK+3JzAqljIWdHNSqsAr7tHcJcCOgugc89TOrx/1EIQqWMsAW0Sq+L+sOAQq gdLyZy2UJEBxrciJg8X76RDGFfkmnI2KbFSCcMFYCL5iSSTv97Qt1oUU2Yvw7n00/1ln Xd8qbQW3oGUpwpaN2PoZwOxNsQeHRecJfDDdiY5aJm+YjSHAXWCPt3Ml1dZSFjTOwWph F5WIy0VoJMY/38cykMSbdfqUsg1LPo1tKx81eKXf0rKthlBVr/TbEpGnl9cCOfs72OmA z5yYrd4b6h+crniNypaR3sIC+Eiq7RDTdiWeJCTN9ycrLVV7ol6Xprei2FPtW4In/XSL 2aZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=s4osEyXTL1tI0k8rCdJpfbdmUnF434lI+T65X8wyWsA=; b=0sAxalD6BI6Dz4vh8kUFXmeEhuW/8kgf0CLABmykmKo4poEKIs1HCTTgmfYTgoy6Cl qRiR/P4VXvUQbXRculzuloZn7P7vli2u6s8SQkPoTjxKlYUMn5Rn/11kEEBcCf7cRb0x lAqwVwsfkmcWJZDRIPMDEKDhurmffaMolyj2cpKU6tstN7n1q1+4WLl8xFDZio5fDYxY NtPctvxQKuJR0Fb0AHspfZpH7PtWOCCQGzoIHyW3XBrGy+cTVrkAeKs5ukZNuOOLAPJ0 ofPTwaNX5SU56lPu7whmLJHDj0eKAV1p4mH6ngXHAIMFC5aFaP6m1PkT+ZWtk6dKP5dL TFBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16si12279164pfd.6.2018.03.26.12.33.07; Mon, 26 Mar 2018 12:33:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbeCZTbr (ORCPT + 99 others); Mon, 26 Mar 2018 15:31:47 -0400 Received: from mail.skyhub.de ([5.9.137.197]:36766 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbeCZTbq (ORCPT ); Mon, 26 Mar 2018 15:31:46 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fnPnAOhC5dSr; Mon, 26 Mar 2018 21:31:29 +0200 (CEST) Received: from pd.tnic (p200300EC2BC88600791E0C6965666DA9.dip0.t-ipconnect.de [IPv6:2003:ec:2bc8:8600:791e:c69:6566:6da9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E20D11EC0281; Mon, 26 Mar 2018 21:31:28 +0200 (CEST) Date: Mon, 26 Mar 2018 21:30:52 +0200 From: Borislav Petkov To: Yazen Ghannam Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org Subject: Re: [PATCH 1/2] Revert "x86/mce/AMD: Collect error info even if valid bits are not set" Message-ID: <20180326193052.GJ25548@pd.tnic> References: <20180326191526.64314-1-Yazen.Ghannam@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180326191526.64314-1-Yazen.Ghannam@amd.com> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 02:15:25PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > This reverts commit 4b1e84276a6172980c5bf39aa091ba13e90d6dad. > > Software uses the valid bits to decide if the values can be used for > further processing or other actions. So setting the valid bits will have > software act on values that it shouldn't be acting on. > > The recommendation to save all the register values does not mean that > the values are always valid. So what does that "Error handlers should save the values in MCA_ADDR, MCA_MISC0, and MCA_SYND even if MCA_STATUS[AddrV], MCA_STATUS[MiscV], and MCA_STATUS[SyndV] are zero." *actually* mean then? It is still in the PPR. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.