Received: by 10.213.65.68 with SMTP id h4csp32605imn; Mon, 26 Mar 2018 14:24:55 -0700 (PDT) X-Google-Smtp-Source: AG47ELtCaYzD5isRANK1MLDXRbrLOCGXX9427SO1Fr6VCFufqw4ARqYi8RfkvQDxK8NSXVs0wqv5 X-Received: by 10.98.36.68 with SMTP id r65mr12331238pfj.193.1522099495472; Mon, 26 Mar 2018 14:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522099495; cv=none; d=google.com; s=arc-20160816; b=ZPb+q1yje4a/Q93WdESw3L3NM3CuGEB9K3gRt3NPhCFRiDY3fmLPL7u+rt3ieG8lmB TBZn0tcIyZ9aoYM+1oqGqtlnALBgnfK8UXBmOk+pxcmBxE+QeHZ2pCgf5apwYr8JIgqr qHuIodmJDw6XdeDZhhrmwSSHYzq1n7SnNIwm+aO29GTHNRIaCFkfuf1qmxxAsO7JNwRz uVhVNWJn1I0cL80xRiOoeucDuz6oO5m3dXjrmmK1ELJtVRyX9oP+B6dKOykmFCZlncWh QDVvJnHxl415OrTq76vU0nlovVlyD/hmCK15iFhe/DHDaKlTGfKcr1M3OvvnSmnL4TRy DciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=POpIhiO0ahdZSa1G/wDcBaKCri0vsBbDt3PZsDnRSdI=; b=rHWfLe5oNgTuCiQwt08Pfk2Q1rCYLZLVDxbvZCSfbl+aqPfiNqaj+gL16He3q+gPkf m8sfKQ4O+ZyVFZEM5qfYlUdIoSnSJmQhO6d0sHHrE6w0tc4E+mk7Ae4sBPkV9Qdv1uxv +fKj/hqA1Cd5KOp8ZIOD1lzkSyyipGSUv3X4dEDxiRHnQRLYAAbUvablA+pO6RnMk0Xe VXieTNX5F45DpMikLN9LLlM9veqZX4FuAgJ7lC53/NG0HDk2T4DGHnLzGNN51tsAOreb FcJLgUn5t7xvDcgy+p2+96mNu0QKX9JkSUdatHCjfBMrmDBbSAgEB3ReGlMxb2A7cUXJ iRLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12-v6si15963520plk.615.2018.03.26.14.24.36; Mon, 26 Mar 2018 14:24:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbeCZVWO (ORCPT + 99 others); Mon, 26 Mar 2018 17:22:14 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:44260 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752238AbeCZVWL (ORCPT ); Mon, 26 Mar 2018 17:22:11 -0400 Received: from linux-n805.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Mon, 26 Mar 2018 15:22:07 -0600 From: Davidlohr Bueso To: peterz@infradead.org, mingo@kernel.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso , "David S . Miller" , netdev@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 6/6] net/sock: Update memalloc_socks static key to modern api Date: Mon, 26 Mar 2018 14:09:29 -0700 Message-Id: <20180326210929.5244-7-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180326210929.5244-1-dave@stgolabs.net> References: <20180326210929.5244-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to memalloc_socks, for better self documentation. Cc: David S. Miller Cc: netdev@vger.kernel.org Signed-off-by: Davidlohr Bueso --- include/net/sock.h | 4 ++-- net/core/sock.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/net/sock.h b/include/net/sock.h index 8c428c6847af..15d676365743 100644 --- a/include/net/sock.h +++ b/include/net/sock.h @@ -803,10 +803,10 @@ static inline bool sock_flag(const struct sock *sk, enum sock_flags flag) } #ifdef CONFIG_NET -extern struct static_key memalloc_socks; +DECLARE_STATIC_KEY_FALSE(memalloc_socks_key); static inline int sk_memalloc_socks(void) { - return static_key_false(&memalloc_socks); + return static_branch_unlikely(&memalloc_socks_key); } #else diff --git a/net/core/sock.c b/net/core/sock.c index e689496dfd8a..670f35803411 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -323,8 +323,8 @@ EXPORT_SYMBOL(sysctl_optmem_max); int sysctl_tstamp_allow_data __read_mostly = 1; -struct static_key memalloc_socks = STATIC_KEY_INIT_FALSE; -EXPORT_SYMBOL_GPL(memalloc_socks); +DEFINE_STATIC_KEY_FALSE(memalloc_socks_key); +EXPORT_SYMBOL_GPL(memalloc_socks_key); /** * sk_set_memalloc - sets %SOCK_MEMALLOC @@ -338,7 +338,7 @@ void sk_set_memalloc(struct sock *sk) { sock_set_flag(sk, SOCK_MEMALLOC); sk->sk_allocation |= __GFP_MEMALLOC; - static_key_slow_inc(&memalloc_socks); + static_branch_inc(&memalloc_socks_key); } EXPORT_SYMBOL_GPL(sk_set_memalloc); @@ -346,7 +346,7 @@ void sk_clear_memalloc(struct sock *sk) { sock_reset_flag(sk, SOCK_MEMALLOC); sk->sk_allocation &= ~__GFP_MEMALLOC; - static_key_slow_dec(&memalloc_socks); + static_branch_dec(&memalloc_socks_key); /* * SOCK_MEMALLOC is allowed to ignore rmem limits to ensure forward -- 2.13.6