Received: by 10.213.65.68 with SMTP id h4csp33029imn; Mon, 26 Mar 2018 14:25:41 -0700 (PDT) X-Google-Smtp-Source: AG47ELuNuQSYQXmBtv+QaNyYBFG9pzRzstCqnzsfLHT3qSiSELQPPwZax4Dd3l7VRcjmXoU/0VOg X-Received: by 10.98.205.69 with SMTP id o66mr26146917pfg.34.1522099541842; Mon, 26 Mar 2018 14:25:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522099541; cv=none; d=google.com; s=arc-20160816; b=JSvvLcBw9tvkWKaL0oK+WDSAWxpuuYPvOhrNKUDQdH5zvkFFSo01HG3nLgHOzjsb/f vZP8k05oGZOsr+qh2JkewS6ApP9GDQWbvutsS226d4ZSKamrX1Murh6DHNd+SKyI0R9P gOdPbjD4C014bPdT3XwiZyaGgOG1lnhvcz8dShyEsfvW88+JZc8hwCIiewUrBXmnNuSb 4MyNZq7p7Mdu3QaiTu81tMnjCSMKjlgQrYH0u7sPLcWYgPe25rUu7h3u/8vNc4U9NRPW I3CTyBYN6+5EBpEX0JT1jKZEUhnQXXs+GtkUblYOq71SKNSVexz876i2DeAWuQ3A3PYn x/BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=KNt+47CnUnh94yGqzARpAbcGAju6GC/uyI4xTeUh91M=; b=rmG7rX5zu8PUMJh2Hz/M6ZHhpqRpAoiEu9RWKq1CK7xhY+jY3kPPfxKKtE7/OI8wDz 1mKe+J5pSqGoGupS6x2aBWdZ+saOIUbshegoVOfyPlEd588CbwA3ap/IcGQh57Q61iXl rkpjBFnisfzcO56Z7xSkyyaWsDYsj4YEniawvF3BQIStLgVvY48nHbNcZFXDUGc01zQ3 cXcqoLDNAiW+hI1XpdzxHRGoMWzSJU2BfMoyCZlOiRexJiqzGhSL16bGbSLaMXYEQqNX hpggner8HbzhChuh3LzEQ3W8zK/JscDULUk75GYSNygIcbGFmiTr6dC/gbAl7tiskzXP M1sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si12141704pfa.94.2018.03.26.14.25.27; Mon, 26 Mar 2018 14:25:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbeCZVXz (ORCPT + 99 others); Mon, 26 Mar 2018 17:23:55 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:38852 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752221AbeCZVWJ (ORCPT ); Mon, 26 Mar 2018 17:22:09 -0400 Received: from linux-n805.suse.de (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Mon, 26 Mar 2018 15:22:05 -0600 From: Davidlohr Bueso To: peterz@infradead.org, mingo@kernel.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso , "David S . Miller" , netdev@vger.kernel.org, Davidlohr Bueso Subject: [PATCH 5/6] net/ipv4: Update ip_tunnel_metadata_cnt static key to modern api Date: Mon, 26 Mar 2018 14:09:28 -0700 Message-Id: <20180326210929.5244-6-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180326210929.5244-1-dave@stgolabs.net> References: <20180326210929.5244-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No changes in refcount semantics -- key init is false; replace static_key_slow_inc|dec with static_branch_inc|dec static_key_false with static_branch_unlikely Added a '_key' suffix to i2c_trace_msg, for better self documentation. Cc: David S. Miller Cc: netdev@vger.kernel.org Signed-off-by: Davidlohr Bueso --- include/net/ip_tunnels.h | 4 ++-- net/ipv4/ip_tunnel_core.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h index 540a4b4417bf..fc494b48a64a 100644 --- a/include/net/ip_tunnels.h +++ b/include/net/ip_tunnels.h @@ -466,12 +466,12 @@ static inline struct ip_tunnel_info *lwt_tun_info(struct lwtunnel_state *lwtstat return (struct ip_tunnel_info *)lwtstate->data; } -extern struct static_key ip_tunnel_metadata_cnt; +DECLARE_STATIC_KEY_FALSE(ip_tunnel_metadata_cnt); /* Returns > 0 if metadata should be collected */ static inline int ip_tunnel_collect_metadata(void) { - return static_key_false(&ip_tunnel_metadata_cnt); + return static_branch_unlikely(&ip_tunnel_metadata_cnt); } void __init ip_tunnel_core_init(void); diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index 2f39479be92f..dde671e97829 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -423,17 +423,17 @@ void __init ip_tunnel_core_init(void) lwtunnel_encap_add_ops(&ip6_tun_lwt_ops, LWTUNNEL_ENCAP_IP6); } -struct static_key ip_tunnel_metadata_cnt = STATIC_KEY_INIT_FALSE; +DEFINE_STATIC_KEY_FALSE(ip_tunnel_metadata_cnt); EXPORT_SYMBOL(ip_tunnel_metadata_cnt); void ip_tunnel_need_metadata(void) { - static_key_slow_inc(&ip_tunnel_metadata_cnt); + static_branch_inc(&ip_tunnel_metadata_cnt); } EXPORT_SYMBOL_GPL(ip_tunnel_need_metadata); void ip_tunnel_unneed_metadata(void) { - static_key_slow_dec(&ip_tunnel_metadata_cnt); + static_branch_dec(&ip_tunnel_metadata_cnt); } EXPORT_SYMBOL_GPL(ip_tunnel_unneed_metadata); -- 2.13.6