Received: by 10.213.65.68 with SMTP id h4csp80080imn; Mon, 26 Mar 2018 15:37:59 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+955Bfb+8ZSbEG++2x3geYuKizUAGgsJA6KOQuOnH/mINDty2bp0FcAvt2VrZI5y3+Rwkn X-Received: by 2002:a17:902:8689:: with SMTP id g9-v6mr2882676plo.247.1522103879760; Mon, 26 Mar 2018 15:37:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522103879; cv=none; d=google.com; s=arc-20160816; b=LGumQ0UEdsmBbdIzVFHm2cCWavmHpg/BVB5hm1VE19XqZ2cymo67txINFGPtDfvgfr IVWAePvHZL1xXibbErrSKrp78j6ZSmKvADwemZAmzs4C0NHoHXJJSV2AYwqee3o2YqKb IAGFfsRk3SUDqwokKxRwlk8BCvAehFpJvYMizH9sUKvPlHSxI6Ti8dq8A8qW6E0f9wWp jV5kw/MeSf07nuziUQpcOnd4jy7cGKMuBtdYDdc3jrdAXgPIp2YCrHKBxLqQrRYvk4gL 5yUCiKwHi/04qkFHWOoeLHiiEjb2/5c/q2dMg5aEDUrUkD3vhiZWHwGEvKFItojibLON /RXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=6enfEtQzbrawq3jcktRRnZWFWy4NLWVdOBXvBcQKUQc=; b=mv/UaQ5aG8AwrGjZRjdydTiVSg7Xd5CJJEl93dMQaP15xl4e8GcUyctYuy8fBSl5Uc 2D+90eCo4i0dMcRmG8YigTq+tSW4+5jDE6XuPTRNphi/3PeTalzlkFNmoPvk4adbX0Xw yjaKFbv5oVkOc5CB+rNwsAORAoi7RzeIuoKxTnZksiN4gtnuNIfxbJpKxe6z5BkBgmsz muxopMLtcACrx+qfavZ8Hk2fT453/t4LVf+aCgsFpCZvX3w8CHSgqWd3waqOaiOsZZhT b/1+PbUF7bzri5svHFR5rey+5b4G95GbxR52MWj8o+Q/moA5iIug7Qotmpjl7NcxDT40 o3NA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1-v6si15499017pln.216.2018.03.26.15.37.45; Mon, 26 Mar 2018 15:37:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbeCZWgv (ORCPT + 99 others); Mon, 26 Mar 2018 18:36:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:54522 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbeCZWgt (ORCPT ); Mon, 26 Mar 2018 18:36:49 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.71]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 080DC12FD; Mon, 26 Mar 2018 22:36:49 +0000 (UTC) Date: Mon, 26 Mar 2018 15:36:48 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: Re: [PATCH v9 00/61] XArray v9 Message-Id: <20180326153648.27f53e9a1398812203745257@linux-foundation.org> In-Reply-To: <20180313132639.17387-1-willy@infradead.org> References: <20180313132639.17387-1-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2018 06:25:38 -0700 Matthew Wilcox wrote: > This patchset is, I believe, appropriate for merging for 4.17. > It contains the XArray implementation, to eventually replace the radix > tree, and converts the page cache to use it. I looked at this from a for-4.17 POV and ran out of nerve at "[PATCH v9 09/61] xarray: Replace exceptional entries". It's awfully late. "[PATCH v9 08/61] page cache: Use xa_lock" looks sufficiently mechanical to be if-it-compiles-it-works, although perhaps that shouldn't be in 4.17 either. Mainly because it commits us to merging the rest of XArray and there hasn't been a ton of review and test activity. It looks like btrfs has changed in -next: --- a/fs/btrfs/inode.c~page-cache-use-xa_lock-fix +++ a/fs/btrfs/inode.c @@ -7445,7 +7445,7 @@ out: bool btrfs_page_exists_in_range(struct inode *inode, loff_t start, loff_t end) { - struct radix_tree_root *root = &inode->i_mapping->page_tree; + struct radix_tree_root *root = &inode->i_mapping->i_pages; bool found = false; void **pagep = NULL; struct page *page = NULL; _