Received: by 10.213.65.68 with SMTP id h4csp189711imn; Mon, 26 Mar 2018 18:53:59 -0700 (PDT) X-Google-Smtp-Source: AG47ELsmYwB9iej4F4i+rTXTTt3KxedH/X5xsGiAF0CBOLtmu1naL/srfvHKWK11bERSP7g+WYyG X-Received: by 2002:a17:902:63:: with SMTP id 90-v6mr43747545pla.125.1522115639620; Mon, 26 Mar 2018 18:53:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522115639; cv=none; d=google.com; s=arc-20160816; b=Ac2N/Fboh4HQ8ayuEKU/O5rKEcbuwZ6i5WKIbO7p/SM3RuohE1HB5fBQ94LnGenEqP HxcXCsWUxeYDlk5qW1SytBCc2PvUWuDKn09+1r8QtVDgAu/htLpnMYW9LLXHSr97Q042 zI8SBV0n4ydfgQzg5Kb+agheaenudXm1ugKMmwhOI/8kB84JH7SuMmXwX630qmczfW2P bV7qd94veO5hzVi9wz/UQGrW6t9WtiBMd5qHRxcfGWuFO4lfvkpO4QwPA+K/1VtS6lme 9uBlXSlIAGBZld/zIPbQqnAQPnPbgd1VffINNE05cHVc7IzDkoviRto2exqwK37i6gBG 6sjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:cc:subject:date:to:from :arc-authentication-results; bh=LC7O3FBt2GBhdVHiAvLP1JiXK4gmKZMfP90bGRA2Wj8=; b=CXh1jVmVqoo5EYNwetGRJsDxyUH3A4+gxF1fIxFDW/5UpUSySb3VIz2BdzuFFTfQKx Kfvgke8WB0UD3OgaGi7TFloFvWxv1I64DbEEZLCh++yjcjdKURFPeI0QE2Og3pLquzHo J9ry3XQlcTKsulj/ghs/fDl5cHlDplVli2pXbjOXl0daZz5nZEyowmDbQPshfj+QTkxv esCOkLtIz1Tba9FwHHN2fsjxgwQrnZ9vkiWe9rA4+X3aITuEb7/EH+iZiO0YseStpEDu 7Vxep0q0BBxLyUgk23VPVKbFrQLdwtBkr6hVGHvq1Qide2SKR9fzT8obQR0Dr7hwT9hf K7lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n128si88174pga.29.2018.03.26.18.53.45; Mon, 26 Mar 2018 18:53:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbeC0BvQ (ORCPT + 99 others); Mon, 26 Mar 2018 21:51:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:38945 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752031AbeC0BvP (ORCPT ); Mon, 26 Mar 2018 21:51:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 88E96AE6C; Tue, 27 Mar 2018 01:51:13 +0000 (UTC) From: NeilBrown To: Thomas Graf , Herbert Xu Date: Tue, 27 Mar 2018 10:33:04 +1100 Subject: [PATCH 0/6] rhashtable: assorted fixes and enhancements Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <152210688405.11435.13010923693146415942.stgit@noble> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I'm hoping to use rhashtable in lustre, to replace the resizeable hashtable implementation in libcfs. While working through the conversion I found some minor bugs in the rhashtable code and documentation, and some areas where enhancements could make rhashtable a better fit for lustre. Following 6 patches are the result. Please review. It would help me if I could get an Ack for these patches, and could then submit them through the drivers/staging tree together with the lustre changes that make use to rhashtable. The first 2 are mostly just fixes to comments and can go in through the netdev tree if you prefer - the last 4 are needed for lustre to work correctly/optimally. Thanks, NeilBrown --- NeilBrown (6): rhashtable: improve documentation for rhashtable_walk_peek() rhashtable: remove outdated comments about grow_decision etc rhashtable: reset iter when rhashtable_walk_start sees new table rhashtable: allow a walk of the hash table without missing objects. rhashtable: support guaranteed successful insertion. rhashtable: allow element counting to be disabled. include/linux/rhashtable.h | 89 ++++++++++++++++++++++++++++---------- lib/rhashtable.c | 102 +++++++++++++++++++++++++++++++------------- 2 files changed, 136 insertions(+), 55 deletions(-) -- Signature