Received: by 10.213.65.68 with SMTP id h4csp189782imn; Mon, 26 Mar 2018 18:54:06 -0700 (PDT) X-Google-Smtp-Source: AG47ELt7UGCJLt1Hg5FJsDvQJtIuvvZUaHvcUbmjSczqy0dr8K+AGzlWG4iR/W2XARlE/qpC+rf5 X-Received: by 10.98.182.4 with SMTP id j4mr11948161pff.207.1522115645948; Mon, 26 Mar 2018 18:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522115645; cv=none; d=google.com; s=arc-20160816; b=rgUSy6QZ7Df0mw7PjJeQ986gPnYHWX6aqOq1bbGoq0S7HHOEXKJ3siqQhIuTHYDUY5 Sof1l1n7Z0G8JfsVTb0WY1XTyleO6WOMcS9Jebh/79ynVvpD89nvfySOqaVu6CxF2DcH uXQjTeJ0nt0ByoT1ufbzCO1MCsL1+zp9xHvIC3qklnng51Dui6DK0dmkxRWXJwT6Igjw ss2u0ro4HEvI2TDjcaqu21sEw1uJJoWr7sK+RQruVB37gZ1bq+gRlHZ6DnLTTrecklHh gqzBi8TM24tHzEos/A8Yn0fq76dI6GiX850uyYgbUrfZmqdmGC8pkzQK5rRAdhsXQbR7 RAlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:cc:subject:date:to :from:arc-authentication-results; bh=Y5se/tIS5iht+tCi9HdPczrXlULdR+iCmpkM5Ch8F4k=; b=JnCUOOwp/WUCt9HvlWf2xHoX17WvGWRsNcsAogoZj4/RkSL3P8PsUjAndwOerqeWXa c6qhQduHdqID14mlxURwzqwmnREibQivRdTSRa9b57GYU/GuiYd+SVLcBWrMCZnCY9Ox 8jP2LFuAKA4/cQ2Ezt5OudxoUqk1XcrmiFbMboVzkYPzwsCpv4geu1Uq4tEa+2ihDzx+ ubmEABZXDoJf41cxK4dfPfPqBWhjcvXw84nKT118vJIKSbyWOGFpDjnO1pYY5baM3txk 6SzjFS9WubULEwCDNNBeeyy3Znoa3PGwGLPhSV2yhXYRHjBYe8iVok10mNxCQbI+h75W DMAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f18-v6si104898plr.726.2018.03.26.18.53.51; Mon, 26 Mar 2018 18:54:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752331AbeC0Bva (ORCPT + 99 others); Mon, 26 Mar 2018 21:51:30 -0400 Received: from mx2.suse.de ([195.135.220.15]:38980 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752289AbeC0Bv1 (ORCPT ); Mon, 26 Mar 2018 21:51:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AAAE6AFF4; Tue, 27 Mar 2018 01:51:25 +0000 (UTC) From: NeilBrown To: Thomas Graf , Herbert Xu Date: Tue, 27 Mar 2018 10:33:04 +1100 Subject: [PATCH 2/6] rhashtable: remove outdated comments about grow_decision etc Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <152210718423.11435.12622499872176836575.stgit@noble> In-Reply-To: <152210688405.11435.13010923693146415942.stgit@noble> References: <152210688405.11435.13010923693146415942.stgit@noble> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org grow_decision and shink_decision no longer exist, so remove the remaining references to them. Signed-off-by: NeilBrown --- include/linux/rhashtable.h | 33 ++++++++++++++------------------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h index c9df2527e0cd..3bd19d29f46b 100644 --- a/include/linux/rhashtable.h +++ b/include/linux/rhashtable.h @@ -834,9 +834,8 @@ static inline void *__rhashtable_insert_fast( * * It is safe to call this function from atomic context. * - * Will trigger an automatic deferred table resizing if the size grows - * beyond the watermark indicated by grow_decision() which can be passed - * to rhashtable_init(). + * Will trigger an automatic deferred table resizing if residency in the + * table grows beyond 70%. */ static inline int rhashtable_insert_fast( struct rhashtable *ht, struct rhash_head *obj, @@ -864,9 +863,8 @@ static inline int rhashtable_insert_fast( * * It is safe to call this function from atomic context. * - * Will trigger an automatic deferred table resizing if the size grows - * beyond the watermark indicated by grow_decision() which can be passed - * to rhashtable_init(). + * Will trigger an automatic deferred table resizing if residency in the + * table grows beyond 70%. */ static inline int rhltable_insert_key( struct rhltable *hlt, const void *key, struct rhlist_head *list, @@ -888,9 +886,8 @@ static inline int rhltable_insert_key( * * It is safe to call this function from atomic context. * - * Will trigger an automatic deferred table resizing if the size grows - * beyond the watermark indicated by grow_decision() which can be passed - * to rhashtable_init(). + * Will trigger an automatic deferred table resizing if residency in the + * table grows beyond 70%. */ static inline int rhltable_insert( struct rhltable *hlt, struct rhlist_head *list, @@ -920,9 +917,8 @@ static inline int rhltable_insert( * * It is safe to call this function from atomic context. * - * Will trigger an automatic deferred table resizing if the size grows - * beyond the watermark indicated by grow_decision() which can be passed - * to rhashtable_init(). + * Will trigger an automatic deferred table resizing if residency in the + * table grows beyond 70%. */ static inline int rhashtable_lookup_insert_fast( struct rhashtable *ht, struct rhash_head *obj, @@ -979,9 +975,8 @@ static inline void *rhashtable_lookup_get_insert_fast( * * Lookups may occur in parallel with hashtable mutations and resizing. * - * Will trigger an automatic deferred table resizing if the size grows - * beyond the watermark indicated by grow_decision() which can be passed - * to rhashtable_init(). + * Will trigger an automatic deferred table resizing if residency in the + * table grows beyond 70%. * * Returns zero on success. */ @@ -1132,8 +1127,8 @@ static inline int __rhashtable_remove_fast( * walk the bucket chain upon removal. The removal operation is thus * considerable slow if the hash table is not correctly sized. * - * Will automatically shrink the table via rhashtable_expand() if the - * shrink_decision function specified at rhashtable_init() returns true. + * Will automatically shrink the table if permitted when residency drops + * below 30%. * * Returns zero on success, -ENOENT if the entry could not be found. */ @@ -1154,8 +1149,8 @@ static inline int rhashtable_remove_fast( * walk the bucket chain upon removal. The removal operation is thus * considerable slow if the hash table is not correctly sized. * - * Will automatically shrink the table via rhashtable_expand() if the - * shrink_decision function specified at rhashtable_init() returns true. + * Will automatically shrink the table if permitted when residency drops + * below 30% * * Returns zero on success, -ENOENT if the entry could not be found. */