Received: by 10.213.65.68 with SMTP id h4csp401016imn; Tue, 27 Mar 2018 01:07:33 -0700 (PDT) X-Google-Smtp-Source: AG47ELvSDnDyKQLs87Ve0SAdQ/Fpl7w16VtcdpENq5jtRrv2WICObWuI9hBjrb6nUfx4Q4XQA1HR X-Received: by 10.99.156.17 with SMTP id f17mr30668430pge.102.1522138053908; Tue, 27 Mar 2018 01:07:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522138053; cv=none; d=google.com; s=arc-20160816; b=qobkg7kp9agm//93FgQ3I1UBkvIkC8d1RY6AVbQP5o+pnnB6EjHV6Ir7x39MUrpT24 N/csKteyEsFy5s830AwrFBUf7Q6T4WnT+mFO6WC52Gn2uZTLXbeyC3gOfzWF8htIKe21 zAZvnNFUvLXb4nxdxudGdLcu3vj8nR4E6SJg8qeXdOWeOlH+fY5d0Bjs+CIa+r4B10R4 YekJAx70wngCnBGy9AzDxU1vlxMhmX6fGssVy0VyccoI5ASDnu9TrIZ6cD7zrA6oH+DT q5VwRw+8geOI7BtCySDtdW6jyg28F2BF106k5g0fQTeH7dmpA/Oi89Oo6XqwCjCdSsRR ZFDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=ziApIQPGObgMrbdOiDgYqAPYtjXAlc7BiRr65vOGABw=; b=ZCY/9rxvk4dYioTKG5xmo3pepy9t4tGJEQONeY4RDgkEay3rJ9431XN+k3THAJvdqq mNB54Y+sUZTTPixlq41uc8TDCJSaQtZ2vVFgOMR7ZwLGC0BT8b4r2q1wrozXBH6YiuBo pd1dyk5FnsOkdgOAoMLpSfp01XXc29tyLoT1Q7XSX8LzcpnjiFNOpG5Q5m7oFmdUXPOA CQSBa5koY1GngEUxCviXt8OaXnb5E1lrPhyjBGQVwYoRNiB2e7uXzhyTV1pX4z2hcMwR ZULBEJLipw7BRcbCk4+rzVMflWElHN2L4ZABgeAHZdjT8ZGUfHh03csiVsjLW3AUBTfF I5Mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si498638pgf.530.2018.03.27.01.07.19; Tue, 27 Mar 2018 01:07:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbeC0IGC (ORCPT + 99 others); Tue, 27 Mar 2018 04:06:02 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:35122 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752183AbeC0IF5 (ORCPT ); Tue, 27 Mar 2018 04:05:57 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from vadimp@mellanox.com) with ESMTPS (AES256-SHA encrypted); 27 Mar 2018 10:06:44 +0200 Received: from r-mgtswh-226.mtr.labs.mlnx. (r-mgtswh-226.mtr.labs.mlnx [10.209.1.51]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w2R85mx2029508; Tue, 27 Mar 2018 11:05:51 +0300 From: Vadim Pasternak To: dvhart@infradead.org, andy.shevchenko@gmail.com, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, jiri@resnulli.us, michaelsh@mellanox.com, ivecera@redhat.com, Vadim Pasternak Subject: [PATCH v1 2/7] platform/mellanox: mlxreg-hotplug: Document fixes for hotplug private data Date: Tue, 27 Mar 2018 10:02:02 +0000 Message-Id: <1522144927-56512-3-git-send-email-vadimp@mellanox.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1522144927-56512-1-git-send-email-vadimp@mellanox.com> References: <1522144927-56512-1-git-send-email-vadimp@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add missing description of dev, regmap, dwork_irq, after_probe in struct mlxreg_hotplug_priv_data. Remove dwork field from the structure mlxreg_hotplug_priv_data itself and for the descriptions, since it is not used. Signed-off-by: Vadim Pasternak --- drivers/platform/mellanox/mlxreg-hotplug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c index ea9e7f4..b56953a 100644 --- a/drivers/platform/mellanox/mlxreg-hotplug.c +++ b/drivers/platform/mellanox/mlxreg-hotplug.c @@ -59,9 +59,11 @@ /** * struct mlxreg_hotplug_priv_data - platform private data: * @irq: platform device interrupt number; + * @dev: basic device; * @pdev: platform device; * @plat: platform data; - * @dwork: delayed work template; + * @regmap: register map handle; + * @dwork_irq: delayed work template; * @lock: spin lock; * @hwmon: hwmon device; * @mlxreg_hotplug_attr: sysfs attributes array; @@ -71,6 +73,7 @@ * @cell: location of top aggregation interrupt register; * @mask: top aggregation interrupt common mask; * @aggr_cache: last value of aggregation register status; + * @after_probe: flag indication probing completion; */ struct mlxreg_hotplug_priv_data { int irq; @@ -79,7 +82,6 @@ struct mlxreg_hotplug_priv_data { struct mlxreg_hotplug_platform_data *plat; struct regmap *regmap; struct delayed_work dwork_irq; - struct delayed_work dwork; spinlock_t lock; /* sync with interrupt */ struct device *hwmon; struct attribute *mlxreg_hotplug_attr[MLXREG_HOTPLUG_ATTRS_MAX + 1]; -- 2.1.4