Received: by 10.213.65.68 with SMTP id h4csp423018imn; Tue, 27 Mar 2018 01:43:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELsdSiFgCvlYoLETup9Jkuet1kVBirM3ryk1w2voytZl/7ePXio+e1rpynUi4O5Hm765oSDV X-Received: by 10.99.100.6 with SMTP id y6mr30632803pgb.254.1522140209693; Tue, 27 Mar 2018 01:43:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522140209; cv=none; d=google.com; s=arc-20160816; b=xzzSqQjIgn48mKp2XEHUka5jun2JybLP/G6atAaKPeyQ5O4BGmxfBcQNnjY7Vb0FiF sZlSFs4vF7K0vAdMQDNEFAVmp24v8Ak24kvUANO5xyCRSycSIgulz1lSem539CuhVYh0 GjyhZR9Uy46dh0YpvDwFsNfOO/LqG8Grw+f8X6AvP9H29g+44jNdPeQy8WKhkpSP+mQN 0JnhJbamx8QGLyxjJrsQ5Gd6BDZHm0R6I6f3QPt6QEqAoZeZsN8HhwVt3jmOTcOs6kqH HCoRyZaFo5itbzw1CvE2CZjUd42mBvo71BEH6Ko/EwWSkn0hP3u9dsm8pM+4JNzRxuTI uPWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:mime-version:organization :user-agent:references:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=N6HqzrCQkjIinfDDuZDiVsVs0o/r7tXWYQxtJ1PUn2o=; b=uUWDG4B+l6A7ZU1GhC+fOGBHsElO7LBQ07zlUN1wiQANnxCsICoaPBrK1wqbiHg4O+ LneKkF7qnHD7BXpZB6N9ZNxJbJFbUWiq8nUHUbHDAruQUmoSxCpg453hKqim5g/iFl7r ibFlfDay3zjPSHojd9QDvleoNkAiFIzTlvyfMvRw1xOFvMB6U46MjNiyTbpTxabCGduw CtCWm+GdAbRO7umLq+entvbF9bsg7jsJMGKWfVdxvZXOG3HhDG4QgSpPISo8mIBU1crU KQeujJZAH95m/CplrHqRqxCDnAVrzjxRQccygQlXfSy8I0ItauaBUXA1NZqYwn7iS1M8 Z4OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d12si554955pgq.491.2018.03.27.01.43.15; Tue, 27 Mar 2018 01:43:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbeC0Il5 (ORCPT + 99 others); Tue, 27 Mar 2018 04:41:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52774 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751686AbeC0Ilx (ORCPT ); Tue, 27 Mar 2018 04:41:53 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w2R8fcTL127215 for ; Tue, 27 Mar 2018 04:41:52 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0a-001b2d01.pphosted.com with ESMTP id 2gyjax0ye1-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Tue, 27 Mar 2018 04:41:51 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Mar 2018 09:41:49 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 27 Mar 2018 09:41:48 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w2R8flTD49152104; Tue, 27 Mar 2018 08:41:47 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8395BA4059; Tue, 27 Mar 2018 09:34:24 +0100 (BST) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7CC5A4053; Tue, 27 Mar 2018 09:34:23 +0100 (BST) Received: from icon-9-164-188-66.megacenter.de.ibm.com (unknown [9.164.188.66]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 27 Mar 2018 09:34:23 +0100 (BST) Date: Tue, 27 Mar 2018 10:41:45 +0200 (CEST) From: Sebastian Ott X-X-Sender: sebott@schleppi To: Geert Uytterhoeven cc: Christoph Hellwig , Jesper Nilsson , Linux Kernel Mailing List Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 In-Reply-To: References: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) Organization: =?ISO-8859-15?Q?=22IBM_Deutschland_Research_&_Development_GmbH?= =?ISO-8859-15?Q?_=2F_Vorsitzende_des_Aufsichtsrats=3A_Martina?= =?ISO-8859-15?Q?_Koederitz_Gesch=E4ftsf=FChrung=3A_Dirk_Wittkopp?= =?ISO-8859-15?Q?_Sitz_der_Gesellschaft=3A_B=F6blingen_=2F_Reg?= =?ISO-8859-15?Q?istergericht=3A_Amtsgericht_Stuttgart=2C_HRB_2432?= =?ISO-8859-15?Q?94=22?= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-TM-AS-GCONF: 00 x-cbid: 18032708-0020-0000-0000-0000040A39E7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18032708-0021-0000-0000-0000429E3B8E Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-27_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803270090 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, On Tue, 27 Mar 2018, Geert Uytterhoeven wrote: > On Tue, Mar 27, 2018 at 10:12 AM, Sebastian Ott > wrote: > > commit 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 broke usage of dma > > allocations specifying __GFP_ZERO by silently removing that flag. > > How did it break? The flag is now always added. + flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM | __GFP_ZERO); I read that as a removal. But maybe I need more coffee.. Sebastian