Received: by 10.213.65.68 with SMTP id h4csp427489imn; Tue, 27 Mar 2018 01:51:12 -0700 (PDT) X-Google-Smtp-Source: AG47ELtjdSUIOrpN5OKuIjB/GU2uXwKCwFzSVxiQDlRkNHt57hOdsgZC/LIp/YhdIuQhXJA3xP8V X-Received: by 10.98.246.26 with SMTP id x26mr19126211pfh.81.1522140671945; Tue, 27 Mar 2018 01:51:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522140671; cv=none; d=google.com; s=arc-20160816; b=fh2D9dCr5liQLDjzxeZe9NY9PB4Z2Z7Bm9XXHAxu2Fzz5AiCXVEZxfUi1VKUtoTyuu gJF1LMyieX/jyoHvU+mlbe3Ig8FwFLMoTaHlprv2JjqqLih768wT6hhoXeLg5QxsC3pA vz/dRtXxjhEz52zMG8yxqsnGSSF1zy8dBuhw+3fbPgV7OFU5oyRcAZVpfX7mjNqUAsVy d599RalEGKjjlnqwIV+qdcBHBqZe8nX7xYsjE/u5OG1QuTH1OTQ+vMZ7iQ/WJ/pVwaEd iyO+JX3OIi6d0WHKnTSQaJiRKRBUZ+8qrtRTw7GZWg4iwoA+RrXzWjVIl8QVcZOhavOD 3Omw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=zghWSDk3ldEc0CnxbKklSpiv3ljqNYv+FG4942ajNxM=; b=r2gxGghG0znftoA+rC4H/vp/kcjp1c+LprIyianati051doUvtZ3T4QiH0acsWSArm NsFyqaaTrHsuWk9Sai5Q/X4OQUQqbzQHiE87dNZfujw6JsnSrf4HgCVQklNupJJtKnEW 1pqn/9RFsSOA9Jltn5V5Bh/T1HXHca94lYNR5gWXqzWCMLzJ3CJvPDQ6T4VHJ3gWfz6b vS48C9TzRvVzELcKbXqov8dlxLRTdK4QPCD2iajaqomdc9jJ+iZxbDSY3RtIP1YG6g1i 56hGLPlyCb6C0ZE9U2CevEk1jvyUV/lVH2jUU99Q6PyqZeZXIuH3YpbpYtZMnWgLYxyr hysw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11-v6si773836pls.699.2018.03.27.01.50.57; Tue, 27 Mar 2018 01:51:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbeC0ItT (ORCPT + 99 others); Tue, 27 Mar 2018 04:49:19 -0400 Received: from mout.perfora.net ([74.208.4.196]:56921 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbeC0Ilb (ORCPT ); Tue, 27 Mar 2018 04:41:31 -0400 Received: from kahja.local ([73.170.116.139]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0MEV9L-1elg800lxp-00FmHt; Tue, 27 Mar 2018 10:41:29 +0200 From: Quytelda Kahja To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Quytelda Kahja Subject: [PATCH 08/23] staging: rtl8723bs: Remove braces from single statement conditionals. Date: Tue, 27 Mar 2018 01:41:00 -0700 Message-Id: <20180327084115.16129-8-quytelda@tamalin.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180327084115.16129-1-quytelda@tamalin.org> References: <20180327084115.16129-1-quytelda@tamalin.org> X-Provags-ID: V03:K0:rqymD5m2CTLXs1ReoMo1V15+HY9n1GejEM/NzBuz6nW1zP5OzDX qFwROv390I+nzEjzD9r1BlgaT4ofZuBV5u02ET5KXX3rJAKVn+y5U+SqaPlrLzM7wqu+HuS /+uRGoEEzcB7pSwCD+XNT8wDNoJOWvpLwdLigsOEZWGanrV2xNWUppIXzoHpxDRcUyk8pXF Ysk//SFqorEyxuY//O9Rw== X-UI-Out-Filterresults: notjunk:1;V01:K0:+T1MRW7nfjw=:aPvdTPNNCkVdPHhuyU/oCy SxGTvRLxLosm/UYXpa+sBn0LkItUZt69uSeTRhqABAcKIrMXfYPWGtZfW1sJ8nY02G6cOSR9b l1R7o/S81CnWjxpEueq96LumRzrghe96d/mjuaRmvew9AdgV9b+W9AvoL02V1d3dRI7BWeZoq oanP65AveXt2YJpa+ZoH/gG+LzeTzv4ZoKtIsTGqGY30kFgDey4VCTO9tYWe6uCJ5HMF0QABQ CqKAxCIFA3vVv+6kbwMGVvRktd7WCd3BahU0fphDmB2uwaUUTQyOFCmwlsxEUS3zstT90LhI8 C+4jo6kpLK+MAo9nC6uHO4XguuvlPkPLh9uBWuQbRU7g2/zRCmjH/NT0tz7W1LM0T+DF8wH5J O79wXj+v/CZGnG4uC26ssVBbEG+/h6kip/oIqe/UT5shyR9isCHVirQfZTre/bFK+QzdA5KIe E/+juu6tiPMGzy12XIOq2SZW9pf8omN3N0vQcju8v2BmBkttK52D7dl4+P1/vzVJw0KtvyQkV 5ZuyYi7IJBqb+vbA6VzH/RDJ9k37VQ4WjTMglnERW69Gss4c+FgOHBFktHWY7APNsawEvvn+w Fo6PFXBDNtxs+0eCxEw911XXStZFUxRQ/j3JAAXeq91KCBwETjLiaIP3fswLfetYyjZdtAdI8 5wu++4x5wBJq9HeXzZZ2EVaW7DbeaSLeJAFspa3+ocotTkcHR4uTn2yvqGOzLgVZaWD6n0qeJ bTDX8r1KETYhnIrUBQ8NeDRYQW8PdR8+K3JOvA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Several conditionals in rtw_wx_set_auth() contain a comment then a single statement. Move the comments to the top of the conditionals so that braces can be removed from the statements, which saves space and makes the code more readable. Signed-off-by: Quytelda Kahja --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c index 3e78fc28a8eb..1cacd7fff052 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c @@ -2151,13 +2151,11 @@ static int rtw_wx_set_auth(struct net_device *dev, */ break; case IW_AUTH_TKIP_COUNTERMEASURES: - if (param->value) { - /* wpa_supplicant is enabling the tkip countermeasure. */ + /* wpa_supplicant is setting the tkip countermeasure. */ + if (param->value) /* enabling */ padapter->securitypriv.btkip_countermeasure = true; - } else { - /* wpa_supplicant is disabling the tkip countermeasure. */ + else /* disabling */ padapter->securitypriv.btkip_countermeasure = false; - } break; case IW_AUTH_DROP_UNENCRYPTED: /* HACK: @@ -2172,10 +2170,12 @@ static int rtw_wx_set_auth(struct net_device *dev, * be set. */ - if (padapter->securitypriv.ndisencryptstatus == Ndis802_11Encryption1Enabled) { - break;/* it means init value, or using wep, ndisencryptstatus = Ndis802_11Encryption1Enabled, */ - /* then it needn't reset it; */ - } + /* + * This means init value, or using wep, ndisencryptstatus = + * Ndis802_11Encryption1Enabled, then it needn't reset it; + */ + if (padapter->securitypriv.ndisencryptstatus == Ndis802_11Encryption1Enabled) + break; if (param->value) { padapter->securitypriv.ndisencryptstatus = Ndis802_11EncryptionDisabled; -- 2.16.3