Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alexander Dahl <ada@thorsis.com>
To:     linux-arm-kernel@lists.infradead.org
Cc:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-kernel@vger.kernel.org,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 0/6] clocksource: rework Atmel TCB timer driver
Date:   Tue, 27 Mar 2018 12:41:08 +0200
Message-ID: <9761072.pX2B0LJlSJ@ada>
In-Reply-To: <20180223171558.7037-1-alexandre.belloni@bootlin.com>
References: <20180223171558.7037-1-alexandre.belloni@bootlin.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Alexandre,

Am Freitag, 23. Februar 2018, 18:15:52 CEST schrieb Alexandre Belloni:
>  - using the PIT doesn't work well with preempt-rt because its interrupt =
is
>    shared (in particular with the UART and their interrupt flags are
>    incompatible)

This is actually quite annoying when using the UART as a serial console,=20
producing garbage when you type too fast. That's why I tested this patch=20
series (on top of v4.16-rc7). Target is a at91sam9g20 based board, quite cl=
ose=20
to, but not actually an at91sam9g20-ek.

=46irst test was with the previous kernel config updated by oldconfig, so=20
basically still using the PIT:

  +CONFIG_ATMEL_CLOCKSOURCE_PIT=3Dy

On the serial console with v4.16 and the patch set without switching to the=
=20
new options, I see this on boot (no surprise, this is what it also prints w=
ith=20
v4.9):

  clocksource: pit: mask: 0xfffffff max_cycles: 0xfffffff, max_idle_ns:=20
14468723050 ns
  =E2=80=A6
  clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_n=
s:=20
19112604462750000 ns
  =E2=80=A6
  clocksource: tcb_clksrc: mask: 0xffffffff max_cycles: 0xffffffff,=20
max_idle_ns: 115749784805 ns
  =E2=80=A6
  clocksource: Switched to clocksource tcb_clksrc

Interrupts here:

  $ cat /proc/interrupts=20
             CPU0      =20
   16:       4802  atmel-aic   1 Level     at91_tick, rtc0, ttyS0
   19:      24041  atmel-aic  19 Level     tc_clkevt
   26:        124  atmel-aic  21 Level     eth0
   28:          1      GPIO  11 Edge      reset
  Err:          0

Second test with tcb block added to dts like in=20
32ce250b0af3b6971fc746445fce87861a9f5628 and with changed kernel config=20
according to defconfig changes in patch 5 and 6:

  +# CONFIG_ATMEL_CLOCKSOURCE_PIT is not set
  +CONFIG_ATMEL_CLOCKSOURCE_TCB=3Dy
  -CONFIG_ATMEL_TCLIB=3Dy
  -CONFIG_ATMEL_TCB_CLKSRC=3Dy
  -CONFIG_ATMEL_TCB_CLKSRC_BLOCK=3D0
  +# CONFIG_ATMEL_TCLIB is not set
  -CONFIG_ATMEL_PIT=3Dy
  +CONFIG_ATMEL_ARM_TCB_CLKSRC=3Dy
  -CONFIG_PWM_ATMEL_TCB=3Dm

The output on the serial console contains this:

  clocksource: timer@fffa0000:0,1: mask: 0xffffffff max_cycles: 0xffffffff,=
=20
max_idle_ns: 115749784805 ns
  =E2=80=A6
  clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_n=
s:=20
19112604462750000 ns
  =E2=80=A6
  clocksource: Switched to clocksource timer@fffa0000:0,1

Interrupts here:

  $ cat /proc/interrupts=20
             CPU0      =20
   17:    5727291  atmel-aic  19 Level     timer@fffa0000:2
   18:       5523  atmel-aic   1 Level     rtc0, ttyS0
   26:       5031  atmel-aic  21 Level     eth0
   28:          1      GPIO  11 Edge      reset
  Err:          0

So, the board boots and runs like usual. I don't know if that qualifies for=
 a=20
Tested-by? Hope that helps.

Greets
Alex