Received: by 10.213.65.68 with SMTP id h4csp653481imn; Tue, 27 Mar 2018 06:24:54 -0700 (PDT) X-Google-Smtp-Source: AG47ELsgGIBzyEO9YTw2eggXucr6sHGMMWuv9nA8ABjy2X0sAwlCPqlR0R35m1ys5HJ4sdt+WkR5 X-Received: by 10.99.124.79 with SMTP id l15mr31372120pgn.19.1522157094019; Tue, 27 Mar 2018 06:24:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522157093; cv=none; d=google.com; s=arc-20160816; b=moIhD8E5tVsyKR5Xtw1OttF9DF2FOMGyEuCNeMJ0mSzBpahlv1va+4KbLiVVgQaZnr hA1xXZ9w974ikorLDDly+4PQCFdSjW3xNhWm+Q0yEfqE4DMeBmXdPqtG+PV/nk//gpjC k2kRtubZSDojoBqoONd2toKD67DiUnSqJT+hw6nfjj+9if0Zs5tPz/Duvo+vycwdov2Y Y4uZeMweTFmanbHwmksAhexmbnOuRRcD67y3sUn4XaqQQQw6U6ffFXrrC7i7MEh5g2Z4 CCQaEEnNFQ/0r8inRFXq/M1ap1Hs+IYtfDC2+AOC/VsQ76IA5pM+X3a9nOWU9Rt9Gk1+ 7T+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=FsMHbqWcuDqZoSAJ+QNMiCuq4QTjQ5ncwk7tXF+nUI4=; b=jr+FEF/9bkCudLFw/UV17qioWFJmV7c2lXgUQnoOPn+6zCEuLwGBGdwDPvcpuwzrQl +brPT0/5OYjxqW0ZToNV1EQckkgtPAqQ+w0LZ19QU/kLZAPNNqwReoQILfqun4U39ndj p/fQzXWDxRFdUfLEZK/YqCYosbZBCfcxG17T33Iqz2Ku5WNcHBO84vxz21Dof3rlJA95 sC2yEuHIMG7cMjDO81qNhTEEVzprsE1N9uFRvOa69X330Z1NJUzG6uxQbh+s4HnJRldz nMWu5bXbymbvkXthjXbpsR2JSCmhe8X2QcERRA03Oog7VHC1gK6qW91kKC0D4OdDKNHM 2GJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h8si884520pgc.102.2018.03.27.06.24.38; Tue, 27 Mar 2018 06:24:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbeC0NWp (ORCPT + 99 others); Tue, 27 Mar 2018 09:22:45 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:55070 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756AbeC0NQW (ORCPT ); Tue, 27 Mar 2018 09:16:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5BB480D; Tue, 27 Mar 2018 06:16:21 -0700 (PDT) Received: from en101.cambridge.arm.com (en101.cambridge.arm.com [10.1.206.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F3B593F24A; Tue, 27 Mar 2018 06:16:18 -0700 (PDT) From: Suzuki K Poulose To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, cdall@kernel.org, marc.zyngier@arm.com, punit.agrawal@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, ard.biesheuvel@linaro.org, peter.maydell@linaro.org, kristina.martsenko@arm.com, mark.rutland@arm.com, Suzuki K Poulose Subject: [PATCH v2 07/17] kvm: arm/arm64: Remove spurious WARN_ON Date: Tue, 27 Mar 2018 14:15:17 +0100 Message-Id: <1522156531-28348-8-git-send-email-suzuki.poulose@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522156531-28348-1-git-send-email-suzuki.poulose@arm.com> References: <1522156531-28348-1-git-send-email-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On a 4-level page table pgd entry can be empty, unlike a 3-level page table. Remove the spurious WARN_ON() in stage_get_pud(). Cc: Marc Zyngier Acked-by: Christoffer Dall Signed-off-by: Suzuki K Poulose --- virt/kvm/arm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index 16a19fb..9cba334 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -862,7 +862,7 @@ static pud_t *stage2_get_pud(struct kvm *kvm, struct kvm_mmu_memory_cache *cache pud_t *pud; pgd = kvm->arch.pgd + stage2_pgd_index(addr); - if (WARN_ON(stage2_pgd_none(*pgd))) { + if (stage2_pgd_none(*pgd)) { if (!cache) return NULL; pud = mmu_memory_cache_alloc(cache); -- 2.7.4