Received: by 10.213.65.68 with SMTP id h4csp679333imn; Tue, 27 Mar 2018 06:53:44 -0700 (PDT) X-Google-Smtp-Source: AG47ELvVDakrJSs8S6DTnVeMAWShuvLF4HiuRqZ5W0uHzTru7dz9ayg5RXHPjTGusygnpLzHMF1R X-Received: by 2002:a17:902:ab81:: with SMTP id f1-v6mr40360045plr.5.1522158824520; Tue, 27 Mar 2018 06:53:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522158824; cv=none; d=google.com; s=arc-20160816; b=bdSgVUxKkxTr51Gk+ZmnerlHEai69BCLnY3MHfREhgaKfgu2CVKSMkXkWjaKIViQyp LTZFZ35/W2PFNVD1xjckzfCaC/Z2kKt70/3o28Umv/T2Ezc38zKQ7GB5NrpPOP8ry8OE 9XFfgUNZF3JTlTrxW8NxNy/6P4giyi8sPMEA9drfA7kgaIrdu6An78txhZ4BeqWmLL4h RkiZaXRlkJpD6Y+ZdfIBqTD0MxeqVbAGn6NXdmxI3bPdRhYRrxUntGjBil1foRYPSJ8y JS8aSO7Zg+PrAC893JjTIYUi/oDAhRdKUIcWsTMCdIM05DjbfTSkNc2h2aCNaAAZ0ale HZ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=ppcm4fXUnn2XVZ+FKs6wH+F7U1LRjxBvXlhrmYIZOzg=; b=evsEATLkZqnRaVMyGrm0DtW4z7Fa0/5KE2yN/Ncii1kmHY5pQy/FD65YHVPAuxvd2R Y1/KXirqGxeud7GTSx5sZ8QVCMR9JuvhhJbiXFp9byH0WTFQxbFQ4W3ae1KyC5msu9dG Hk3ZF9tNhxo1QNTcWn6DJA4M+Ztk+7CDKeRErbxKzXZ/H0meOGG2LB+eaeVMoCLZ0X/1 vgv1NYAcKRgWByoUolbVjcnQXlUsPWF9+ZOmhdJ6CKZBtBIyJ7npCU2hIg1PWj8HSDl8 NdSCtkBON634yYqnfGDR01hlBQYJkyX58/P1yw5FzMpeVu5cCfvQfxaOKCBCE3BS7oTm 98Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SgFBA5wH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c12si942297pgn.459.2018.03.27.06.53.29; Tue, 27 Mar 2018 06:53:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SgFBA5wH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbeC0Nwc (ORCPT + 99 others); Tue, 27 Mar 2018 09:52:32 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33663 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbeC0Nw3 (ORCPT ); Tue, 27 Mar 2018 09:52:29 -0400 Received: by mail-io0-f196.google.com with SMTP id l3so27698403iog.0 for ; Tue, 27 Mar 2018 06:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ppcm4fXUnn2XVZ+FKs6wH+F7U1LRjxBvXlhrmYIZOzg=; b=SgFBA5wHWD256SVLkMUvkxXQPJvIPkJiQNliCM83tNySSFRR+Bz16H1oJCMNb8zEi5 e+VI5dHUSAkULpV0FttPXW4TI9Y7Pb4Cga48OuC+x85BqvYB3QgDMnjaTA9zjGYhYEsV D7u4hI5ba/y2FwSqokmKDr5CowB4f2Q8PeQuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ppcm4fXUnn2XVZ+FKs6wH+F7U1LRjxBvXlhrmYIZOzg=; b=B4vdz3T4YPqkKYt1Ub6QmKEVvuFaDg/8goWwxPe7U2shrQVqmevDwetFTprDPiR4YV RYpuU2rPjt13B6yLIrQVh4dl+5Lx9OHsnsKv3f3lmWtSGkMojDG4VYyPNqo5Ib2y1rEr ApRYeavNJKJ+khmm2UkA2ceD2n4tf0lX3Ha6zeXOIYZi2cMrESA/Rn7d/GWggmVbDgn4 tDD1Pi00794/OyHA1I7lHLVX6vXE4IBOD5QSIMaFzgt7Nf/h9P075pBBsxlvtLy5nUeY 70qsmspQClsHdce0nw1U6MU0j+qnxZUZbDD1YfKGEoE4GoJSeRnXIchAET66sayRwP9m xFEQ== X-Gm-Message-State: AElRT7HbDlBaL/uUlaOI+5MmhFxsyqRZ/L7QewFAFRX6vxCDYGhhgqEG 7v0GCS9JzZktfJ1rggEl6DrrZdEoSLHRpfS2+MyLKg== X-Received: by 10.107.139.70 with SMTP id n67mr43721782iod.109.1522158748802; Tue, 27 Mar 2018 06:52:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.79.207.141 with HTTP; Tue, 27 Mar 2018 06:52:28 -0700 (PDT) In-Reply-To: References: <787c9f115db06390549bfee366b7f70faf312286.1520218279.git.baolin.wang@linaro.org> From: Linus Walleij Date: Tue, 27 Mar 2018 15:52:28 +0200 Message-ID: Subject: Re: [PATCH v3 3/3] gpio: Add Spreadtrum PMIC EIC driver support To: Baolin Wang Cc: Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , Mark Brown , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 5, 2018 at 3:56 AM, Baolin Wang wrote: > The Spreadtrum PMIC EIC controller contains only one bank of debounce EIC, > and this bank contains 16 EICs. Each EIC can only be used as input mode, > as well as supporting the debounce and the capability to trigger interrupts > when detecting input signals. > > Signed-off-by: Baolin Wang > --- > Changes since v2: > - Fix coding style issue. > - Fix possible overflow. > - Use for_each_set_bit(). Patch applied! Also added Andy's review tag on all of the patches. Yours, Linus Walleij