Received: by 10.213.65.68 with SMTP id h4csp790160imn; Tue, 27 Mar 2018 08:49:29 -0700 (PDT) X-Google-Smtp-Source: AG47ELsrgHA75s/9H6FVwHzjgAP+uX+KuoVKmyv+xPOChoAvvPKYzqY7yW4K0AUXRLK6xwgQMqh0 X-Received: by 2002:a17:902:7295:: with SMTP id d21-v6mr29436520pll.130.1522165769697; Tue, 27 Mar 2018 08:49:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522165769; cv=none; d=google.com; s=arc-20160816; b=OLNHTVenbvYKYJNqzoY259rS+NkYDmRj+vLzQs+3C4DcyuaMPvebessemydiVl2Z9m pdBmvWsBQO+vPICmM8d/xXS13s00QGhE91SzL+DHZPQjqfIBK8IyiANRZv0FR3f1QLEp 452OfRNtPb+JyatPPoRE66IYRgryeN/RoUA+wcMgHxety+FXBv8nNPlBD9DsWyqZQG8s 16HAC07Zh6j9jr2aGJV/NMK0pBFjsucal7WBqC+LAguTUmt5e0kX8ClccaegEFkw/EJ/ nXtJ40S1rWXoseVb0rpnF2K6g4bF6NIf4AW+SnSEBtVglivFQGi4gQJEh6CDjxAlJkZ+ YliA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=xjc2sB4ut7qS234fr4qnWnu6ckXknwyL7gmAri9J8Jw=; b=RQtiHuhNhkU4w+TaGowZsKgbbIhBtO4CTl4YmE3Mq2H0AZZbu+T1AhMcSB4sV7Ym7V tZ0+KKSOqF06pq9PHX3n1iusu2NX8ji+jlP/fcxNxlQbDrHtrk0pYjlMcufIeWg6HPGR UjJ02nO8v7pWXoniNkxO+dVfvCQgTVZey9r0JTI9yuwYLVketZH/wCXkhhFukrilxIW/ QhBpwYztZuvuJHjgyjrvFoSrs7mCebJwrIJBwvFv6SpDZDpoBtTp8jfcL4zm63+PFO8J IJgK6uCRhc0O4rIBiHHv/g/Dsa3GHHOUb4bl/KVYx4l4XAKAY5/wDZCbP8bK0RoZah46 2ZZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc11-v6si1471185plb.43.2018.03.27.08.49.15; Tue, 27 Mar 2018 08:49:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbeC0PrS (ORCPT + 99 others); Tue, 27 Mar 2018 11:47:18 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:45684 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752046AbeC0PrQ (ORCPT ); Tue, 27 Mar 2018 11:47:16 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian)) id 1f0qoU-0007hL-Uq; Tue, 27 Mar 2018 23:47:07 +0800 Received: from herbert by gondobar with local (Exim 4.84_2) (envelope-from ) id 1f0qoR-0003ef-Tf; Tue, 27 Mar 2018 23:47:03 +0800 Date: Tue, 27 Mar 2018 23:47:03 +0800 From: Herbert Xu To: NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] rhashtable: reset intr when rhashtable_walk_start sees new table Message-ID: <20180327154703.GA14001@gondor.apana.org.au> References: <152210688405.11435.13010923693146415942.stgit@noble> <152210718427.11435.17689950338335773862.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152210718427.11435.17689950338335773862.stgit@noble> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 10:33:04AM +1100, NeilBrown wrote: > The documentation claims that when rhashtable_walk_start_check() > detects a resize event, it will rewind back to the beginning > of the table. This is not true. We need to set ->slot and > ->skip to be zero for it to be true. > > Signed-off-by: NeilBrown Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt