Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S275298AbTHMR4E (ORCPT ); Wed, 13 Aug 2003 13:56:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S275303AbTHMRyz (ORCPT ); Wed, 13 Aug 2003 13:54:55 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:5553 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S275298AbTHMRyW (ORCPT ); Wed, 13 Aug 2003 13:54:22 -0400 Message-ID: <3F3A7B41.1040206@pobox.com> Date: Wed, 13 Aug 2003 13:54:09 -0400 From: Jeff Garzik Organization: none User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021213 Debian/1.2.1-2.bunk X-Accept-Language: en MIME-Version: 1.0 To: Sam Ravnborg CC: Greg KH , "David S. Miller" , rddunlap@osdl.org, davej@redhat.com, willy@debian.org, linux-kernel@vger.kernel.org, kernel-janitor-discuss@lists.sourceforge.net Subject: Re: C99 Initialisers References: <20030812180158.GA1416@kroah.com> <3F397FFB.9090601@pobox.com> <20030812171407.09f31455.rddunlap@osdl.org> <3F3986ED.1050206@pobox.com> <20030812173742.6e17f7d7.rddunlap@osdl.org> <20030813004941.GD2184@redhat.com> <32835.4.4.25.4.1060743746.squirrel@www.osdl.org> <3F39AFDF.1020905@pobox.com> <20030813031432.22b6a0d6.davem@redhat.com> <20030813173150.GA3317@kroah.com> <20030813175009.GA12128@mars.ravnborg.org> In-Reply-To: <20030813175009.GA12128@mars.ravnborg.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 775 Lines: 26 Sam Ravnborg wrote: > On Wed, Aug 13, 2003 at 10:31:51AM -0700, Greg KH wrote: > >>How about this patch? If you like it I'll add the pci.h change to the >>tree and let you take the tg3.c part. >> >>+ { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700) }, > > Why not without the extra {}'s so something like this: > > >>+ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5701), >>+ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5702), Either way is fine with me; they're both shorter. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/