Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S275320AbTHMSDQ (ORCPT ); Wed, 13 Aug 2003 14:03:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S275323AbTHMSDP (ORCPT ); Wed, 13 Aug 2003 14:03:15 -0400 Received: from mail.kroah.org ([65.200.24.183]:59046 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S275320AbTHMSCx (ORCPT ); Wed, 13 Aug 2003 14:02:53 -0400 Date: Wed, 13 Aug 2003 11:03:10 -0700 From: Greg KH To: Matthew Wilcox Cc: "David S. Miller" , Jeff Garzik , rddunlap@osdl.org, davej@redhat.com, linux-kernel@vger.kernel.org, kernel-janitor-discuss@lists.sourceforge.net Subject: Re: C99 Initialisers Message-ID: <20030813180310.GD3317@kroah.com> References: <20030812171407.09f31455.rddunlap@osdl.org> <3F3986ED.1050206@pobox.com> <20030812173742.6e17f7d7.rddunlap@osdl.org> <20030813004941.GD2184@redhat.com> <32835.4.4.25.4.1060743746.squirrel@www.osdl.org> <3F39AFDF.1020905@pobox.com> <20030813031432.22b6a0d6.davem@redhat.com> <20030813173150.GA3317@kroah.com> <20030813175009.GA12128@mars.ravnborg.org> <20030813175422.GZ10015@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20030813175422.GZ10015@parcelfarce.linux.theplanet.co.uk> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 31 On Wed, Aug 13, 2003 at 06:54:22PM +0100, Matthew Wilcox wrote: > On Wed, Aug 13, 2003 at 07:50:09PM +0200, Sam Ravnborg wrote: > > On Wed, Aug 13, 2003 at 10:31:51AM -0700, Greg KH wrote: > > > > > > How about this patch? If you like it I'll add the pci.h change to the > > > tree and let you take the tg3.c part. > > > > > > + { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700) }, > > Why not without the extra {}'s so something like this: > > > > > + PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5701), > > > + PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5702), > > > { 0, } > > > }; > > > > > > +#define PCI_DEVICE(vend,dev) {?\ > > > + .vendor = (vend), .device = (dev), \ > > > + .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID } > > ... and while we're at it: > > +#define END_OF_LIST { 0, } Now you're just getting silly. greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/