Received: by 10.213.65.68 with SMTP id h4csp851945imn; Tue, 27 Mar 2018 09:58:17 -0700 (PDT) X-Google-Smtp-Source: AIpwx49zNfcxr3UCkJfMN77zoZHeYVjmvlQtaza05lWvy/dkl0JsHNmvABXmYBqWZnjIr/kJEXZ1 X-Received: by 2002:a17:902:bc45:: with SMTP id t5-v6mr79095plz.343.1522169897799; Tue, 27 Mar 2018 09:58:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522169897; cv=none; d=google.com; s=arc-20160816; b=ccvCg+n5JBQKJoV/rd5R7kV/fJCxCp7gl0bW4pc9fry8tL/CHAYZ6t7jOz7l/Jo1R1 x2UAnyG4yox4VBtCXIur96muHzaG9j8PXPrYxfiArCmic81ObpCf6x0hskr8jJI7kHin T6Bxdk+/z8g6gFKX0ZlsLR5l07KCusWPzS43onNtwxxaAbBslRdJY2+yshusHxMARsQu FOHDHYvmCFQaukfVY3XRMLAC5Z36akVRPtkEsmvRNtpVM4jd8BI9+Qcz/wD1RACU96zW Xsws7vDM8TdD40WV0tlfkfAfFD1Un4enAOM6vzTKWkvrUznp6baFYtJygoRXy0SIWbgd a7mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=IJTMP1R5FF5QEz6cJdwJG8Y28WvZia36iMhTyd1N81U=; b=uahIjAFhZXzs+UrmgSBtKt7jENgpYFSlLFixVNf7jgii8HDs1fmcF7qVsx3Pyl1Wxr rJRye0t9FhRIES8jqEqSU61Kni6sD0CGuvqdGjzkUrRMHYpMtxqTCTAJmWoxU8gHh1ai cwP7kUl+vOVXXY3txmX4tD1Ok6yiqVwQhSvfHBkAjJsMdmL7p+23MIqlrrA3O4r5b2Yl 2zvxaKyuqMqigDS3ptG9G2Gn9xXeR5I9KAZOPui8L5Ui8wBhPQ8lQxfIL4fLuxsSI9H5 74qUi17iyAKkJLQYgyTQkKCFsKFKzR7GkzorFhg8hsOLhqCYkzQWpdz9QAT+3zVL1eOE e89g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j192si1120036pge.291.2018.03.27.09.58.03; Tue, 27 Mar 2018 09:58:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932578AbeC0Qlm (ORCPT + 99 others); Tue, 27 Mar 2018 12:41:42 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755553AbeC0Qlj (ORCPT ); Tue, 27 Mar 2018 12:41:39 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 12C47F47; Tue, 27 Mar 2018 16:41:38 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jagdish Gediya , Prabhakar Kushwaha , Boris Brezillon Subject: [PATCH 4.15 071/105] mtd: nand: fsl_ifc: Fix nand waitfunc return value Date: Tue, 27 Mar 2018 18:27:51 +0200 Message-Id: <20180327162802.330352543@linuxfoundation.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180327162757.813009222@linuxfoundation.org> References: <20180327162757.813009222@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jagdish Gediya commit fa8e6d58c5bc260f4369c6699683d69695daed0a upstream. As per the IFC hardware manual, Most significant 2 bytes in nand_fsr register are the outcome of NAND READ STATUS command. So status value need to be shifted and aligned as per the nand framework requirement. Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller") Cc: stable@vger.kernel.org # v3.18+ Signed-off-by: Jagdish Gediya Reviewed-by: Prabhakar Kushwaha Signed-off-by: Boris Brezillon Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/fsl_ifc_nand.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/mtd/nand/fsl_ifc_nand.c +++ b/drivers/mtd/nand/fsl_ifc_nand.c @@ -626,6 +626,7 @@ static int fsl_ifc_wait(struct mtd_info struct fsl_ifc_ctrl *ctrl = priv->ctrl; struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs; u32 nand_fsr; + int status; /* Use READ_STATUS command, but wait for the device to be ready */ ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) | @@ -640,12 +641,12 @@ static int fsl_ifc_wait(struct mtd_info fsl_ifc_run_command(mtd); nand_fsr = ifc_in32(&ifc->ifc_nand.nand_fsr); - + status = nand_fsr >> 24; /* * The chip always seems to report that it is * write-protected, even when it is not. */ - return nand_fsr | NAND_STATUS_WP; + return status | NAND_STATUS_WP; } /*