Received: by 10.213.65.68 with SMTP id h4csp886138imn; Tue, 27 Mar 2018 10:35:13 -0700 (PDT) X-Google-Smtp-Source: AIpwx48DxzNsSQqgb10Ocgm0VQPKT0sbKeU7kz+sBpHQvAM+QKqK4j4PlYlOIj1nZrjcJw8tVfVm X-Received: by 10.101.98.90 with SMTP id q26mr151738pgv.113.1522172112919; Tue, 27 Mar 2018 10:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522172112; cv=none; d=google.com; s=arc-20160816; b=JCxO+3lOl9QR66Md75DAzL5XIP+7LvOpckTAo/CSpjlLTiv161dNPpm4q8WEvEhMzs gcth9QrfdkhmePKcA4d83x3NTRTwIHqq9sPmLUjwhn7oFJzHCV99/9gNBmQ9je5v3xe8 aGc1Ew3RaflhJGjnlJB+3zHYA8gT8BW0J2uEj1s+XjexJm6ffjFOJjQYpynMyKjBJMxW TR98eZX+ArOYFq0XxMHne2TXc7QHA8Ghm7jd95ATBQUgWr1CgsThjbZR4ohHR9bFihbd xLtlwySYQtX6n3tmyv7Mg58vCtOs8IHDxwSPelDgxq7Uo/HVk8Pr6JNd3pyCo7oqwz92 Alpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=+fGk7r/z4kkJ0n3+Or9WagpgxeqCPZcwWalhOzJ5wQM=; b=Sr17076rvQeuaV/v3ItAjmwdXCJcQImd4hUAes+F/JNbgUSxQ3rBVjBn3h1EhgYB8A L8WOl5VXmuSCPPzwgOTziCDQxqY2YVcUMDm/GzR1CVbkoUzMv4u87wVOWDBHWlefZ4G5 ylUXDT8XpBpa7ckf7EFVEqeqyXRuoJgAht71f3urH0nAzTRGDdoQd9/6lHCHtyAVzm82 mxznH52swPN+fh+R/WykFNr8iiiAEs0Bs6452xQRYZL0FyslZgbU2adGNyjnbzA10VY2 Ki22dUxGBDxNP4BGHerh1Vv+4pIaZCYUEtE/VaOGPdVl3rBQEIHjlwaBPRJaEnuAgxr3 Hl0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f186si1100530pgc.527.2018.03.27.10.34.58; Tue, 27 Mar 2018 10:35:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754441AbeC0QfP (ORCPT + 99 others); Tue, 27 Mar 2018 12:35:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44728 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754425AbeC0QfM (ORCPT ); Tue, 27 Mar 2018 12:35:12 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 45FDC1226; Tue, 27 Mar 2018 16:35:11 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Tejun Heo Subject: [PATCH 4.14 037/101] libata: Apply NOLPM quirk to Crucial MX100 512GB SSDs Date: Tue, 27 Mar 2018 18:27:09 +0200 Message-Id: <20180327162752.288325636@linuxfoundation.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180327162749.993880276@linuxfoundation.org> References: <20180327162749.993880276@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit 9c7be59fc519af9081c46c48f06f2b8fadf55ad8 upstream. Various people have reported the Crucial MX100 512GB model not working with LPM set to min_power. I've now received a report that it also does not work with the new med_power_with_dipm level. It does work with medium_power, but that has no measurable power-savings and given the amount of people being bitten by the other levels not working, this commit just disables LPM altogether. Note all reporters of this have either the 512GB model (max capacity), or are not specifying their SSD's size. So for now this quirk assumes this is a problem with the 512GB model only. Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=89261 Buglink: https://github.com/linrunner/TLP/issues/84 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- drivers/ata/libata-core.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -4520,6 +4520,11 @@ static const struct ata_blacklist_entry { "PIONEER DVD-RW DVR-212D", NULL, ATA_HORKAGE_NOSETXFER }, { "PIONEER DVD-RW DVR-216D", NULL, ATA_HORKAGE_NOSETXFER }, + /* The 512GB version of the MX100 has both queued TRIM and LPM issues */ + { "Crucial_CT512MX100*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | + ATA_HORKAGE_ZERO_AFTER_TRIM | + ATA_HORKAGE_NOLPM, }, + /* devices that don't properly handle queued TRIM commands */ { "Micron_M500_*", NULL, ATA_HORKAGE_NO_NCQ_TRIM | ATA_HORKAGE_ZERO_AFTER_TRIM, },