Received: by 10.213.65.68 with SMTP id h4csp944681imn; Tue, 27 Mar 2018 11:40:42 -0700 (PDT) X-Google-Smtp-Source: AIpwx48+A7Aaf5Dg1ceifYJg5u6pvnRGWTgzdoIbl7tEB+KsdVZQefXZbIKgAlrFIaIwNNQt1Tig X-Received: by 10.98.61.206 with SMTP id x75mr333334pfj.233.1522176042172; Tue, 27 Mar 2018 11:40:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522176042; cv=none; d=google.com; s=arc-20160816; b=DBqH/ioF5nv8uHX8eaXtY+dZfTTnI3VbYjjpnVAhyt12EUTkK8K9DvXs8Fm8+0/S4c nMs6inh76x47YzXD6VW1WC5sdbNil8gaOvjMMOsMv+I6O73nDjsamTEAOXK8hHSOg2JS HAIwezVcVo+achRZ1+SmVaCYcWCSxfWG7KyeOKarNh6OSKahrAAYpTKrwO7pdV0QaUwU uJxyixu08UHHU60dsfFd/zbxy6wHI0g+wwxJQ8zGHUbDmyJGTUXBc3m9JEgcn9dprwG0 WFeRQaBJ5gln/qlSq1TpWdBDHPhsKQjXrWHfgENZgVBCpGzlHaFZvRNROi7pU5psI/9i bg+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zzwyGbGJ0khH1vfsmQHZDoK5fugQnQSGNRSfqtGStRE=; b=toLaoJzTq9nBN8qpNf0qQ0pW5Ct29POv48YkUnnyXAT/fwS+9tOBUbMz0+b+vlBSqz 5+EBqN6Q0u1h+MIBEPGcZAreWS2LaPV6/s/tAeO7c4J0HNvdgHvm7kHUHhDiuJRXDWy1 fmZk79dpXt8ysfMWwKu18lWFfEuTGCMTEMkXMAEWjrGty8YdblXcSOZvVtTdM5OlkgGe z3XdTBkGfJxdE+Pnegqt/579sL0UWBwow1/ZFUPAKUiWtzBFUxC+gwqWj0kTWEvfKkSR pP1cEvdGrIhfwa4CvTjQwMdT+kEpmqfCLZerf9XihtWnwbmmfmWxBKWfOkC6E6HuDPIk uKtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h6si1230760pgc.830.2018.03.27.11.40.27; Tue, 27 Mar 2018 11:40:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbeC0Sj1 (ORCPT + 99 others); Tue, 27 Mar 2018 14:39:27 -0400 Received: from mga03.intel.com ([134.134.136.65]:33157 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750965AbeC0Sj0 (ORCPT ); Tue, 27 Mar 2018 14:39:26 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 11:39:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,367,1517904000"; d="scan'208";a="38601888" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga003.jf.intel.com with ESMTP; 27 Mar 2018 11:39:23 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1f0tVC-00099E-LP; Wed, 28 Mar 2018 02:39:22 +0800 Date: Wed, 28 Mar 2018 02:39:15 +0800 From: kbuild test robot To: Kees Cook Cc: kbuild-all@01.org, Andrew Morton , Linus Torvalds , Martin Uecker , Josh Poimboeuf , Rasmus Villemoes , Randy Dunlap , Miguel Ojeda , Ingo Molnar , David Laight , Ian Abbott , linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v6] kernel.h: Retain constant expression output for max()/min() Message-ID: <201803280107.bZw8jIAt%fengguang.wu@intel.com> References: <20180326221554.GA45166@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180326221554.GA45166@beast> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc7 next-20180327] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kees-Cook/kernel-h-Retain-constant-expression-output-for-max-min/20180327-110916 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ vim +124 drivers/infiniband/hw/vmw_pvrdma/pvrdma_doorbell.c 29c8d9eb Adit Ranadive 2016-10-02 114 29c8d9eb Adit Ranadive 2016-10-02 115 void pvrdma_uar_free(struct pvrdma_dev *dev, struct pvrdma_uar_map *uar) 29c8d9eb Adit Ranadive 2016-10-02 116 { 29c8d9eb Adit Ranadive 2016-10-02 117 struct pvrdma_id_table *tbl = &dev->uar_table.tbl; 29c8d9eb Adit Ranadive 2016-10-02 118 unsigned long flags; 29c8d9eb Adit Ranadive 2016-10-02 119 u32 obj; 29c8d9eb Adit Ranadive 2016-10-02 120 29c8d9eb Adit Ranadive 2016-10-02 121 obj = uar->index & (tbl->max - 1); 29c8d9eb Adit Ranadive 2016-10-02 122 spin_lock_irqsave(&tbl->lock, flags); 29c8d9eb Adit Ranadive 2016-10-02 123 clear_bit(obj, tbl->table); 29c8d9eb Adit Ranadive 2016-10-02 @124 tbl->last = min(tbl->last, obj); :::::: The code at line 124 was first introduced by commit :::::: 29c8d9eba550c6d73d17cc1618a9f5f2a7345aa1 IB: Add vmw_pvrdma driver :::::: TO: Adit Ranadive :::::: CC: Doug Ledford --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation