Received: by 10.213.65.68 with SMTP id h4csp1067117imn; Tue, 27 Mar 2018 14:09:23 -0700 (PDT) X-Google-Smtp-Source: AIpwx48gH7JwuH2P6AlPNR7YXwCVoZkLrC3swc+NoLlb5udmS6ch5G5uNpXlklmvWk+DChaIRniX X-Received: by 10.101.93.17 with SMTP id e17mr590309pgr.239.1522184963493; Tue, 27 Mar 2018 14:09:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522184963; cv=none; d=google.com; s=arc-20160816; b=ARFhwFO0mXBIvJF5WJvVHbR+qOKMpHOUT9CG6+02xAYXfOYRGZS/+aOvBONMZE/9TR fBkI7541xlBFyZ9tCw6AnVpPfxqNBtYz8mmHbtt1sTR5xcxeW6QVBiuUqDEHVEoM4Ju4 5K8vil4p8PBoOY16/5Z8JQxrLgnaXr7Dx39VCQfHjcaQ9bZvqrVflqq/ePEREHOVGHSo FV4fGNhOkIqBfPR37pHUMh3LzuHPEBjvVZlc9DZmlwPlhVtB/8JbP5zBTmKKNx7KcfXE mP6+XeaQwJA2xua6iJT65E2KM8N74SV3J2pIIYGLIvy/iZ3/CJwUHNhUnNItItN+sGML XqCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=eOmHcp9SJwCRgwr8PDwnIN0+lVjt/PS2/EiGn70wT5I=; b=Q0IdBppJXTkKTWpU9RbkciA78TDsLqnLNEMGYKImXiJXfPlU8QTvEyDtt3nUcIuuLj vmWikd/wPif5Z4Mh3RaMKgIGLlQSQyKFS7PhAX2xRiR2yThaCthZgjOrfsJuPfEBdcS7 ldz9KHl6mBVnYGj4viDBnqGxuxNlvkkrpVTXg5px/wj5TqKwtlEirdAKp/AL1eMa4c/2 BbYNgP0gzB5ng0xMHYgLABcP8D7iTYYatlflMxLpwkmwLVSMsQhn4CH/waBMklL6RrRi EDlZqbMBrFnSL0aN+IGmotKD1y+OY5lac9H+psKhndQur5uvag/i/eAcI7SziKajQnnE mG4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YRhR0dMS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1si1427955pgn.564.2018.03.27.14.09.08; Tue, 27 Mar 2018 14:09:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YRhR0dMS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbeC0VHa (ORCPT + 99 others); Tue, 27 Mar 2018 17:07:30 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:33870 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbeC0VGs (ORCPT ); Tue, 27 Mar 2018 17:06:48 -0400 Received: by mail-pl0-f67.google.com with SMTP id u11-v6so194962plq.1 for ; Tue, 27 Mar 2018 14:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eOmHcp9SJwCRgwr8PDwnIN0+lVjt/PS2/EiGn70wT5I=; b=YRhR0dMSpd/bJnACbbXymp6vY3v7XaiVkil0JgX1l6oKRYJ6t5gTY2oCVaoImvC+z/ nVEYr0IV0NlaIChjKp1DyUYUv5YL+ZB72tWELvPhYiM49OV5SmAsdyjkZa9IwP4ToNh2 bErHdqnU7PsYmJIrRC9FeA+/C1sYEVxQHWnnU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eOmHcp9SJwCRgwr8PDwnIN0+lVjt/PS2/EiGn70wT5I=; b=ppJJDmMoY1nuv6ddeyrmgFONblJMJMHXzPjZOzPbokFVg8brQk+9foJ578lXQSfOD2 wQPXMyuXZMTOOr8OvSRm03PpLQNnjdUmOLuBgihMg3dOdsb5JhvRELY5jZALmOQrTMWm wmNFfe+5iSabHmpCf4A2wNizahToadIPvxY5BuF//iHX3CdLiIJ4LZPhD93jtBad8myo 6Vus/lUzp4fbXeAYh5EWdlvoxJPKnpRywmPJk5+g11QdQ3UvAhzxmyZmZFa1TuWnvHxD CiuJhJnt6t+fWJ6YomgF9m+Mi9X9OHeP0jp2Vtq+9ZQvdgrynSb3J4lrN8r/ybadf0A4 w5Yg== X-Gm-Message-State: AElRT7HizhwSb1u8AUUY+CXzx5vd8bJQWQHW0vqwnZ0kWVNe/dkn9yag F1mT9qD+G18gFQXwNDdvauXNNwiFUfA= X-Received: by 2002:a17:902:b901:: with SMTP id bf1-v6mr900841plb.74.1522184808158; Tue, 27 Mar 2018 14:06:48 -0700 (PDT) Received: from localhost.localdomain (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b64sm4661907pfl.148.2018.03.27.14.06.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Mar 2018 14:06:47 -0700 (PDT) From: Bjorn Andersson To: Ohad Ben-Cohen , Bjorn Andersson Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/3] rpmsg: smd: Fix container_of macros Date: Tue, 27 Mar 2018 14:06:41 -0700 Message-Id: <20180327210643.3436-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180327210643.3436-1-bjorn.andersson@linaro.org> References: <20180327210643.3436-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The container_of macros should not use the same name for the parameter as the member to use for lookup, as this will result in a compilation error unless the passed parameter has the same name as the member. Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_smd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index dabd73bd5577..6bb9d21be6bc 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -167,9 +167,9 @@ struct qcom_smd_endpoint { struct qcom_smd_channel *qsch; }; -#define to_smd_device(_rpdev) container_of(_rpdev, struct qcom_smd_device, rpdev) +#define to_smd_device(r) container_of(r, struct qcom_smd_device, rpdev) #define to_smd_edge(d) container_of(d, struct qcom_smd_edge, dev) -#define to_smd_endpoint(ept) container_of(ept, struct qcom_smd_endpoint, ept) +#define to_smd_endpoint(e) container_of(e, struct qcom_smd_endpoint, ept) /** * struct qcom_smd_channel - smd channel struct -- 2.16.2