Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 27 Mar 2018 16:13:21 -0700
From:   Davidlohr Bueso <dave@stgolabs.net>
To:     Waiman Long <longman@redhat.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] locking/debug: Add a master lock debugging switch
Message-ID: <20180327231321.4on2kczby5ejqglt@linux-n805>
References: <1522186690-10526-1-git-send-email-longman@redhat.com>
 <1522186690-10526-3-git-send-email-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1522186690-10526-3-git-send-email-longman@redhat.com>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 27 Mar 2018, Waiman Long wrote:

>Add a new master LOCK_DEBUGGING Kconfig option to turn on all the lock
>debugging options except the selftests and the torture tests.

For what purpose?

I'm not sure we want yet another config debug option. These are all expert
level configuration and honestly I would rather such users _think_ about
what options they are enabling instead of giving them a large hammer.

If enough load, this can also make boxes completely locked up for any sort of
testing/debugging. I vote no.

Also, CI efforts such 0-day already have the necessary scripting to cover the
debug options that make sense.

Thanks,
Davidlohr