Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Mar 2018 09:45:25 +0800
From:   "Du, Changbin" <changbin.du@intel.com>
To:     Shuah Khan <shuah@kernel.org>
Cc:     changbin.du@intel.com, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2 1/4] selftests/Makefile: append a slash to env
 variable OUTPUT
Message-ID: <20180328014525.bl3iih4xvo74wedb@intel.com>
References: <1522120294-24926-1-git-send-email-changbin.du@intel.com>
 <1522120294-24926-2-git-send-email-changbin.du@intel.com>
 <b473e652-0953-63ec-c4bf-5c9306dc4f67@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b473e652-0953-63ec-c4bf-5c9306dc4f67@kernel.org>
User-Agent: NeoMutt/20180323-6-5ca392
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 27, 2018 at 03:19:26PM -0600, Shuah Khan wrote:
> On 03/26/2018 09:11 PM, changbin.du@intel.com wrote:
> > From: Changbin Du <changbin.du@intel.com>
> > 
> > The tools/build/Makefile.build use 'OUTPUT' variable as below example:
> > objprefix    := $(subst ./,,$(OUTPUT)$(dir)/)
> > 
> > So it requires the 'OUTPUT' already has a slash at the end.
> > 
> > This patch can kill below odd paths:
> > make[3]: Entering directory '/home/changbin/work/linux/tools/gpio'
> >   CC       /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio.o
> >   CC       /home/changbin/work/linux/tools/testing/selftests/gpiogpio-utils.o
> >   LD       /home/changbin/work/linux/tools/testing/selftests/gpiolsgpio-in.o
> > 
> > A correct path should be:
> > /home/changbin/work/linux/tools/testing/selftests/gpio/lsgpio.o
> > 
> > Signed-off-by: Changbin Du <changbin.du@intel.com>
> 
> Are you seeing this when you run "make kselftest" - if gpio is the
> only test compile that fails, it should be fixed in gpio/Makefile,
> not is the common Makefile.
>
I only saw error in gpio, but I also saw some kselftest Makefiles having string concatenation
as '$(OUTPUT)$(dir)'. So the rule is not aligned all over. They just didn't produce any errors
so far.

By the way, is there a basic test for kselftest infrastructure? It seems it was always
reporting error when building it :(

> thanks,
> -- Shuah

-- 
Thanks,
Changbin Du