Received: by 10.213.65.68 with SMTP id h4csp153773imn; Tue, 27 Mar 2018 19:10:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx48ZE5cG5NovPpdS1Qhq2m6G540xAsDhn4bh+rptb0uuA96GfNlKnb1foxoWLHKj13OWBco7 X-Received: by 2002:a17:902:5681:: with SMTP id j1-v6mr1737175pli.383.1522203033522; Tue, 27 Mar 2018 19:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522203033; cv=none; d=google.com; s=arc-20160816; b=qo8L5CdoI0P/Sm90z8ysHKILqoGYLpWckGGdqu9LkrIW0MCAzszIJMI/xugJotjTDP tfStdSs6LznPANgM6LMuzaxU9OUyYxkl7WQONmgzg8L6Bue64KgYuVELD+pvsiS2rDt/ MCtpY0GHnk9ctke4JbEtmGhDfnTv3cDLOLcSPWrVfFVbOUDlNsCgWLwyQkgdxP42DS66 wr3Buq8YWS6+yMH3HRMrSAEFIlVeX99HZA4iI0ANUCSwCiIfY3mXVuSKnjLWf7Uvk+Iy tSnYKQUXgiJMub32aM9C+J0bG6nRZaHAqutdvKCTjvgn4erLkSYF7acf40q9H2JNj/g5 l4iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=gZUMVf894iKmg8VhNvgprdbsJaRCIkJ0pC0q7at4E8s=; b=MEugq9sX2t4o6h4W7w8KSlPwYgWJVhALVpWXysBZ74jQuCqetqEl1kUjjNz8etM1Jz rQDJcQokD8WKK82gTmrg4gDmVjcuMLCR4UsUHTlYLzEYGrtisRVaZEphzmQqEbg4Kl8S Zmo9sBmOyvL/XmI4MmdG7OEsN/u6k6X8jbCRU4pLw4sf/qKJajB258ySfCADkcfTplzL PamHusqKaT/WPpRt2HmZ87PVdv38sdA2Vmg5IHMB9EpExiJuPx0DBdK7qlcjam/pzpu/ tBAswFXN7CQyEAE0vVUX/P4n1ZnZQ8MLgfsQTmKWyxzslqND9AWAC1Z/zVLkS6Ogc4bA xtSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LQH5FioS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si1715348pge.733.2018.03.27.19.10.19; Tue, 27 Mar 2018 19:10:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LQH5FioS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752819AbeC1CJF (ORCPT + 99 others); Tue, 27 Mar 2018 22:09:05 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:57466 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492AbeC1CJD (ORCPT ); Tue, 27 Mar 2018 22:09:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gZUMVf894iKmg8VhNvgprdbsJaRCIkJ0pC0q7at4E8s=; b=LQH5FioS7VikcPl2RNO40i8aF /9dQB6uF20R8FF5YAv0EKfSYYALV/TjDZbRsOm72JoEqwkvHbGjg919oXYD9VrcLqnH/4kd21i0Dr Awy7/ym0BOBh23j5t0LNCSq0ZrYMtWvl2wZJGmXUF3W8ZvrfM9O/6oTpFJ5vKc3HGFQYU=; Received: from [202.155.252.3] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f10WE-0007d0-Nf; Wed, 28 Mar 2018 02:08:55 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id 887A844007A; Wed, 28 Mar 2018 03:08:45 +0100 (BST) Date: Wed, 28 Mar 2018 10:08:45 +0800 From: Mark Brown To: David Collins Cc: Doug Anderson , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , sboyd@kernel.org, ilina@codeaurora.org Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180328020845.GB29099@sirena.org.uk> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <184378e4-caf8-6ce3-e089-3690588fcb28@codeaurora.org> <20180327115606.GC29239@sirena.org.uk> <172d1da4-bde0-1f0c-b907-5582c31c8156@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <172d1da4-bde0-1f0c-b907-5582c31c8156@codeaurora.org> X-Cookie: Turn the other cheek. User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 27, 2018 at 04:38:07PM -0700, David Collins wrote: > On 03/27/2018 04:56 AM, Mark Brown wrote: > > I didn't spot this in the code but something called "device tree mode" > > sounds like it's going to be awfully confusing... > As I explained in the earlier email, it makes the device tree > configurations much simpler and less confusing/error prone. I'd like to > keep this concept around unless their are strong objections. Like I say I didn't spot this in the code, I did give it a brief once over but as Doug had spotted such extensive problems I was expecting a resend. It *is* setting off big alarm bells though, in general if your individual driver is doing something weird to make life easier that's a sign that it's doing things at the wrong level. --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlq6+SwACgkQJNaLcl1U h9C+SAf/Xk5fE40iWdnaUAqxbdfK4umBb0ItVeFUEAEC5DU7mZmPPr9R+Ziqog80 V7Kjb7qmjamPSeATF/ShzlEusjGwihXp1V8/M3Tov5Tc9pTAgFWU/2FrasWGAmXs upINCPMZDk7qmBfqb46sFYZd5FL8HSjr0cI4m7xWZKBQMIjRkWrt7S32USdKikiI 6m8fXobyddNS4D9d0OfySaE7/IeOE6KqkcNvWARGrPUdnB5SjbxK5hSLIIauXE2D kNwPWhvGCwLABbmn97g58d2il3JtKCqS9Casek28B568yp+VWYkWRzrhdlQVjv3y z1S5aAniKXr6/AZdi2ti3eBV+V5Qpg== =rd+x -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--