Received: by 10.213.65.68 with SMTP id h4csp167839imn; Tue, 27 Mar 2018 19:37:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx48Mko5dUefV0ZIg3xNKVPYqZAcGRNiNCdqQNB9aPLHsRCm8IN1HcDPiLKX4qwA9s69F8TFr X-Received: by 2002:a17:902:4303:: with SMTP id i3-v6mr1831440pld.302.1522204668608; Tue, 27 Mar 2018 19:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522204668; cv=none; d=google.com; s=arc-20160816; b=kWB8WjM/Qpo+TOJG7gmIEaVc9NVIkG+iR1WbW5oIUlBzSLg0k6Sg+ryTZSMdX9mKEs /8wqFIkL5IMqQfNZrO/EUvZLGdXVA2kk7+VVFF7eoa713xYjdm8vZSEp7ZRX1RcGpZbv VvaDXFiQ49BxLFUQuUUfhNcMAR2HYve32Zc72fm94xhjImD4x1UGo0f4WzdmX3XTlRuK m5ipvLj0syuSz2LmBho56CqYwXToUqQTEIsmW4nv8vI8W8gDwADdVCIHufRuZ5bpgypa O9iRnlH5z2jolA74UWKLQTTBXfl/ASLEdf/FIE6+sOjZz0zCj53GTRVoVpeqa98/xsm1 nlsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=I3JaphjdcJO687S+KRZpMTBYB9A1XtTcW5YQvi/RqM4=; b=ZskDylAkHbqTgPyt3BzGgSser8tVSLjI5o5Im6wqeqJhvy3M4TwBvyXLJVs8cr9RWr 3jk4VcqmMXAAair7M1Fip6/rdiz/toVwaYk4X3VufzLUj3ncx8cmpz4sOY7DIHRNWL3G 2aVjFbBU5Jrot/NyDG4LO4v8PZpleqdzBChBI9GeJ0Fer3VZnKdzltRG1WO7OnLEVTv+ KCWXa26IJBnZJnrfQpAMrhR4jeivyuZhQ88sosBITAXLzqPaCAqXX+IEoamoM+mZFblU KD+oREMCvLYE3QRiqscHjs9eUrHrRE5JHtAb8WzTN0kAT23N0fas0Da2dEoLlMo90WGA 0EOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Bq6E0zlb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si2545926plk.674.2018.03.27.19.37.31; Tue, 27 Mar 2018 19:37:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Bq6E0zlb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbeC1C2T (ORCPT + 99 others); Tue, 27 Mar 2018 22:28:19 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:33386 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbeC1C2R (ORCPT ); Tue, 27 Mar 2018 22:28:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I3JaphjdcJO687S+KRZpMTBYB9A1XtTcW5YQvi/RqM4=; b=Bq6E0zlbD9qMG9cPG/jE+bXSf +hFWHN9N0tVLrKQETu3WlShXDfJZ/rfUp1pf6WJg9qsW0XRMu9rmmniKEcZIoaeAobbOVakCmZY8K 0GFdfcmPfHA1KznsjX1uqgNtrBv3fZZz4LTU+N20L5IZBqNuRVQLOsyJqrOhKpptbJMnc=; Received: from [202.155.252.3] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f10ot-0007f0-Ok; Wed, 28 Mar 2018 02:28:12 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id B75FA44007A; Wed, 28 Mar 2018 03:28:08 +0100 (BST) Date: Wed, 28 Mar 2018 10:28:08 +0800 From: Mark Brown To: Doug Anderson Cc: David Collins , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , sboyd@kernel.org, ilina@codeaurora.org Subject: Re: [PATCH 1/2] regulator: add QCOM RPMh regulator driver Message-ID: <20180328022808.GL29239@sirena.org.uk> References: <71fab82672524b95632cdb588c16edfc9711866a.1521246069.git.collinsd@codeaurora.org> <184378e4-caf8-6ce3-e089-3690588fcb28@codeaurora.org> <20180327115606.GC29239@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sT9gWZPUZYhvPS56" Content-Disposition: inline In-Reply-To: X-Cookie: Serenity through viciousness. User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sT9gWZPUZYhvPS56 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 27, 2018 at 01:51:56PM -0700, Doug Anderson wrote: > Assuming I didn't mess up my analysis, the entire job of of_map_mode() > is to convert from one integer to another. It should take the number > that was specified in the device tree and convert it to a > REGULATOR_MODE_XXX. That means that the regulator framework is > enforcing a distinct and per-regulator numbering system for the mode > (I called this "device tree mode"). OK, the confusion comes from your terminology invention rather than the driver then :( > So basically it sounds like everyone makes up some arbitrary numbering > system that is only used in their device tree files and needs to be > mapped into the standard numbering system... It's not just that. The very modes themselves are not defined at all consistently between regulators - the set of options varies wildly as does the range of applications they are suitable for. We want people to not only define numbers here but also names that make sense in the context of the regulator documentation that can then be mapped into the concept of modes we've inherited in the regulator subsystem. --sT9gWZPUZYhvPS56 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlq6/bcACgkQJNaLcl1U h9CWvgf9F5NH0G4d8M5xivSJZyK25J9g0jvimxPEjnFU1G8G8U0kxG+yckZ5M+Mx eFXKkWyHaSwqQXtwrVhBVIkkY7G4Zrp6mf+E9VHf/K2qrzYS52YE2RfWXhsgmMQ3 VWZF2nr+jCNylhzPcAi2IoWQmFvRL8xvrZS/mJpYukQS3D4J82hIzlOrkM8ixVMQ W2D6mvhBy1FMlvWpBdWvgBSRYXh1JaREBSyF9UkgnrVZS8SYmZyHJzxs3v9LgWLD RQQy/0lPkmNbLu97ct6KHzNy4lNauGrzlgRMA7LLyK6JeSBtjTHrmuBjS7UbJ3SJ jmH4ansyHRyzb0xxyeAOhQreQHqgrw== =VxCl -----END PGP SIGNATURE----- --sT9gWZPUZYhvPS56--