Received: by 10.213.65.68 with SMTP id h4csp118576imn; Tue, 27 Mar 2018 23:33:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+rLKQR1WoXnCidKBt6Cn1B/KBo+p2fWc0TVl3dbNxnrI/sUrzZlTf/LmpWHkGab6qcO6q8 X-Received: by 10.98.214.218 with SMTP id a87mr1961969pfl.124.1522218821303; Tue, 27 Mar 2018 23:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522218821; cv=none; d=google.com; s=arc-20160816; b=SQ1YpVUfwaDLJQzHhb/EywUKXUq3TsnClYtJBX+s4pzhDnnLkYO4GImudKu3f2PFeQ 141pGPcHqXmA6BEJrWhjFtUl7mFePP0o+so3VvXNVzS/NKhWXM0ciwbjeoN0vApuHuWD l5p7+JvtWCTeyZnS3d20/QSaVBNfXw8XCrwoENOdmYNYhQHT6npL4kvxD1XKIjVNWmq2 IgYwt3RCputanxmyamdDHJ5dX8G7UPcbl584mg2c6BdAwNP1V9dVQt8WEHGR/h8k1612 sHTk82CXdzi05Ly0dAmQTVwq0k7fv5BVrrsUHHpxcRV1xLlpffTATXbCIImRfkQ4Vwio dIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=tV/dYTJP6OXTXRF43Ozp2SKgu5wLRd/bV0looSONY24=; b=0sGDt8MiRI7reDH1EWliKlDcnxpbQxIf651+Ow8qqFo3Pu7XbGlvwx1schTKyu263O ZUuuwZjx3uA2c+Dd4dvDePuj8JvwQpj64C/JX5coe0zbQCUAj8da782Mj53AGAC6RVrA Y9g2ObPFLfupOx0F/dJRf6exPX9e1AYwS5tMA970l1P7/1Z8ucBla5o8JJ0OiCXxCBsz n8aY3TKYy+TjCWJcD5DY+2dXTx0jGRIJrBcSGsBoN7MHsaOTpwtUpGoctv6CizaWc5De 62jMhQZca03orCM9iuc83Xx4n61jSuDWVnzX+5rZe+UEGoTCs5U7UPqf19bB1i2B0cZq +1Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si2019810pgc.92.2018.03.27.23.33.25; Tue, 27 Mar 2018 23:33:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbeC1GcJ (ORCPT + 99 others); Wed, 28 Mar 2018 02:32:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35632 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbeC1GcH (ORCPT ); Wed, 28 Mar 2018 02:32:07 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 73C34F91; Wed, 28 Mar 2018 06:32:06 +0000 (UTC) Date: Wed, 28 Mar 2018 08:32:02 +0200 From: "gregkh@linuxfoundation.org" To: Nathan Chancellor Cc: "Kani, Toshi" , "dan.rue@linaro.org" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "bp@suse.de" , "tglx@linutronix.de" , "lious.lilei@hisilicon.com" , "guohanjun@huawei.com" , "wxf.wang@hisilicon.com" , "stable@vger.kernel.org" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "mingo@redhat.com" , "Hocko, Michal" , "cpandya@codeaurora.org" , "willy@infradead.org" Subject: Re: [PATCH 4.4 20/43] mm/vmalloc: add interfaces to free unmapped page table Message-ID: <20180328063202.GB9547@kroah.com> References: <20180327162716.407986916@linuxfoundation.org> <20180327162717.580646019@linuxfoundation.org> <20180327201700.xmgzgqox3sz3z32r@xps> <20180327203130.GA18921@localhost> <1522183239.2693.240.camel@hpe.com> <20180327204755.GA19436@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180327204755.GA19436@localhost> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 01:47:55PM -0700, Nathan Chancellor wrote: > On Tue, Mar 27, 2018 at 08:40:56PM +0000, Kani, Toshi wrote: > > On Tue, 2018-03-27 at 13:31 -0700, Nathan Chancellor wrote: > > > On Tue, Mar 27, 2018 at 03:17:00PM -0500, Dan Rue wrote: > > > > On Tue, Mar 27, 2018 at 06:27:24PM +0200, Greg Kroah-Hartman wrote: > > > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > > > : > > > > > > > > This patch causes the following build error on 4.4 arm64: > > > > > > > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 defconfig > > > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 > > > > > > > > CC arch/arm64/mm/mmu.o > > > > ../arch/arm64/mm/mmu.c:701:5: error: redefinition of ‘pud_free_pmd_page’ > > > > int pud_free_pmd_page(pud_t *pud) > > > > ^~~~~~~~~~~~~~~~~ > > > > In file included from ../arch/arm64/include/asm/pgtable.h:682:0, > > > > from ../include/linux/mm.h:55, > > > > from ../include/linux/mman.h:4, > > > > from ../arch/arm64/mm/mmu.c:25: > > > > ../include/asm-generic/pgtable.h:777:19: note: previous definition of ‘pud_free_pmd_page’ was here > > > > static inline int pud_free_pmd_page(pud_t *pud) > > > > ^~~~~~~~~~~~~~~~~ > > > > ../arch/arm64/mm/mmu.c:706:5: error: redefinition of ‘pmd_free_pte_page’ > > > > int pmd_free_pte_page(pmd_t *pmd) > > > > ^~~~~~~~~~~~~~~~~ > > > > In file included from ../arch/arm64/include/asm/pgtable.h:682:0, > > > > from ../include/linux/mm.h:55, > > > > from ../include/linux/mman.h:4, > > > > from ../arch/arm64/mm/mmu.c:25: > > > > ../include/asm-generic/pgtable.h:781:19: note: previous definition of ‘pmd_free_pte_page’ was here > > > > static inline int pmd_free_pte_page(pmd_t *pmd) > > > > ^~~~~~~~~~~~~~~~~ > > > > make[2]: *** [../scripts/Makefile.build:270: arch/arm64/mm/mmu.o] Error 1 > > > > make[1]: *** [/home/drue/src/linux/4.4-rc/Makefile:969: arch/arm64/mm] Error 2 > > > > make[1]: Leaving directory '/home/drue/src/linux/4.4-rc/build-arm64' > > > > make: *** [Makefile:152: sub-make] Error 2 > > > > > > > > > > > > > > Both of my arm64 devices built fine with this patch... It seems like > > > the only way to hit that error is if HAVE_ARCH_HUGE_VMAP isn't set, > > > which seems impossible since it is selected by ARM64... > > > > > > Someone smarter than I might have more insight but this patch is > > > unchanged from upstream so I can only assume that this error would > > > manifest there as well. > > > > It appears that HAVE_ARCH_HUGE_VMAP was introduced in 4.6 on arm64. > > Hence the problem in 4.4. > > > > Thanks, > > -Toshi > > > > Ah, thanks for the heads up, since I have 324420bf91f6 ("arm64: add > support for ioremap() block mappings") in my tree due to Linaro's > backport of it for their Linaro Stable Kernel, which serves as a base > for most Android kernels. My apologies for not digging deeper and sorry > for the noise! So should I just drop this patch?