Received: by 10.213.65.68 with SMTP id h4csp175503imn; Wed, 28 Mar 2018 01:04:33 -0700 (PDT) X-Google-Smtp-Source: AIpwx48OnvnyFI4DyvMNTgFYeJNKpEIboYEsfNNDF8lEkmcnSjGQsDdzqZBpuF/qrn/RWL0//of/ X-Received: by 2002:a17:902:8212:: with SMTP id x18-v6mr2816065pln.372.1522224273691; Wed, 28 Mar 2018 01:04:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522224273; cv=none; d=google.com; s=arc-20160816; b=arbTit58ZbRhTX6lWMUP6JoafRzZeONmUMGoK5OWgla8KgpGI4KVdHLJfbl1B1C3es 5nMyUrfqUx8ngBfbLkpmf8LsCb9bNno3MO5XuilL4GfxD7jkAxDPsCB8QG6zp+i+fm0y uomDuWlUBrdDiAUKycYbW8ZdC+VsBQdbx50p60JyGq0VRFlhyRlHhCa9rIgwWk2r/2yB ykRw9ytch0CGgVk3UUk2Y854NKD0goUkOGWSso2IqsBBA/SCG8WXc6bGTyl1s2cS13wZ hGbeokCn74FcB55gGWWU9B3IwydxV8K5N6Xef1GG+f6yYMywW6sUFJHOshs67N44a9MX iEzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=3LBGDcMUUKBqxaMrJupKDaEdkqvD5XvSoCOG4elwekc=; b=eeM8i/i+x0DCTFCLK5Ld6SL7zidrl/FcT43v3lBudt4+OPxV3fLPFLF4eN05MIXBN0 shnrcw4H7FvZhhq+stZa0mo2kwehtarRRhUUBBuopm3avmEPylx5AuJQztOEaUVXhOEW w9167nHhXXtvBT+O5HzNLgy+YgGIUaEvrhY8woh9Vyah/iKTgOE1+GlFZL+QPzNrYEq/ PpOncYyRvZJycv5D1+HMfrdWa5k9cjs5uX+wM18xnIYdB5naz4N2QY7xrpMe/0HzkRTy 4RYNs4yaeHEAVr+AwAOIoFIYT8AMLusXlwwlS5HwVYttJO0CsLVk3qBG4NO98QxWsVnQ EQSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p91-v6si3012648plb.705.2018.03.28.01.04.19; Wed, 28 Mar 2018 01:04:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbeC1HxQ (ORCPT + 99 others); Wed, 28 Mar 2018 03:53:16 -0400 Received: from verein.lst.de ([213.95.11.211]:44377 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750753AbeC1HxO (ORCPT ); Wed, 28 Mar 2018 03:53:14 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 356EF68D40; Wed, 28 Mar 2018 09:53:13 +0200 (CEST) Date: Wed, 28 Mar 2018 09:53:13 +0200 From: "hch@lst.de" To: Alexey Brodkin Cc: "andy.shevchenko@gmail.com" , "linux-kernel@vger.kernel.org" , "jesper.nilsson@axis.com" , "Eugeniy.Paltsev@synopsys.com" , "hch@lst.de" , "linux-snps-arc@lists.infradead.org" , "iommu@lists.linux-foundation.org" , "dmaengine@vger.kernel.org" , "Evgeniy.Didin@synopsys.com" , "geert@linux-m68k.org" Subject: Re: dma-mapping: clearing GFP_ZERO flag caused crashes of Ethernet on arc/hsdk board. Message-ID: <20180328075313.GA19864@lst.de> References: <1522170774.2593.9.camel@synopsys.com> <1522185558.6917.7.camel@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522185558.6917.7.camel@synopsys.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The logical question is why? > > 1. See that's another platform with ARC core so maybe in case of ARM > DMA allocator already zeroes pages regardless provided flags - > personally I didn't check that. Yes, most architectures always clear memory returned by dma_alloc*. Looks like a few don't and my commit got them in trouble. As usual I'd prefer to match x86 semantics for now to avoid problems. I'll send patches for arc and s390 which seem to be actually used holdouts, and will look if anyone else is also affected.