Received: by 10.213.65.68 with SMTP id h4csp313546imn; Wed, 28 Mar 2018 04:13:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx48dnCIKqe0uaCXHQ9wrh0ICuq0smdLI0y4tHOF108GEOipp2ISd37+sC8RAKDcRozCpdaTq X-Received: by 10.99.37.196 with SMTP id l187mr2283286pgl.221.1522235618536; Wed, 28 Mar 2018 04:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522235618; cv=none; d=google.com; s=arc-20160816; b=lQ07xP9vn+188zdymFEHfN3y1MG8Pmj3ibUmid/ttf1JzyTAPjEyDKBYuY07ZYPCXY cmwdkUhQPCGF0Srs8nzAhznEHkLogZo2+4TwO66o/DAPy10uTameiQQA+nUcgGICDqi3 9EOETJUyS/ZT2bAz1g2v5vTcaHXQf9uNf7tHwo6GSpumMDTU90/HYkB6U2TmVm6k/eI/ Qrge2VxKT2vHUcdx9hE1TD2Ek0VGKRIK/8xhWDV6DZ+KIUY/iu2nMNkWav6YLFizBdWt XULjzdyd5T7Ri2oYUrvBeRnkPcYoObITRyPmzoCN5nM9Wo9wcjixTSh3cKY2Dc1ckX5/ mEDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=mx0Cnjk2Yn9ks5EWJxhoJ1jJ3tLZs3S3LX65FeDoRRE=; b=SXLSGES0HgyTAtNEY31xSZYvt/JCfonJpCtbsYTHrxbOh0JPmi/Dp/ixVUvD31L0tb F/Z9VxHAyUjjQRYVPAHJzgSVxMDWl0WIsOFoiFKhM/JtpOs06vI53iCujG9TpOYcZzsT gOwC//b3lS9rVlcU8eqloiFlfQEg9X0A6BpGdPE7j5J+OjU0q94eovMW7hlK3/PEI67w vFV4JmbDgu+0a7zi3p6/+qBpNtCH/oItzokgugM9F/nGp42qBSofkHeTsUDpJTrXolxb L3+fjDKYRmABA9rFPW9SkkWLkQI3dP42vw+1GhzDWrWFzW3uoEX4sVOoa4Uc/FNNnKcy atSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T9c2Aw8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g92-v6si3444768plg.256.2018.03.28.04.13.23; Wed, 28 Mar 2018 04:13:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T9c2Aw8v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbeC1LMQ (ORCPT + 99 others); Wed, 28 Mar 2018 07:12:16 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:38024 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbeC1LMN (ORCPT ); Wed, 28 Mar 2018 07:12:13 -0400 Received: by mail-wr0-f194.google.com with SMTP id m13so1853554wrj.5 for ; Wed, 28 Mar 2018 04:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mx0Cnjk2Yn9ks5EWJxhoJ1jJ3tLZs3S3LX65FeDoRRE=; b=T9c2Aw8vgcmMQaLaE2qhBOmBXQ9/sqT+QjUim6P7KkGPgPClofqJkXEzrwIK+2Bg7C zqg952fZT04HbfO7iV2TTbIAuCYsxVxsRPAT6r7yJnoptSDJ+cZ9Be61/9vAeU9QRMpp wlO8SnNMQnB57dq4qhrL8XH/N6+PJd5mORXyU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mx0Cnjk2Yn9ks5EWJxhoJ1jJ3tLZs3S3LX65FeDoRRE=; b=qN9z9qbSIDKoOc7gL2GHa+EDdCi7gmiklCE1HqdiwFLog33WtpKCndFEcF6aQywlf0 4yBzOlLgN9/HYnm9Nwo/ZjsCMZVBr3BuAyt8UBSVcFunal73czJAfO813rF2o5ijNC6o aXWKJ5EGJcK/QjcAsqCtkxzjiPnRElpNbWcqUhxnjuKQ2R/vmWWc7tuFyei+yp0XqiwB afL1OZX7iCBpNjtNqQjOfYraxMzbrPup9yWAi5PXgOTPQeqL/G5gLe8TuA9TITkOm20t vFT8q7yBWN2ltj4dO36eezXWOMzYYJoQbxSeRVWI4baCThaxyjtUe17mnK7M5nktofqx 9emA== X-Gm-Message-State: AElRT7HF0+M7jT8nKnDJ1LBBD21yDQJ45s/+xgQKeS+47t3G0Pgfqxiy CrlU53a3WQH9ZeQIAk4Eeokk+g== X-Received: by 10.223.208.208 with SMTP id z16mr2480788wrh.255.1522235532303; Wed, 28 Mar 2018 04:12:12 -0700 (PDT) Received: from dell ([2.31.163.57]) by smtp.gmail.com with ESMTPSA id z9sm5961210wrz.4.2018.03.28.04.12.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Mar 2018 04:12:11 -0700 (PDT) Date: Wed, 28 Mar 2018 12:12:09 +0100 From: Lee Jones To: Enric Balletbo i Serra Cc: Daniel Thompson , Jingoo Han , Rob Herring , Pavel Machek , Heiko Stuebner , Thierry Reding , Bartlomiej Zolnierkiewicz , Richard Purdie , Jacek Anaszewski , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, groeck@chromium.org, linux-rockchip@lists.infradead.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v6 1/5] pwm-backlight: enable/disable the PWM before/after LCD enable toggle. Message-ID: <20180328111209.qnce2tkisy5txbhj@dell> References: <20180326095213.18362-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180326095213.18362-1-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Mar 2018, Enric Balletbo i Serra wrote: > Before this patch the enable signal was set before the PWM signal and > vice-versa on power off. This sequence is wrong, at least, it is on > the different panels datasheets that I checked, so I inverted the sequence > to follow the specs. > > For reference the following panels have the mentioned sequence: > - N133HSE-EA1 (Innolux) > - N116BGE (Innolux) > - N156BGE-L21 (Innolux) > - B101EAN0 (Auo) > - B101AW03 (Auo) > - LTN101NT05 (Samsung) > - CLAA101WA01A (Chunghwa) > > Signed-off-by: Enric Balletbo i Serra > Acked-by: Daniel Thompson > Acked-by: Jingoo Han > Acked-by: Thierry Reding > --- > Changes since v5: > - Add Acked-by: Thierry Reding > Changes since v4: > - Rebase on top of mainline. > - Add the acks from Daniel Thompson and Jingoo Han. > Changes since v3: > - List the part numbers for the panel checked (Daniel Thompson) > Changes since v2: > - Add this as a separate patch (Thierry Reding) > Changes since v1: > - None > --- > drivers/video/backlight/pwm_bl.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Enric, Please collect all of your Acks and submit a RESEND. I will then apply the set. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog