Received: by 10.213.65.68 with SMTP id h4csp336870imn; Wed, 28 Mar 2018 04:41:31 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/7q7GZ8hlZji7NopPq5XbHw+YEzIBG71R0gh7/ggjRUKD2YtYFcazvXDLXZoSKg+i1gvnk X-Received: by 10.99.183.15 with SMTP id t15mr2383897pgf.416.1522237291758; Wed, 28 Mar 2018 04:41:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522237291; cv=none; d=google.com; s=arc-20160816; b=JxeVxxIumgr9xLMd02R1MO6QARQoKBzCq1cmTed1T+vHLyLJmErj/Ukyb2sovHSldf ViRpQa6HxLXzN+Dl36Wch0tHm7BiVtB8a/mgD8A2GuvP30W/fpMo9+x+ZbQ/qwLQdsjW AVMYsmOx3/VzdtNlI+geVh3kCRvsi9IZyfjFnj6Kjtahl0uZU+lMVEerjop1IR98YclP HXfuTA8ae/2bPzlPxRwPrMLD2FLnTPFZYxPUkLo0RMZ/Z7Vmzi3VF6h8EmOhqEcfhQaJ B4oS9jff4n+mmk54MG1/IQv9xrsKsw4XdXI+8i3pek6XOswJ9YBLyxS+EhUEoiZzwyTr +coA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=EIt1sW1DtgVGCZDkBfyIdNoSLbHRpImuH2wOVuLPRDk=; b=P1MsGTfwq0H9pSvqTwftWpUVOb7ru/T4ztnqgWvJ73gVjYmQhrckVF1Sabzl+at2GE QSgXpah6XNzIa8NjZ1KyAPBG4Lwg7zfPFF/AlOp4FxwgaoDQVqJ1no4OAotgkgVsUBvf PoSfNfi4tqn/QWA2bLnVTu1C8OLcchZ3AXUoQL95mChX8AUqQACAbCeqc6AhU7vZu2b1 kzv1/mNkha1Hg6mHG5YMzt3vFc//LrfD2ZG1cjZQoeIqwYZfa4Yq5ABX3GEP7Vxlv5p3 IbNhNoK3OWMi0bAP683eeYobEPVP00ppou1umuDletx+vmoD+7ytN65WFDoYuUjz0kY9 9I5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g14si2597768pfe.263.2018.03.28.04.41.17; Wed, 28 Mar 2018 04:41:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752887AbeC1Lj6 (ORCPT + 99 others); Wed, 28 Mar 2018 07:39:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60642 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbeC1Ljy (ORCPT ); Wed, 28 Mar 2018 07:39:54 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 10CABF51; Wed, 28 Mar 2018 11:39:53 +0000 (UTC) Date: Wed, 28 Mar 2018 13:39:51 +0200 From: Greg Kroah-Hartman To: Colin King Cc: Aditya Shankar , Ganesh Krishna , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wilc1000: replace kmalloc + memcpy with kmemdup Message-ID: <20180328113951.GA11213@kroah.com> References: <20180326171629.28700-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180326171629.28700-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 06:16:29PM +0100, Colin King wrote: > From: Colin Ian King > > Replace several allocation and memcpys with kmemdup and add in some > missing memory allocation failure checks. Also fix an incorrect > -EFAULT return with -ENOMEM. > > Signed-off-by: Colin Ian King > --- > drivers/staging/wilc1000/host_interface.c | 75 +++++++++++++++++++------------ > 1 file changed, 46 insertions(+), 29 deletions(-) Doesn't apply to my tree anymore, due to patches submitted before yours :( greg k-h