Received: by 10.213.65.68 with SMTP id h4csp346640imn; Wed, 28 Mar 2018 04:54:05 -0700 (PDT) X-Google-Smtp-Source: AIpwx48Fe9R++aLnMYPYFU4sZsbueE6GxWw0sSkJ95Y8B+KtYSaD7Vg6dc4DCWPWhm3ZW55cjz7A X-Received: by 10.99.99.194 with SMTP id x185mr2352214pgb.4.1522238045852; Wed, 28 Mar 2018 04:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522238045; cv=none; d=google.com; s=arc-20160816; b=Sd5K7wZ+knX0/Ipe1CwrIn0Tgy1gs4hwlau20nt2U+31yjcoxpUdFQHSU7tJC3ozh5 tTCL0ThIxziuz+t/NpY20k1spzFZ8uk9CBMmN5v5P4jF1aJ+KnIGMYTGDizLGhd88HdQ uD1u0fIJOo42blaiHvSFwjHK4jGcggOnI5bO+CHwAFKU3Ds4isMhGpSGUx2kLBDyWKHW VFz6r6ThIP2J7l2RcmWGIaOSlhz1qL0T3TmizNuuPXcBlja5CuIzgDcW7CPua8tzUxEC KHE4SFK3RF4+lAq513PC3hJD81lhxvch3Q7EGthKEF08PVVSY9avxHkno+t28V/KhKI9 3yNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=ku6gOhwwgVX4TB5+wiB3fDhwg42vsRu2VfBRIB8nHqg=; b=g8rwcizCrcSfVocSCrYwrXHEwexsZCQRkKkdeZdIJxVridxbd/SQ18w7XUlUNCYe6D KRj+iCmXRoQlsyqkzWl0v/Ha9yflYPMLnV+zfNuWr3irQTYYsf3DKQyhCmBhCMd5r+c2 uRxV6b3W2Jrmwspw7ucrlIi8wUW9wwBjwkiwQA0om/OqiSV2aJV0uc9e72Cdu4SGNbcc wn14/6TwTlTtJRlQyAyNGcNoNyXka/I5Eu0jnGk3VFByCYT9NahpisTubpvnPg2p0hjN jv7yrcmUloMDhlPoIicwx8X5NTRb/bGEe5Yzvm+78H93B9X4faaGj0XVQ3QWyBX4RU6T JMZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c16-v6si3652220plo.675.2018.03.28.04.53.52; Wed, 28 Mar 2018 04:54:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbeC1LvE (ORCPT + 99 others); Wed, 28 Mar 2018 07:51:04 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:53963 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752225AbeC1LvC (ORCPT ); Wed, 28 Mar 2018 07:51:02 -0400 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id E81551846A; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id Duej1gOD6hoc; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: from boulder02.se.axis.com (boulder02.se.axis.com [10.0.8.16]) by bastet.se.axis.com (Postfix) with ESMTPS id 6ECF41806E; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D15E1A077; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: from boulder02.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5176D1A06D; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: from seth.se.axis.com (unknown [10.0.2.172]) by boulder02.se.axis.com (Postfix) with ESMTP; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: from lnxartpec1.se.axis.com (lnxartpec1.se.axis.com [10.88.4.10]) by seth.se.axis.com (Postfix) with ESMTP id 4420620D7; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) Received: by lnxartpec1.se.axis.com (Postfix, from userid 20283) id 3F41240197; Wed, 28 Mar 2018 13:51:00 +0200 (CEST) From: Niklas Cassel To: kishon@ti.com, cyrille.pitchen@free-electrons.com, Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Bjorn Helgaas Cc: Niklas Cassel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 06/12] PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs properly Date: Wed, 28 Mar 2018 13:50:11 +0200 Message-Id: <20180328115018.31921-7-niklas.cassel@axis.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20180328115018.31921-1-niklas.cassel@axis.com> References: <20180328115018.31921-1-niklas.cassel@axis.com> X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since a 64-bit BAR consists of a BAR pair, we need to write to both BARs in the BAR pair to setup the BAR properly. Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pcie-designware-ep.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c index 5a0bb53c795c..571b90f88d84 100644 --- a/drivers/pci/dwc/pcie-designware-ep.c +++ b/drivers/pci/dwc/pcie-designware-ep.c @@ -138,8 +138,15 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8 func_no, return ret; dw_pcie_dbi_ro_wr_en(pci); - dw_pcie_writel_dbi2(pci, reg, size - 1); - dw_pcie_writel_dbi(pci, reg, flags); + if (flags & PCI_BASE_ADDRESS_MEM_TYPE_64) { + dw_pcie_writel_dbi2(pci, reg, lower_32_bits(size - 1)); + dw_pcie_writel_dbi(pci, reg, flags); + dw_pcie_writel_dbi2(pci, reg + 4, upper_32_bits(size - 1)); + dw_pcie_writel_dbi(pci, reg + 4, 0); + } else { + dw_pcie_writel_dbi2(pci, reg, size - 1); + dw_pcie_writel_dbi(pci, reg, flags); + } dw_pcie_dbi_ro_wr_dis(pci); return 0; -- 2.14.2