Received: by 10.213.65.68 with SMTP id h4csp348799imn; Wed, 28 Mar 2018 04:57:00 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+kUbd0BhnI9T5yHX5kWvBUjG2hodgBB+H/Qymbwma/UunmZucb4h+g+Kto3zbH9k1H+p3Z X-Received: by 10.99.173.7 with SMTP id g7mr2364173pgf.170.1522238220003; Wed, 28 Mar 2018 04:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522238219; cv=none; d=google.com; s=arc-20160816; b=MG22tlGXATyFg6yVUN6uqKxn6cr6BvzIsxI7bPskDruYImgnT7EYq5qj+iaCWaJJ8M w+4e4gCxstMrGJf4DQmTPtPrroF3qZmiL6R7iDmnMvNwcftve+pxftJaWR+rMKrZb6Pl YsqW9uUDhcxUHIm5uv+vCLqWP4XDMBRM4L4afFxwqukOtVK+lxDkj8G7yJpnK1IxuB3Y T0SPK/hH/lnk1CaWmyW4ohkRSQYLaT2tU4nlpIk1CEjrGF50Up2wN8iBh8ptSDf7aLlo A+K2oG/qePleGPepoIVF/0RDd4AqiIVv4P+c/6uOaw0asNT8LEP6Vx6qBMqnNal8diGz R/xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=GJW2VHEs9UQJMdLtnJHspJ41w62j85LwRqRQbUZ7dw0=; b=S9mR33AKrZ2vC2YwVLfx42emZXQNEKZ5VfWXht28pE1ZQYot6+VJega3b6/le60uAl Hjelmkh4y4CMQs8OexrGRh0Ks8wJfDBUahtodQs6+9eQT0/qUhKx5Wv9hyQitA8KXyDH n3cAs8vRbn66q080gfEBLVbsYKV2mkjez9QKOsb1QNNqvHRH55gUytJ9GzFEMyZ7Lp/r GAltod1E4FwPaZFMNs3VNsZ8SSyc1HHxPE2UCvtHKS7R4819QEwKafSTC1Aa173Vn6Ln moNCsvl8M4t5VYQTPcB+MzkQAZtB+IjnR+J/ZvaOqEVZKu7So44YQhVCbqM298daSawd kwqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=GEdrjVWJ; dkim=fail header.i=@chromium.org header.s=google header.b=Nctqf5HT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v18si2633318pfa.390.2018.03.28.04.56.46; Wed, 28 Mar 2018 04:56:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=GEdrjVWJ; dkim=fail header.i=@chromium.org header.s=google header.b=Nctqf5HT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752966AbeC1Lzc (ORCPT + 99 others); Wed, 28 Mar 2018 07:55:32 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:42592 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbeC1Lza (ORCPT ); Wed, 28 Mar 2018 07:55:30 -0400 Received: by mail-vk0-f65.google.com with SMTP id y127so1197635vky.9 for ; Wed, 28 Mar 2018 04:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GJW2VHEs9UQJMdLtnJHspJ41w62j85LwRqRQbUZ7dw0=; b=GEdrjVWJBrKfXXPIo2fXcDCWBr7v16kLH4gYGhyMCVqQxpsltvrUHZ8mDZJAO/NkmF kBcDs0urQftpRxLqSb2PxmJou/YJman0Q3t/PZa9Uc9Mdx641XJEEK42LU5zW2VjEhC1 V/lwmu4wIfZfa0l/E5sSi8A9UDeKZu7MiTbW+snbwMNQgChzDYXzwbyvwBRc2gayAaXm R4HUjSI6blSGng+wUvcaTqKTd880oUUZrESX23BTFKlS8JGItgsOK8fSSpVjqUqWEwli skNGYUPzmxzmEqRMDrBqTnfTnUJXSoNqcgNykHH8EvPKGC0cpOGVE9XG/jqtMuHkemmh +JYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GJW2VHEs9UQJMdLtnJHspJ41w62j85LwRqRQbUZ7dw0=; b=Nctqf5HT/Cexvd1B8x4Jej1Zt3U8sW2VNh9P8IhOMlJ/ATA1nWT4EuDWSqGPJthoHe ABYIBas3u0INz8kr7wjUEV13fhAdfc0MKnywEriLXi2z7qC1YdvkyKNxwD9+h4L8Uz/3 CtqQUavrZB6y67B/uWnplJvG2SVaRVDD8FJhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GJW2VHEs9UQJMdLtnJHspJ41w62j85LwRqRQbUZ7dw0=; b=b1pz2YKRZW9FLH+u1ew/S8UENl7YzCfvqZZjNjhDPe7dUcT/N0gSvBSAhfRZ10IOQ4 dOYYSCkrhqGQMWjxB1DSk63UZ6bTq21K17js0pRfZV+UrZn4n/ysloQ8rQ0FCgJEjhGH V24j+zsx9OvJWf7eBlO9OZJE8SpmTDdwSxKS2u6DYELsjpjdNXYVzKPQjz5CA+Avojr+ c55uSKFGxZB5MzokxEGVGdDGpNen1z0ZIarjHM3XOwS0lCBl4QRLd1g0h1UbEyTIRwWu 4HwYszX5RJWX/66vI2CTGGdNWSyOFs4SKqxtebolGtO740p0QYtWijE7QO6dkE69gHtI 20xg== X-Gm-Message-State: AElRT7HwtCzyAgNEt9xHcf5xuuane+JSFBHbQ8+/vQi6JKbZ+gpYM0eL bJphQtcxtsf/8zl/tkMEdJqNfSFke2nnrDBZK25Uzg== X-Received: by 10.31.47.147 with SMTP id v141mr1980676vkv.121.1522238129955; Wed, 28 Mar 2018 04:55:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.129.9 with HTTP; Wed, 28 Mar 2018 04:55:29 -0700 (PDT) In-Reply-To: <1522128575-5326-22-git-send-email-yamada.masahiro@socionext.com> References: <1522128575-5326-1-git-send-email-yamada.masahiro@socionext.com> <1522128575-5326-22-git-send-email-yamada.masahiro@socionext.com> From: Kees Cook Date: Wed, 28 Mar 2018 04:55:29 -0700 X-Google-Sender-Auth: BmhAWYWzRsQLUThgzvJLbyHgG5o Message-ID: Subject: Re: [PATCH v2 21/21] arm64: move GCC version check for ARCH_SUPPORTS_INT128 to Kconfig To: Masahiro Yamada Cc: linux-kbuild , Sam Ravnborg , Linus Torvalds , Arnd Bergmann , Ulf Magnusson , Thomas Gleixner , Greg Kroah-Hartman , Randy Dunlap , "Luis R . Rodriguez" , Nicolas Pitre , Will Deacon , Catalin Marinas , LKML , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 26, 2018 at 10:29 PM, Masahiro Yamada wrote: > This becomes much neater in Kconfig. > > Signed-off-by: Masahiro Yamada Is there a reason this doesn't have a cc-option test, or was this a silent addition to the compiler? (And as such, should there be a comment for this in the Kconfig?) Regardless: Reviewed-by: Kees Cook -Kees -- Kees Cook Pixel Security