Received: by 10.213.65.68 with SMTP id h4csp349818imn; Wed, 28 Mar 2018 04:58:21 -0700 (PDT) X-Google-Smtp-Source: AIpwx48RAJqwe1LuFurh87m+LLTLNUIrlQPW+Pmk1pl2O0VNT8zRqaHT8q87z/8P07BlK+6c+FIu X-Received: by 2002:a17:902:228:: with SMTP id 37-v6mr3521682plc.141.1522238301180; Wed, 28 Mar 2018 04:58:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522238301; cv=none; d=google.com; s=arc-20160816; b=ScwtyBPYxSy8oKQtCSGXKn2IwOb5yTBhHxovOCPCVdtkauOIQGCrKQ3wt+s8ClJLZU 78wSsc4kWTc5E8SCnBY6t2UmxH0vuVgFfg4bMKN4af0wcmZdlxicP5OMeIsLlniSHkIp +C5xXktCwXsYv8uAS+2GXGcGcRIdAZ0tM4KqT2PAuGgSET2hlgtEbSRerhKOVSZTnlm+ XTpNB5F+5LDoB74rzhWE1AhuJQ/H+Cbz6P7HQycF/FhFSR8hHhMmdMPISmPUJl1kTgRV lP9BBQgzF2yFwERohiZscjVz8kfOHgRAyP602z/FLT49Km4UDdZpE96F1Y7keNNzaa6n SNdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=G70a5v0ULq3Kj0pcAnF6qynsTgnYRDI83SamZTlnZ6Q=; b=p09697ki9Jl4sfkCp3f9MFbI1DMNGe47x38ea4N660ZiFb+8H8gbcS25pMIIa+wYJq McGNPB5SJyymmpVoyO6Dc2hTDMktQkUUYioSkRPbz0rxxxoWpMfdTWpYjrIloiRXPE7K cnxcWYPVQQYSJMXjsoF7gSjv2ZeWjuIjK19JfyhoIMM+iBsFyJ3y/3ej5gN9grsjidc2 bwcK8vs1dCaBxJ8t1s1OQ4tE7zo96bxglPJtLTkOL8vieCWgT4SBnH/VvF2oSpYQeS5H loaEHTtPuGDGbGnWl/xtSg7mLiVbH0ebaf/+Gv3f3npqh6O53TuldECSAG4qG2RNO10Q 038g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m39-v6si3475024plg.151.2018.03.28.04.58.06; Wed, 28 Mar 2018 04:58:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752618AbeC1L5F (ORCPT + 99 others); Wed, 28 Mar 2018 07:57:05 -0400 Received: from verein.lst.de ([213.95.11.211]:45378 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbeC1L5E (ORCPT ); Wed, 28 Mar 2018 07:57:04 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id B4C7C68D3A; Wed, 28 Mar 2018 13:57:03 +0200 (CEST) Date: Wed, 28 Mar 2018 13:57:03 +0200 From: Christoph Hellwig To: Sebastian Ott Cc: Christoph Hellwig , Jesper Nilsson , Geert Uytterhoeven , linux-kernel@vger.kernel.org Subject: Re: dma_zalloc_coherent broken with 57bf5a8963f80fb3828c46c3e3a5b2dd790e09a7 Message-ID: <20180328115703.GA31426@lst.de> References: <20180327143341.GA4968@lst.de> <20180327164505.GA10522@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 27, 2018 at 07:04:51PM +0200, Sebastian Ott wrote: > What was wrong with the old behavior (let the caller decide - the same > as with memory allocations)? The old behavior on most (all?) mainstream architectures is that we always zero the return value. On x86/i386 this goes back to at least Linux 2.4. So common drivers simply expect this to happen.