Received: by 10.213.65.68 with SMTP id h4csp423251imn; Wed, 28 Mar 2018 06:17:18 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+w/RXjkALV7susPEodmvMWmOuD5HI0Agn9HTs7/TPlT3GzpDK5LYLVY3utQiFiaQxM6Ut+ X-Received: by 2002:a17:902:a9c4:: with SMTP id b4-v6mr3860766plr.333.1522243037985; Wed, 28 Mar 2018 06:17:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522243037; cv=none; d=google.com; s=arc-20160816; b=xjBM9rNYdfbZAJZ+H4+diSKfnkC3Kd3hXDCKe+DpukacWKo9eHmZwgpF1f/pPt5Jwn ivTN3CsI5TDreKTSQlUG3y7FJY0rYga1YzuROGJ9VduloVSdlCyxrWt85EOPksj6hoeZ nZ8IRFkr0S8XrDEllDlli0m96+3+IX9loKE4VTCYVyudfo6gYHLQTaQ1Re6gmJ2X9mjn PZ7anevoSqQWTqMDOgtHyv1UPeYht6+CarwHqfwA104Z2uWUH0dXUSj/eaKS2f2Tim8O bYuPB1dZM9M58gBM8bpRqIb2P//FZvnz1qB1rb4j+kV+q7W5y7OaYN7U+QKpBHZUXY6u EURg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=VV00s4up9mTEt9vZvXR+37nfcy8MuIb1FflqN0xrDJk=; b=lj0TbLFb4AHteu4MHsU/l3tqVYywI17XCl/NQ3OcQ3cnBG8NyECch9lHnP7l0LCcPM NZnYeUnGRay4ESsEf2bB6jSDBFSdpjZE2FJILvWOQ5sb/ja0BBhCTzOfSYMtAZGRjDUQ 366Defp0oRaVGahvqkUDgqdFey6pIU/57G8NtcWZKZTYbYzCRnlv4MT14MOafc2LsJot VpdfG82l8v4oH9domQw6gED3QWD0MgLFoW4aIz1Bo/YeyGguka9vzIfjuJEgVr5MsJrq 7TSapWqM9Ey6QIs3BHF99Qm6qKYeAXTqFFH450RLcly9/xQqxgUkyn/hesbnszU6sWTY RWzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24-v6si3419839plo.273.2018.03.28.06.17.03; Wed, 28 Mar 2018 06:17:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbeC1NPj (ORCPT + 99 others); Wed, 28 Mar 2018 09:15:39 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:59853 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753278AbeC1NPh (ORCPT ); Wed, 28 Mar 2018 09:15:37 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 3DA4810C1366; Wed, 28 Mar 2018 06:15:37 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 24BF13484; Wed, 28 Mar 2018 06:15:37 -0700 (PDT) Received: from pt02.synopsys.com (pt02.synopsys.com [10.107.23.240]) by mailhost.synopsys.com (Postfix) with ESMTP id DC12B347F; Wed, 28 Mar 2018 06:15:36 -0700 (PDT) Received: from [127.0.0.1] (gustavo-e7480.internal.synopsys.com [10.107.25.102]) by pt02.synopsys.com (Postfix) with ESMTP id 425853D2FC; Wed, 28 Mar 2018 14:15:36 +0100 (WEST) Subject: Re: [PATCH v5 11/12] PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs properly To: Niklas Cassel , "kishon@ti.com" , "cyrille.pitchen@free-electrons.com" , Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Bjorn Helgaas Cc: Niklas Cassel , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20180328115018.31921-1-niklas.cassel@axis.com> <20180328115018.31921-12-niklas.cassel@axis.com> From: Gustavo Pimentel Message-ID: <71fe27b4-60ca-898e-e41c-5e93f9b44af2@synopsys.com> Date: Wed, 28 Mar 2018 14:14:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328115018.31921-12-niklas.cassel@axis.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On 28/03/2018 12:50, Niklas Cassel wrote: > Since a 64-bit BAR consists of a BAR pair, we need to write to both > BARs in the BAR pair to clear the BAR properly. > > Signed-off-by: Niklas Cassel > --- > drivers/pci/dwc/pcie-designware-ep.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c > index cc4d8381c1dc..4d304e3ccf24 100644 > --- a/drivers/pci/dwc/pcie-designware-ep.c > +++ b/drivers/pci/dwc/pcie-designware-ep.c > @@ -28,6 +28,10 @@ static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar, > dw_pcie_dbi_ro_wr_en(pci); > dw_pcie_writel_dbi2(pci, reg, 0x0); > dw_pcie_writel_dbi(pci, reg, 0x0); > + if (flags & PCI_BASE_ADDRESS_MEM_TYPE_64) { > + dw_pcie_writel_dbi2(pci, reg + 4, 0x0); > + dw_pcie_writel_dbi(pci, reg + 4, 0x0); > + } > dw_pcie_dbi_ro_wr_dis(pci); > } > > Seems good to me. :) Reviewed-by: Gustavo Pimentel