Received: by 10.213.65.68 with SMTP id h4csp481194imn; Wed, 28 Mar 2018 07:15:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/5/4p6hYY9sakOahbFunteKJqqbdRPR13N3xPqAYR1+SPKygskkSXujbGJJap8C6ElMdab X-Received: by 2002:a17:902:3041:: with SMTP id u59-v6mr3917552plb.208.1522246504597; Wed, 28 Mar 2018 07:15:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522246504; cv=none; d=google.com; s=arc-20160816; b=CRqo6+3L1n7HqUKchq9AAQ5OzOpLGidoV1sYFZz9qf+hnqEGWZQ0IDoiuIg9oeP0PT /XE3qaop17iHlSYWI1Zv9u8iRJ/h+Dr2Afes4fAoNXbWhGXUbISkzGp2WMW9+acUo4XD aTrVyf6CIZQP/LNQ59tKBo6T+tJQcbB8GO94OYSfsQHe/U1JnYEzUVzEK0arhFGi8Wel VeMDYiKfqutkLMdwVdloKu1uLjlluy8YC9bpMOw5f7jYVzXj9eaLvPztivphCBnHZJFe SYDfH8vIBo5KMpPVfx/Ss0JFPViFGRCYgDYnBs02yzL70/wpjl4V+W70TioAK1W5HKl7 I71g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date :arc-authentication-results; bh=lro583v8ilTqYWoxwrfpkXHWaFTMqaipv8OzfGCzcwg=; b=IxxE5KEzQEW670XS7WkJ2NytlF4HSJEXLY8blzn+tnum44wX9wFgORp3KTV/GZkuT2 9stG4+iYRg8d/T5SvECIs4vf8cjAai8xVJQ3s/L/mXuOPKwS9fd6Bi14fmE7Vvi1Cm0l O1HKdRWkRjIUSIemp/Tjp9ia4Fz6LZ6HozSx7gcaSbV/q5PzjBtNfY4EN7ylSXVrub0p P3xB+nitV9TN4uoIpjmcUzuVOVSIpMMFEW+wK9Ryv20AlPWEDxqZdUziBpNzlp+mFM5D e1+atYA7Sd6A1yjVMXvmaWk01tNeU/KmfBid8Jx52/txkPIKS3M/7ahx2RTd7YA5Q6TH AVZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si2473606pgn.340.2018.03.28.07.14.49; Wed, 28 Mar 2018 07:15:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508AbeC1ONm (ORCPT + 99 others); Wed, 28 Mar 2018 10:13:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:37759 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbeC1ONl (ORCPT ); Wed, 28 Mar 2018 10:13:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BF601B011; Wed, 28 Mar 2018 14:13:39 +0000 (UTC) Date: Wed, 28 Mar 2018 16:13:38 +0200 (CEST) From: Jiri Kosina To: Nicolas Boichat cc: Benjamin Tissoires , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, groeck@chromium.org, dtor@chromium.org, Haridhar Kalvala Subject: Re: [PATCH] HID: google: Enable PM Full On mode when adjusting backlight In-Reply-To: <20180328061610.206090-1-drinkcat@chromium.org> Message-ID: References: <20180328061610.206090-1-drinkcat@chromium.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Mar 2018, Nicolas Boichat wrote: > From: Haridhar Kalvala > > hammer LED backlight brightness is not getting set when USB > device is in suspend state. > > This patch fixes the issue by requesting USB HID device to be > in FULLON mode, so that sending hardware output report and > hardware raw request won't fail to set brightness, and set > device back to NORMAL mode once this call returns. > > Signed-off-by: Haridhar Kalvala > Reviewed-by: Dmitry Torokhov > Signed-off-by: Nicolas Boichat Applied to for-4.17/google-hammer. Thanks, -- Jiri Kosina SUSE Labs