Received: by 10.213.65.68 with SMTP id h4csp810145imn; Wed, 28 Mar 2018 13:13:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx4968feCFXawrCh5B0y+I8JMCVTYOZdF6wZw3kqzKxXebMaFNSsoE0NVXkr5eDX8oaNDfvvE X-Received: by 2002:a17:902:6b02:: with SMTP id o2-v6mr5281309plk.334.1522268015494; Wed, 28 Mar 2018 13:13:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522268015; cv=none; d=google.com; s=arc-20160816; b=yo3DAPJYAjI0cfz9+tjLpBTXnriA397yyjbuDcyLzObGderMomTGDGoSzl7nGB6wux Go5595A1fAQzR1BbpNN2/CTPrEBzQzv2LbFLcpRhc6ED43ev3Wchsvc4uWLxUv3WvSjK 71aNBtmBD2uNNwFg3Bo9Q07lTuRovYhgma7yn36KzuTQbiQxeG7fK3PzBYStlDxyjxxg QHmkVyX93X9fU1xlTvfR94QaFqu5UGVseyiBzVnQgvvaNLjoL/0QEpbzJdelvf2hQHDA zW7ci72pDunIfDp5bp3dndqcJUpIDpIqwlopNzHeEdbj6wyIMrqsLZFYJKYa14Di0U76 tj2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Rx8HwQVRjkJZnEkDNQG0nOXZqRGeOIr5o7f9QQMMIHE=; b=0NsqEdjP1mTc9/lKC7cPpaAokum0gw2K6HYtWvn8l/mn5biFv8XF//9CPmN8DzEYQi dEmneEAdpWtdqp3KVX5GrXd6kkKJ2UNRkQPZOvOvRhlcjbrsuPX8IwzQUlNVjACwT8iS dWbcd8lLmNZHYqDazMnr1qVFbganEEzufSKbXnmcunYmd3NHYW5hhljVSxROEQ4xIB4z Z4bWqPIUOI3ca59Ydtk89VHviBAED9bTP6JNjlXtfrG9Ul71WGI8XPif54pWM/rMiHiQ J2ncsZxLJCwDSESCOI2RX0rvpWcu0YQusJCpnIJi2RT6/PdBBvuTV19Ri7UKr06Zbj/f AGyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si1830940plz.467.2018.03.28.13.13.21; Wed, 28 Mar 2018 13:13:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753676AbeC1ULu (ORCPT + 99 others); Wed, 28 Mar 2018 16:11:50 -0400 Received: from mga14.intel.com ([192.55.52.115]:46820 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397AbeC1ULJ (ORCPT ); Wed, 28 Mar 2018 16:11:09 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2018 13:11:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,373,1517904000"; d="scan'208";a="37650443" Received: from tzanussi-mobl.amr.corp.intel.com (HELO localhost) ([10.252.193.206]) by FMSMGA003.fm.intel.com with ESMTP; 28 Mar 2018 13:11:06 -0700 From: Tom Zanussi To: rostedt@goodmis.org Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com, joelaf@google.com, mathieu.desnoyers@efficios.com, baohong.liu@intel.com, rajvi.jingar@intel.com, julia@ni.com, fengguang.wu@intel.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Tom Zanussi Subject: [PATCH 2/4] tracing: Don't add flag strings when displaying variable references Date: Wed, 28 Mar 2018 15:10:54 -0500 Message-Id: <913318a5610ef6b24af2522575f671fa6ee19b6b.1522256721.git.tom.zanussi@linux.intel.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable references should never have flags appended when displayed - prevent that from happening. Before: # cat /sys/kernel/debug/tracing/events/sched/sched_switch/trigger hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0.usecs:... After: hist:keys=next_pid:vals=hitcount:wakeup_lat=common_timestamp.usecs-$ts0:... Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index fb81447..468e43f 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -2052,7 +2052,7 @@ static void expr_field_str(struct hist_field *field, char *expr) strcat(expr, hist_field_name(field, 0)); - if (field->flags) { + if (field->flags && !(field->flags & HIST_FIELD_FL_VAR_REF)) { const char *flags_str = get_hist_field_flags(field); if (flags_str) { -- 1.9.3